From: "Andreas Färber" <afaerber@suse.de>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: mturquette@baylibre.com, sboyd@codeaurora.org,
robh+dt@kernel.org, mark.rutland@arm.com,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
davem@davemloft.net, mchehab@kernel.org, rdunlap@infradead.org,
daniel.thompson@linaro.org, amit.kucheria@linaro.org,
liuwei@actions-semi.com
Subject: Re: [PATCH 0/3] Add clock driver for Actions S900 SoC
Date: Sat, 4 Nov 2017 17:05:31 +0800 [thread overview]
Message-ID: <62797b3b-a622-48a1-9dc5-3cc2b5c7afd3@suse.de> (raw)
In-Reply-To: <1509479663-8985-1-git-send-email-manivannan.sadhasivam@linaro.org>
Hi Mani,
Am 01.11.2017 um 03:54 schrieb Manivannan Sadhasivam:
> This series adds clock driver for Actions Semi OWL series
> S900 SoC with relevant clock bindings and device tree data.
>
> This series also addresses the review comments from previous
> submission happened last year.
>
> https://patchwork.kernel.org/patch/9254471/
Interesting - I had searched for any S500/S900 patches before starting
to work on this but came up empty on LAKML.
It seems you missed at least one review comment from 2016 about the
example indentation, so please double-check for anything Stephen already
pointed out.
> Driver has been validated on Bubblegum-96 board.
>
> Thanks,
> Mani
>
> Manivannan Sadhasivam (3):
> arm64: dts: actions: add s900 clock controller nodes
> clk: owl: add clock driver for Actions S900 SoC
> Documentation: add Actions S900 clock bindings
Please reverse the patch order.
Have you checked S500 code whether the S900 vs. common split is correct?
Many thanks for your work on this,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2017-11-04 9:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 19:54 Manivannan Sadhasivam
2017-10-31 19:54 ` [PATCH 1/3] arm64: dts: actions: add s900 clock controller nodes Manivannan Sadhasivam
2017-11-02 0:06 ` Rob Herring
2017-11-02 17:55 ` Manivannan Sadhasivam
2017-11-04 9:02 ` Manivannan Sadhasivam
2017-11-04 8:43 ` Andreas Färber
2017-11-04 9:50 ` Manivannan Sadhasivam
2017-10-31 19:54 ` [PATCH 2/3] clk: owl: add clock driver for Actions S900 SoC Manivannan Sadhasivam
2017-11-02 0:02 ` Rob Herring
2017-11-02 18:41 ` Manivannan Sadhasivam
2017-11-04 8:36 ` Andreas Färber
2017-11-04 9:19 ` Manivannan Sadhasivam
2017-11-04 9:30 ` Andreas Färber
2017-11-04 9:54 ` Manivannan Sadhasivam
2017-10-31 19:54 ` [PATCH 3/3] Documentation: add Actions S900 clock bindings Manivannan Sadhasivam
2017-11-02 0:04 ` Rob Herring
2017-11-02 18:47 ` Manivannan Sadhasivam
2017-11-04 9:28 ` Manivannan Sadhasivam
2017-11-04 8:55 ` Andreas Färber
2017-11-04 9:41 ` Manivannan Sadhasivam
2017-11-04 9:05 ` Andreas Färber [this message]
2017-11-04 10:04 ` [PATCH 0/3] Add clock driver for Actions S900 SoC Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62797b3b-a622-48a1-9dc5-3cc2b5c7afd3@suse.de \
--to=afaerber@suse.de \
--cc=amit.kucheria@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuwei@actions-semi.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=mturquette@baylibre.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®