From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752961AbdAZIoM (ORCPT ); Thu, 26 Jan 2017 03:44:12 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:31334 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752830AbdAZIoK (ORCPT ); Thu, 26 Jan 2017 03:44:10 -0500 X-AuditID: cbfec7f4-f79716d000006f65-15-5889b6d5a2d7 Subject: Re: [PATCH 4/7] arm64: dts: exynos: Add clocks to Exynos5433 LPASS module To: Krzysztof Kozlowski Cc: linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Sylwester Nawrocki , Linus Walleij , Tomasz Figa , Lee Jones , Bartlomiej Zolnierkiewicz From: Marek Szyprowski Message-id: <627ea264-535d-2c89-3987-02b8620d9328@samsung.com> Date: Thu, 26 Jan 2017 09:44:03 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-version: 1.0 In-reply-to: Content-type: text/plain; charset=utf-8; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrIKsWRmVeSWpSXmKPExsWy7djP87pXt3VGGCy9xWOxccZ6Vovz5zew W9z/epTRYsqf5UwWmx5fY7XYPP8Po8XlXXPYLGac38dkcfhNO6vFql1/GB24PHbOusvusWlV J5vHnWt72Dw2L6n36NuyitHj8ya5ALYoLpuU1JzMstQifbsErozW+6fYCy7yVeycsZ6lgXEb dxcjJ4eEgIlE++MzTBC2mMSFe+vZQGwhgaWMEuvvFXcxcgHZnxklVvxdygrTsOJ5FxtEYhmj xLYll9khnOeMEg8Xr2HsYuTgEBYIkTjwyBOkQURAU+L63++sIDXMAg+ZJDasegI2iU3AUKLr bRfYOl4BO4kNR08zgfSyCKhKTD7kDRIWFYiRaDj1kx2iRFDix+R7LCAlnALBEu17XEHCzAJW Es/+tbJC2PISm9e8ZQZZJSFwiF1i7tYbYCMlBGQlNh1ghrjfRWLR7QZ2CFtY4tXxLVC2jERn x0FoQPQzSjS1akPYMxglzr3lhbCtJQ4fvwi1i09i0rbpzBDjeSU62oQgSjwk7kycCQ0qR4mO lSdZIaHTzCzRsmcyywRG+VlIvpmF5IVZSF5YwMi8ilEktbQ4Nz212ESvODG3uDQvXS85P3cT IzDhnP53/MsOxsXHrA4xCnAwKvHwHtjRESHEmlhWXJl7iFGCg1lJhPf86s4IId6UxMqq1KL8 +KLSnNTiQ4zSHCxK4rx7FlwJFxJITyxJzU5NLUgtgskycXBKNTByTzCJl+xj2deU33BYrfQB t9tWzqdTrn/12HrTuPe7WJwi782Nsp4KkqcdGw4nhfNw/Av9+PLMgS+PYh0YPny27ZlSq/c7 ynrThZ+PWxqdrren7Eg5MVdzVtoloUUvL51Sjejpv3yzm8N3os29g0uSli5QKalM6LOXePqQ T25J4Cnj7LfvpvkpsRRnJBpqMRcVJwIA/YpEzzQDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrEIsWRmVeSWpSXmKPExsVy+t/xq7oi2zsjDFp/qFtsnLGe1eL8+Q3s Fve/HmW0mPJnOZPFpsfXWC02z//DaHF51xw2ixnn9zFZHH7TzmqxatcfRgcuj52z7rJ7bFrV yeZx59oeNo/NS+o9+rasYvT4vEkugC3KzSYjNTEltUghNS85PyUzL91WKTTETddCSSEvMTfV VilC1zckSEmhLDGnFMgzMkADDs4B7sFK+nYJbhmt90+xF1zkq9g5Yz1LA+M27i5GTg4JAROJ Fc+72CBsMYkL99YD2VwcQgJLGCV6fsxhhXCeM0rMWvYHyOHgEBYIkTjwyBOkQURAU+L63+9Q Nc3MEr9X/2cHcZgFHjNJbJi9ggmkik3AUKLrLcQKXgE7iQ1HTzOBDGIRUJWYfMgbJCwqECPx dv1ydogSQYkfk++xdDGyc3AKBEs8DwWJMguYSXx5eZgVwpaX2LzmLfMERoFZSBpmISmbhaRs ASPzKkaR1NLi3PTcYkO94sTc4tK8dL3k/NxNjMD423bs5+YdjJc2Bh9iFOBgVOLhPbCjI0KI NbGsuDL3EKMEB7OSCO/51Z0RQrwpiZVVqUX58UWlOanFhxhNgT6YyCwlmpwPTA15JfGGJobm loZGxhYW5kZGSuK8JR+uhAsJpCeWpGanphakFsH0MXFwSjUwuv5423km443+x22VCVFvGH0E nuckd1Z5hDx/XfUhST1VhCtn8ckTCnXPutT3Ob49Zpc5w6GtoLB0pV/V14f+02TO8t2bk91h 8LfXL8pl935jURellyuer+fQqMhqVnb8xRVnXjBvJVdzbmeG+5R2G2sl8bC7dwoDj615Zp3k fyT+yGwx9ztKLMUZiYZazEXFiQDYMxZP1QIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170126084404eucas1p1db20f7164a3320a95275af41d1746154 X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?TWFyZWsgU3p5cHJvd3NraRtTUlBPTC1LZXJuZWwgKFRQKRs=?= =?UTF-8?B?7IK87ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?TWFyZWsgU3p5cHJvd3NraRtTUlBPTC1LZXJuZWwgKFRQKRtT?= =?UTF-8?B?YW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170125115103eucas1p1d0e446fa6e998da257e3c17922a00d7f X-RootMTR: 20170125115103eucas1p1d0e446fa6e998da257e3c17922a00d7f References: <1485345031-2948-1-git-send-email-m.szyprowski@samsung.com> <1485345031-2948-5-git-send-email-m.szyprowski@samsung.com> <20170125195022.yiqxnfted2vw4owh@kozik-lap> <2eabe488-1e58-4320-6d6f-f7844ee06998@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On 2017-01-26 09:40, Krzysztof Kozlowski wrote: > On Thu, Jan 26, 2017 at 9:18 AM, Marek Szyprowski > wrote: >> On 2017-01-25 20:50, Krzysztof Kozlowski wrote: >>> On Wed, Jan 25, 2017 at 12:50:28PM +0100, Marek Szyprowski wrote: >>>> Exynos5433 LPASS module requires some clocks for proper operation with >>>> power domain. >>>> >>>> Signed-off-by: Marek Szyprowski >>>> --- >>>> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 2 ++ >>>> 1 file changed, 2 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi >>>> b/arch/arm64/boot/dts/exynos/exynos5433.dtsi >>>> index 57c7bbeb65a7..16072c1c3ed3 100644 >>>> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi >>>> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi >>>> @@ -1494,6 +1494,8 @@ >>>> audio-subsystem@11400000 { >>>> compatible = "samsung,exynos5433-lpass"; >>>> reg = <0x11400000 0x100>, <0x11500000 0x08>; >>>> + clocks = <&cmu_aud CLK_PCLK_SFR0_CTRL>; >>>> + clock-names = "sfr0_ctrl"; >>> You wrote that 6/7 depends on this. I prefer not to take DTS changes if >>> the corresponding user (driver) is still under discussion because the >>> bindings might change. I'll take it when bindings got acked or accepted. >> >> Well, audio support in 4.9 is still not functional due to missing other >> patches to ALSA SoC, so nothing will break as for now if we manage to get >> this into v4.10. > Get this into v4.10? So this needs some additional explanation in the > commit message why this is a fix. Probably one more sentence would be > enough. Or did you mean v4.11? Yes, I meant v4.11. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland