From: Joe Perches <joe@perches.com>
To: Sandro Volery <sandro@volery.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, jslaby@suse.com
Subject: Re: [PATCH] Fixed most indent issues in tty_io.c
Date: Sat, 07 Sep 2019 13:01:10 -0700 [thread overview]
Message-ID: <628cfe909375f444c33ef4da0b09a32dbff0303b.camel@perches.com> (raw)
In-Reply-To: <9A23770B-49B8-4DB1-8B45-22F3650E0CB8@volery.com>
On Sat, 2019-09-07 at 21:51 +0200, Sandro Volery wrote:
> > On 7 Sep 2019, at 21:27, Joe Perches <joe@perches.com> wrote:
[]
> > As long as git diff -w shows no difference and a compiled
> > object comparison before and after the change shows no
> > difference, I think it's fine.
>
> My thoughts, too. I didn't feel comfortable arguing as a newbie tho
> so I'll see what I can do once I get home.
If you do that, it's important to mention both elements in
the commit message:
1: git diff -w shows no difference
2: pre and post compilation objects are identical
It is also good to verify that allyesconfig and defconfig
objects with the minimal CONFIG_ required for compilation
are also identical.
Whitespace only changes should only change horizontal
spacing and should not have vertical line changes.
next prev parent reply other threads:[~2019-09-07 20:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190907172944.GB18166@kroah.com>
2019-09-07 17:35 ` Sandro Volery
2019-09-07 17:42 ` Greg KH
2019-09-07 17:49 ` Sandro Volery
2019-09-07 18:02 ` Greg KH
2019-09-07 18:05 ` Sandro Volery LKML
2019-09-07 19:27 ` Joe Perches
2019-09-07 19:51 ` Sandro Volery
2019-09-07 20:01 ` Joe Perches [this message]
2019-09-08 23:32 Sandro Volery
-- strict thread matches above, loose matches on Subject: below --
2019-09-07 9:09 volery
2019-09-07 17:07 ` Greg KH
2019-09-07 20:04 ` Joe Perches
2019-09-07 20:30 ` Sandro Volery
2019-09-08 20:59 ` Theodore Y. Ts'o
2019-09-09 8:17 ` Sandro Volery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=628cfe909375f444c33ef4da0b09a32dbff0303b.camel@perches.com \
--to=joe@perches.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sandro@volery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®