From: Md Sadre Alam <quic_mdalam@quicinc.com>
To: Pratyush Yadav <pratyush@kernel.org>, Michael Walle <michael@walle.cc>
Cc: <tudor.ambarus@linaro.org>, <miquel.raynal@bootlin.com>,
<richard@nod.at>, <vigneshr@ti.com>,
<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
<quic_srichara@quicinc.com>, <quic_varada@quicinc.com>
Subject: Re: [PATCH] mtd: spi-nor: Ensure operation completion before shutdown
Date: Wed, 18 Oct 2023 16:37:34 +0530 [thread overview]
Message-ID: <62909863-5f1d-7fc7-3fd5-a8da0caa89ba@quicinc.com> (raw)
In-Reply-To: <mafs034ygm9yc.fsf@kernel.org>
On 10/12/2023 3:36 PM, Pratyush Yadav wrote:
> On Thu, Oct 12 2023, Michael Walle wrote:
>
>> Hi,
>>
>> Am 2023-10-12 07:51, schrieb Md Sadre Alam:
>>> Ensure that there are no pending spi operation inprogress
>>> when system halts.
>>
>> What operation might be in progress here? Did you encounter some problems?
>> Please explain it in more detail in the commit message.
>
> +1
>
> Ideally we should never reach this function with a pending operation. I
> think we should do a proper wait in the place we did the operation that
> needs waiting rather than here. That would make sure operations other
> than shutdown, like reads, also work properly.
>
We have faced issue while doing nor flash read/write test with specific nor part.
Will check once again with the same part and post new patch.
next prev parent reply other threads:[~2023-10-18 11:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 5:51 Md Sadre Alam
2023-10-12 9:11 ` Michael Walle
2023-10-12 10:06 ` Pratyush Yadav
2023-10-18 11:07 ` Md Sadre Alam [this message]
2023-10-18 11:06 ` Md Sadre Alam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62909863-5f1d-7fc7-3fd5-a8da0caa89ba@quicinc.com \
--to=quic_mdalam@quicinc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=pratyush@kernel.org \
--cc=quic_srichara@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=richard@nod.at \
--cc=tudor.ambarus@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®