From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AC112EFDBB for ; Wed, 3 Dec 2025 11:24:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764761069; cv=none; b=G+LtIdPLmyxipzatSsahQQVzjee5XFu08x849czCBG5UMRAniOLSdO0VhqDWW4ZFaIhDHbFWAKIP5rOllUlvlWfrXw1/MqCZipDFa+tofAWifp0mkhrbOKMPQN1fmJikECvJr1zgSe5uvEkOA/AkJjxyOGNdD8BEGgWiJD+HkqE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764761069; c=relaxed/simple; bh=ji1dONw2LNM94TB9nwze5H8PR0IE5FBS+PMY0gqyW9U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=d78ly49lhL58BQoFvhOHblwj0qOkEC1aJkK4C/AlWxeSFVUSWkqcLG0vupENimIrnAevkAA8e6FCCW8v4mwA28DLwhZz/Cf44xKhuP1vR2ol/VXzQ4LYkuHnkDdF9xO6aAE6Ewk4k7VfLX4+tmzIkOkK7wn5AhXdDQGDXxH25Xc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=W7SWidSj; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=haH2kNAm; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="W7SWidSj"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="haH2kNAm" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B3AkUmV1427755 for ; Wed, 3 Dec 2025 11:24:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= A0p+brFxfrSugope+I1XqLDlsGS2ChZBIMwEp27fsuY=; b=W7SWidSjs7leqt1S TDxCwQAIPXBZMQFXNHsO4+58xThsybahbcQhBNHUNm19yZhpFIlUsaYifTUtmGM+ BvIjX68qYHOVQSbi22nMJVAr+IBB6KiukpZoOy+t0aiS26CnhM+M88DMDR2y2B+k YwJCbm8dbHsAZMCU7Wt/mV51bQftoQ2niQdaG9RbbMDC4eJSCD2cnbloSxyQHRrk JylMD7ED4CSWo34xb9aQ2+a8lamMVq/FKajMXDGm6AVyfqtL5mEEW6Y7h7pyGX92 bkZ4MviuiUKISMeOMnJiGVmwp8AlkYJokEPNCKOorgQCzwAM2gAIU3si1h0ibZUD yVPsmA== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ate0jsada-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 03 Dec 2025 11:24:26 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8b1be0fdfe1so200268985a.2 for ; Wed, 03 Dec 2025 03:24:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764761066; x=1765365866; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=A0p+brFxfrSugope+I1XqLDlsGS2ChZBIMwEp27fsuY=; b=haH2kNAm/0u11o85GDl4Fdhus5NyHBnzonK0K7Fbi5yPepto+b9pX+Avqgz2+FDpxA nSXlI5/XFIeRTzTeiY+FoRqcNcWytXt7789l9SF1xpRFqWlkYooK8biOBNw70VWw95A8 0dHfpDOQUw5QhHqo2mfwD7OIDA47M/LXRNSXcvvJmndT3hs3O7Bb4Lr9dVohTL+/jBwj l9v0T77k14vvAn2HcoWkx5i5TLUwMC8ucrQsqwsn3Z/NkblVn9JDjgQEBayvlU8hSzzs ftK60NbIs0iZ6sj6i3Psj4Pz9tpzTDQbQeKxv2eXWRe8SZpiXryCB6E0btF2ay1NDA0R 6hyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764761066; x=1765365866; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=A0p+brFxfrSugope+I1XqLDlsGS2ChZBIMwEp27fsuY=; b=sJTZqayv7ZTuaxUU14xD8U2gaYpdZreMozqu+cXTe/oTeZ+qWdYWDVkNbpD2pbIrAO Ijn65rnBoMbKiHgPirS7ugaHewHKi7t3yTVbS7CEu/mAJ6SI5z0hfUCrlu8WZUijWwmX WvaJzNq6Kc3n5WJg5HnH8p8eoVt7t9zhL3IERCXhJwMbO/2CkjgR+emZsnKFfPLzXMY5 mIDODdWB0wtu2QWKh2jG91w0fvODtK21S0sUPHYsHlSThUmoumF6+YjQ851FOtTpRgco VsbiYe0wFxRqUiGBjxNWKARBJPoXuGh+FIGK3rXSD9h/B2IuAT3cZNj86tXn80JJDGTa EWrg== X-Gm-Message-State: AOJu0YwrFoYO6eMSNnksG0dAbKfV3QcF/3LzVZ8ErPeV8y1iahAv0jWl 1bsniMumnofPO8ShKjlz0UvyXMVRgeZfC0C5O6dfw1NUnEMxQgxq51qJxiqUJ3VoIq5wFUP7INZ ugmN3FDTyjFOHsZCXZ7xjAuJdlYfXvG5193oUGO2IlwflkE7iEhEGDBBzYadh9wvmeUs= X-Gm-Gg: ASbGncvtxgeLkMhSJ8m/uMtTljAJyS87AfnCpB0eAHQoJbMB9lo/dnmcQ+fON/OC3IJ /uqW7Qx0bJ6gUN/yshOfWxqFCgahQMbvtyH4phnYs6QOlkYh0RxDmA3zGq7CSs84k18XoCnEv46 ziTyRZ2/F3PnUmIIFm4sbZmq3w2Ayepalhpwvr+uU+7KjCCdQp6+fNVSkKMmMsFR4ZM/BQ6KoMz PWIqKbWhE03f5pjnvZX1E0qiv/nxIGPGVfU7UWPoDfyiLJ0fdQChKmL/eNxaHFe96y92lig0S4z N5LVirPlcFxtkIEMtN7Q4xPTCLrtSFgBjQvW7k2I3DA8sIfax3bvvncbLCu4v7UVfZzbwAX+xQH gfqm2SPL3rZCmaV2f/O0GInTwjEBXlHjFq9NufsP0+EpyYkoXYn9emrrlkJVmqiEk/w== X-Received: by 2002:a05:620a:7008:b0:8b2:5af3:7fce with SMTP id af79cd13be357-8b5f952bbb5mr73148285a.7.1764761065975; Wed, 03 Dec 2025 03:24:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IEg8GJlxN8yk6BV/gW7Vu8pEykoa/iBTfz1ywQwTepsfqi1uelVNjpJfRSA+lYOTUVInXu6kw== X-Received: by 2002:a05:620a:7008:b0:8b2:5af3:7fce with SMTP id af79cd13be357-8b5f952bbb5mr73145985a.7.1764761065581; Wed, 03 Dec 2025 03:24:25 -0800 (PST) Received: from [192.168.119.72] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64750a6e873sm18901140a12.5.2025.12.03.03.24.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Dec 2025 03:24:25 -0800 (PST) Message-ID: <62911215-1211-4cd7-ac9f-232e3f585249@oss.qualcomm.com> Date: Wed, 3 Dec 2025 12:24:22 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] remoteproc: qcom_q6v5_wcss: fix parsing of qcom,halt-regs To: Alexandru Gagniuc , andersson@kernel.org, mathieu.poirier@linaro.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, p.zabel@pengutronix.de, Govind Singh , Gokul Sriram Palanisamy Cc: linux-kernel@vger.kernel.org References: <20251202162626.1135615-1-mr.nuke.me@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251202162626.1135615-1-mr.nuke.me@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjAzMDA5MCBTYWx0ZWRfX6Gpd6qRo3ksP S3/9UUCK7mFJqQUPmgkLPMegmtWLGh/1A8BLdcLi0JQfJnXqdEFCOMdtazYTvGkI/mWcufv28+q 9XWDeVjjOBn1kC1F+qsmJshBRnNjLDD/JS8RMMRVp0QnAY7sjgpGJFXvpFmLO6MMGlUZxyKI+k6 CEjxFpyS8S/vlZ8ChaKg2GE8c7OOogKK99wHcprlDlJjh9u68yzqMAceNXEApkBa4mtcyvHkUWw iEmCdBJv1T6dGYgm5fwp1N/dCtvLC2eDDn652fBmvY5MGRBrn4wZPayTVw9LPvbHf19iPLKMbrK 6YUsCq32uE0Eu6ctTWulICVzYJcbn+lcYskakMIRcw2uaWGBGwL2L5QNpKh1D7dwcSwYCnlMB0/ i8iP5UWIbijbbdIhnJZySdwtMFIwlQ== X-Proofpoint-GUID: tagVDKxpDQ8SwrcnjI3HiArxaGrlhiUv X-Authority-Analysis: v=2.4 cv=cOHtc1eN c=1 sm=1 tr=0 ts=69301dea cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=0I7aqVnf0aXTppol8EEA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-ORIG-GUID: tagVDKxpDQ8SwrcnjI3HiArxaGrlhiUv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-02_01,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 suspectscore=0 adultscore=0 phishscore=0 clxscore=1015 spamscore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512030090 On 12/2/25 5:26 PM, Alexandru Gagniuc wrote: > The "qcom,halt-regs" consists of a phandle reference followed by the > three offsets within syscon for halt registers. Thus, we need to > request 4 integers from of_property_read_variable_u32_array(), with > the halt_reg ofsets at indexes 1, 2, and 3. Offset 0 is the phandle. > > With MAX_HALT_REG at 3, of_property_read_variable_u32_array() returns > -EOVERFLOW, causing .probe() to fail. > > Increase MAX_HALT_REG to 4, and update the indexes accordingly. > > Fixes: 0af65b9b915e ("remoteproc: qcom: wcss: Add non pas wcss Q6 support for QCS404") > > Signed-off-by: Alexandru Gagniuc > --- Hm, that surely could have never worked Reviewed-by: Konrad Dybcio Konrad