From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933428AbbJHOih (ORCPT ); Thu, 8 Oct 2015 10:38:37 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:57617 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932145AbbJHOig convert rfc822-to-8bit (ORCPT ); Thu, 8 Oct 2015 10:38:36 -0400 From: Arnd Bergmann To: Krzysztof =?utf-8?B?SGHFgmFzYQ==?= Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Bjorn Helgaas Subject: Re: [PATCH v2] ARM: cns3xxx: pci: avoid potential stack overflow Date: Thu, 08 Oct 2015 16:38:31 +0200 Message-ID: <6292196.7OZzGKz28l@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <2273145.0Ls8cProhs@wuerfel> <12713701.B4epxIQJNF@wuerfel> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="utf-8" X-Provags-ID: V03:K0:8rH+zWB5Kih4owwrqw6roovDeUikQsdseoEt6qfxIlcLUWNck7v DHhoqqM7Xna5kkZQp4AeCD3FvPrkOXv9eJt2wEDfqjyJ3QkoBUml8bFp5UyjLo5gafyYsRy CKmAH//61xw+lRpOmPO9rWkQZ/u7xBDfxgRgjVvd6CL3Gjg4Cllka7Ejpm8zpH38PNpSarX tBmVidpR+lUjO5UO5ZPGw== X-UI-Out-Filterresults: notjunk:1;V01:K0:hfxCozTuNyw=:5IwLCPMhpxxANPH9QLbXSz TRrTX5IIuG07OriweOcGuMJe3U96Q4TKnJnEPkSTJVJYNIg9VKZNQ8yyV6NGKDYEKoKiL3EyH msXwsh78aT2ksLFPD5MIhHKKGyQ+XKqShoZovWC1dEkjjmNiuAlL16MPobqK6gqv/UNC4E3oY dGBJ3kPXBu2tTorh9+np0JH4ZPVR6jQaJqHcEHSCITo1JJdAstPEH7za9FgMAXmjqL8C7I1PK VgB2ABYDfSS1Zt75AkTwx8zNG/EbeGGm3VgdxtD2HZ7QNHEyLihcPLlrf8v6K1vaO2iCU2PWf qfrdhUpzn/80pHc75gWrLKmoCla5WzBTdj/IR8Arxir3LeNnRp85yjMbZ7oI5h3aa8l1CPQxh kCJxySqTmkliYDaCvc3mK6JrbBG0uBhNH17+J1pMbWCwhxaGZ30LWUCl5BLFnIRpe/XAcGdpv rOmnJm/XPh2f+6bkPwP6VVVdQNHbFFpk+MYQC2PqPn84WEFvWYVoOqOXnR0eTTFtjr3tTGDx5 63aDNAKayUmYNEMXheP1/TfN1rq1w2BrhVDvdcmO5ohYgY2AXJ3vKmXYkvl3FayEIdQQyijt+ WiS2+WgTza5B0AGj5exLNsGCCseAqeuUeef2m4lx0hIWdK5aoMWLx/7i7ADfIaG+FBuDlWMIT +e5kGx+KZyYm90U2+oNZOXuP+gccPBqZa0zqiYjYDWznIVfuP4u8Gzcgs9RnysjXGaTo8Tlgj pr6nZw/Zw6TDqY4U Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 08 October 2015 12:03:18 Krzysztof Hałasa wrote: > Hi, > > Arnd Bergmann writes: > > > With those two changes in place, we no longer need the fake > > pci_sys_data/pci_bus structures for faking config space writes, > > and the stack usage goes down as well. > > > arch/arm/mach-cns3xxx/pcie.c | 71 +++++++++++++++++++++++++++++---------------------------------------- > > I'm ATM unable to test this change, but will do that at some point. > Meanwhile, I guess there is nothing I can say against this patch. > Thanks. > > Acked-by: Krzysztof Hałasa > Thanks! I've queued it up in next/fixes-non-critical for linux-4.4 now, if you find something wrong later, we can revert or fix up. There is no urgency for this one, especially since you still want to test it, so no reason to put it in 4.3. This was the last pre-2015 build warning for the ARM defconfigs and allmodconfig, all remaining warnings are regressions or new code, and I've submitted patches for those. Let's see if we can get to a warning-free kernel build in 4.4. Arnd