From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout-u-204.mailbox.org (mout-u-204.mailbox.org [80.241.59.204]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60A9CDDC5; Thu, 11 Apr 2024 15:01:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=80.241.59.204 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712847669; cv=none; b=ClKelO+Zpzvulj+7C4v6ZY10YWMlwiNGEFwEk353aTuT144WKDbkAUtqLVsRXGLePOFCvaCnxPups/01djiVr/eEK/6p1D9qloxQhnlOS3PzTcqO4cA8b213tsGc5uZaMRXA5m/3L4dc1yLaNFYyzZsC10BZllWzWT5hmjCv/jA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712847669; c=relaxed/simple; bh=tmaDp/QcCqlmZkdQph/55Yo3msDZ1EbEfOjyva7sbr8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GQ6H7js6wqjkcktavgD4oFW4WMI2Dkk6GW6DXNzRpwxKFFDvk+njdpT4KvMSfMQE1vub4/eqs0aeBxUFZDdl9gNp43K6Tye97cPr8mfG+wJ+1iZf3sjS3vB+8XDA091dz8yxsDjD/SFFPwWW/k5azOId1dyMonXNFPtPJTyak6E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=permerror (bad message/signature format); arc=none smtp.client-ip=80.241.59.204 Authentication-Results:smtp.subspace.kernel.org; dkim=permerror (bad message/signature format) Received: from smtp2.mailbox.org (smtp2.mailbox.org [10.196.197.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-204.mailbox.org (Postfix) with ESMTPS id 4VFjMk09PRz9t9r; Thu, 11 Apr 2024 16:52:02 +0200 (CEST) From: Marcello Sylvester Bauer To: Greg Kroah-Hartman Cc: Marcello Sylvester Bauer , Marcello Sylvester Bauer , =?UTF-8?q?Matthias=20St=C3=B6ckl?= , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 2/2] usb: gadget: dummy_hcd: Set transfer interval to 1 microframe Date: Thu, 11 Apr 2024 16:51:29 +0200 Message-ID: <6295dbb84ca76884551df9eb157cce569377a22c.1712843963.git.sylv@sylv.io> In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Marcello Sylvester Bauer Currently, the transfer polling interval is set to 1ms, which is the frame rate of full-speed and low-speed USB. The USB 2.0 specification introduces microframes (125 microseconds) to improve the timing precision of data transfers. Reducing the transfer interval to 1 microframe increases data throughput for high-speed and super-speed USB communication Signed-off-by: Marcello Sylvester Bauer Signed-off-by: Marcello Sylvester Bauer --- drivers/usb/gadget/udc/dummy_hcd.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/dummy_hcd.c index dab559d8ee8c..f37b0d8386c1 100644 --- a/drivers/usb/gadget/udc/dummy_hcd.c +++ b/drivers/usb/gadget/udc/dummy_hcd.c @@ -50,6 +50,8 @@ #define POWER_BUDGET 500 /* in mA; use 8 for low-power port testing */ #define POWER_BUDGET_3 900 /* in mA */ +#define DUMMY_TIMER_INT_NSECS 125000 /* 1 microframe */ + static const char driver_name[] = "dummy_hcd"; static const char driver_desc[] = "USB Host+Gadget Emulator"; @@ -1302,7 +1304,7 @@ static int dummy_urb_enqueue( /* kick the scheduler, it'll do the rest */ if (!hrtimer_active(&dum_hcd->timer)) - hrtimer_start(&dum_hcd->timer, ms_to_ktime(1), HRTIMER_MODE_REL); + hrtimer_start(&dum_hcd->timer, ns_to_ktime(DUMMY_TIMER_INT_NSECS), HRTIMER_MODE_REL); done: spin_unlock_irqrestore(&dum_hcd->dum->lock, flags); @@ -1993,7 +1995,7 @@ static enum hrtimer_restart dummy_timer(struct hrtimer *t) dum_hcd->udev = NULL; } else if (dum_hcd->rh_state == DUMMY_RH_RUNNING) { /* want a 1 msec delay here */ - hrtimer_start(&dum_hcd->timer, ms_to_ktime(1), HRTIMER_MODE_REL); + hrtimer_start(&dum_hcd->timer, ns_to_ktime(DUMMY_TIMER_INT_NSECS), HRTIMER_MODE_REL); } spin_unlock_irqrestore(&dum->lock, flags); -- 2.44.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout-p-201.mailbox.org (mout-p-201.mailbox.org [80.241.56.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DBA517C7C; Thu, 11 Apr 2024 15:22:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=80.241.56.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712848977; cv=none; b=OqabqelkyRmbTDn8woKAXKcbAhHotmbrj5Hx8J0sV6yUjjgXi1nt/1iRbvOwGxlxVCNZgS9hl0KsiVsdsEQ/FEpb9vlOsPOtKNYu51KFd2qo8xFG+b3TzTbkUc/ys+zxYJK5xgN3PyQodaDzbugQEkOBZv9kuM0dC8AWByXI+zc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712848977; c=relaxed/simple; bh=GA/EpIVJhg4UwhBlutCAi1ERwtVhQc+L+Av7WARSGa0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AnNxtyc3YRkFseu4apQR1BHipyWaN278xu9RoGf/EdUKI/4O96BnSxuwZG3j3ojFWabs1wdy1v9Fv30eg/pYAkY7QzZ3saadJuJiRAUr9OdwIlPXZ20Hk/eK8Usi+jNC9IA7aYX533x3zepx5ELGVw/8FI/7puNrpTBpVoIqazY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sylv.io; spf=pass smtp.mailfrom=sylv.io; dkim=pass (2048-bit key) header.d=sylv.io header.i=@sylv.io header.b=069+bgEC; arc=none smtp.client-ip=80.241.56.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sylv.io Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sylv.io Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sylv.io header.i=@sylv.io header.b="069+bgEC" Received: from smtp1.mailbox.org (smtp1.mailbox.org [10.196.197.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4VFk3H6nCdz9stD; Thu, 11 Apr 2024 17:22:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sylv.io; s=MBO0001; t=1712848971; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=amXjS7ISzkPiYpAuOxGm5Oj5qH9FcCS+4Rp1Y2la0yk=; b=069+bgECrr4UjYsUMHQiI8kUAVroyfAL+yfoUqXFrBqbuZV1OgC8l8yeg3qYoZtHLOTFye dqL0UE6OPcMFo1Phg81iyg9WpYw/tGKZ7MfIEiVxmfx9A7isZ1JJdvKrJ84E5eXZqG6Qnk jXi3TOF1maw0rrX8Jip3+Gh/p3P/HAb9rXOncE8XT0Hz5mJHZga7HQq4NNwGOlr31x7df4 jZ/xI+OXFSKhnd0HO3GIVklL1rC6xFs4vXcX6YXCdiJN8neQrEi1YYoaMDDmRMIMofVdKA 5Tn9MuDR0sDYq2IBvwCF5R4p0oPF9Z4ax5MFS+ePEbpjG1BduASkPodKA7ESzg== From: Marcello Sylvester Bauer To: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Greg Kroah-Hartman Cc: Marcello Sylvester Bauer , Matthias Stoeckl , Uwe Kleine-Koenig , Marcello Sylvester Bauer Subject: [PATCH v1 2/2] usb: gadget: dummy_hcd: Set transfer interval to 1 microframe Date: Thu, 11 Apr 2024 17:22:11 +0200 Message-ID: <6295dbb84ca76884551df9eb157cce569377a22c.1712843963.git.sylv@sylv.io> In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID: <20240411152211.C8KHfOJWcYuJ0dtZcBpLSsQ8_xFqsio0LdmKS-mgEV4@z> Currently, the transfer polling interval is set to 1ms, which is the frame rate of full-speed and low-speed USB. The USB 2.0 specification introduces microframes (125 microseconds) to improve the timing precision of data transfers. Reducing the transfer interval to 1 microframe increases data throughput for high-speed and super-speed USB communication Signed-off-by: Marcello Sylvester Bauer Signed-off-by: Marcello Sylvester Bauer --- drivers/usb/gadget/udc/dummy_hcd.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/dummy_hcd.c index dab559d8ee8c..f37b0d8386c1 100644 --- a/drivers/usb/gadget/udc/dummy_hcd.c +++ b/drivers/usb/gadget/udc/dummy_hcd.c @@ -50,6 +50,8 @@ #define POWER_BUDGET 500 /* in mA; use 8 for low-power port testing */ #define POWER_BUDGET_3 900 /* in mA */ +#define DUMMY_TIMER_INT_NSECS 125000 /* 1 microframe */ + static const char driver_name[] = "dummy_hcd"; static const char driver_desc[] = "USB Host+Gadget Emulator"; @@ -1302,7 +1304,7 @@ static int dummy_urb_enqueue( /* kick the scheduler, it'll do the rest */ if (!hrtimer_active(&dum_hcd->timer)) - hrtimer_start(&dum_hcd->timer, ms_to_ktime(1), HRTIMER_MODE_REL); + hrtimer_start(&dum_hcd->timer, ns_to_ktime(DUMMY_TIMER_INT_NSECS), HRTIMER_MODE_REL); done: spin_unlock_irqrestore(&dum_hcd->dum->lock, flags); @@ -1993,7 +1995,7 @@ static enum hrtimer_restart dummy_timer(struct hrtimer *t) dum_hcd->udev = NULL; } else if (dum_hcd->rh_state == DUMMY_RH_RUNNING) { /* want a 1 msec delay here */ - hrtimer_start(&dum_hcd->timer, ms_to_ktime(1), HRTIMER_MODE_REL); + hrtimer_start(&dum_hcd->timer, ns_to_ktime(DUMMY_TIMER_INT_NSECS), HRTIMER_MODE_REL); } spin_unlock_irqrestore(&dum->lock, flags); -- 2.44.0