From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754575AbcBZPCG (ORCPT ); Fri, 26 Feb 2016 10:02:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54613 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753895AbcBZPCD (ORCPT ); Fri, 26 Feb 2016 10:02:03 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20160224171258.29272.1684.stgit@tstruk-mobl1> References: <20160224171258.29272.1684.stgit@tstruk-mobl1> <20160224171237.29272.51126.stgit@tstruk-mobl1> To: Tadeusz Struk Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, balrogg@googlemail.com, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, zohar@linux.vnet.ibm.com Subject: Re: [PATCH 2/2] crypto: remove padding logic from rsa.c MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <6298.1456498920.1@warthog.procyon.org.uk> Date: Fri, 26 Feb 2016 15:02:00 +0000 Message-ID: <6299.1456498920@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tadeusz Struk wrote: > + if (memcmp(sig->digest, output, sig->digest_size) || > + req->dst_len != sig->digest_size) You must always do the size check first! David