From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com [209.85.167.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D634337BAC for ; Sat, 31 Jan 2026 21:31:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769895098; cv=none; b=bnUVsKObD3gL4RDOIV7rHmbyc3vcmlVWw7lJjyFLiIxuEd7MsLcVeCM4kopT/TAxQqBUMN/1UuL8Dyl4lQ4LuYNzeMts4uQOYQoZ4DdLDvBy5yd80r00ttffCc8BlL+pD6e0BNFgBHp/Ox/E5o0sAGvhdbE8Mklh0fPqy3R5ZSg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769895098; c=relaxed/simple; bh=ERnv3otAcYg//bBxuwJmzFwm1JYlCphbavP5uFY2jcg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XlU95CTOCVwAJnsz8qQ1BGt7IJxDmVGFNBxENZcbk3V9jbMgAyL8hRbC4hWoBUd0Ela0DtKV5FlGGMSuug3JPZSfP94wDwDL59kilwUQ+yyrhlIMzTnfvE0AGSrM5IgIOp+bpwdxy/C8rJ0rsG8jdLKiAfzmVyQayGtQEDW7p0s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=wnDeEaXV; arc=none smtp.client-ip=209.85.167.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="wnDeEaXV" Received: by mail-oi1-f178.google.com with SMTP id 5614622812f47-45effa36208so2306484b6e.1 for ; Sat, 31 Jan 2026 13:31:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1769895094; x=1770499894; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oN7nfsMLYgFLh50J5K6u/iWba/AywR5N7bpGoZqwJBw=; b=wnDeEaXVLQN+ycjBxkW6hwwuh7FHoCypHz1GXYVtdx/OFAFeGZs8pojxxU+Lo/48iY NR2ZVQbVSF6J6z8Ulw+JDhIo0VjXGAUIlPp1NfxHp15MQq46yalPPAQAE7wlaJctJd7i 21OqRyiGnlSMIR9ISZpIRY5IYXglot7P0D8Tup2qSA2fBZpWhvBOhHQj6GmpwikF1k15 DOwjw/TP/o5aPkcgD/vNmwRAIruyskVoqiIgAgUtzCPZPDMn6XgztlQkKfgUerjKbEPh 15tEPBT4+0G3v7w0wNT2nT9P0QpQI+iMWAzPD2TTFPbjaSLyrd8251U6kr4LZNJVEdp4 vYFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769895094; x=1770499894; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oN7nfsMLYgFLh50J5K6u/iWba/AywR5N7bpGoZqwJBw=; b=toMwK67QWTQu7vXSQqFRyR252ZwswhLTYNT/tAQG1t146jccrJ1LaoMO0mopN3Ffk2 ek+a6s4QeBmusVXkzOL6a0u7nDLRBR9xNCVyWuj7WlPji6L9q+j11C3mydX0ZREXZJ7j r08tdlyDFiMuOx39dnsFxwiR8mp31gfjqnIki5thVdrw4HtMmPDhNIQmOvPu4K2Ptfn6 4r7RnymmznbD1IvG3UIZVuTs8C0bhYq07ThowQ2Llz3dM4pSEDg/H6LS/rghwcUPMYcj lTolUiA4T+oycvFrDpZ/g3obm4f6ROqGpBv58QlCqawf87wS7W9raKFNQqn//dQ53lpv rk6A== X-Forwarded-Encrypted: i=1; AJvYcCWu7qHLfs6OmwpgC2vWKY6aeXMyy5OdKklhNZIdOEbGVIH4/q8BWI3dleJYUR+A2YL5j5+pIGgt2Ycc7Dg=@vger.kernel.org X-Gm-Message-State: AOJu0YwYCYPDhZQlIg1x7DNTuLzHZ94QbVnBMMLIF3X+NiUF/qjzMM2c Am2zM1wYuE7NpbQfOCKPJBCoYEwPvzmW1wZVi19OIZJLar+VfenDcdOK2wLXXZMkcls= X-Gm-Gg: AZuq6aJP7bofWxsuEe9Rd2Fgl876Lydvws6Hp3/Sg5JxfwiFRlSUd6/oTMwsvA8aG2A JaMGQfe4os9/vBQmMmRGv5m+p/1xs6dC7k0L1Mscw9UkEiBASFwig44CxpACVXawXr4o5nHahQN ggAnznBPn/bTSkgn2VshX/aFZILWH7K0SMB+9kc5shQ7f2KPL9q0VPWs75ouQzWaIcvWzNPuq0F /RGZD7HAOdUWK2eEoEnxLW9Y127AhXUzWc3T9OZikGyrfq6gmLfkJoZoMXTLvFV5S++GNXBcCTU tnchBwGkIIwKNbVmEFYx2iQGvfzy5wl+Y4hfKKsqm++2ThbmGOmt7Vyid2IVwv2CSjo5DJ8VYvx xKiFkrnVQ8V+MmHwKassc9xaUzw7Ru8zPpsacB9iUeZiDBXqWvGQeohLXaWk/C+pIjDIUaTKtIN q+6d/cTncbifi404tfZSVaLrExx6nzl1lg7rXXquy3gel3rJZtDc3dOm/7wyGU X-Received: by 2002:a05:6808:1a19:b0:45e:e52c:8a9b with SMTP id 5614622812f47-45f34d98b5amr3091519b6e.59.1769895093915; Sat, 31 Jan 2026 13:31:33 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:c7ef:51f2:4f7a:6cd7? ([2600:8803:e7e4:500:c7ef:51f2:4f7a:6cd7]) by smtp.gmail.com with ESMTPSA id 5614622812f47-45f08d894f5sm7181770b6e.5.2026.01.31.13.31.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 31 Jan 2026 13:31:33 -0800 (PST) Message-ID: <629d8505-c4ba-4089-8dec-d627e3acd337@baylibre.com> Date: Sat, 31 Jan 2026 15:31:32 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 6/8] iio: dac: ds4424: add DS4402/DS4404 device IDs To: Oleksij Rempel , Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: David Jander , kernel@pengutronix.de, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, Andy Shevchenko , =?UTF-8?Q?Nuno_S=C3=A1?= References: <20260128153824.3679187-1-o.rempel@pengutronix.de> <20260128153824.3679187-7-o.rempel@pengutronix.de> Content-Language: en-US From: David Lechner In-Reply-To: <20260128153824.3679187-7-o.rempel@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/28/26 9:38 AM, Oleksij Rempel wrote: > From: David Jander > > Add I2C/OF IDs for DS4402 and DS4404 and set the correct channel count. > Follow-up changes add per-variant scaling based on external Rfs. > > Co-developed-by: Oleksij Rempel > Signed-off-by: Oleksij Rempel > Signed-off-by: David Jander > --- > changes v3: > - Reset author to David Jander and added Co-developed-by tag for > Oleksij Rempel to clarify roles > changes v2: > - No changes. > --- > drivers/iio/dac/ds4424.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/iio/dac/ds4424.c b/drivers/iio/dac/ds4424.c > index c03051dc763e..f340d491fcc1 100644 > --- a/drivers/iio/dac/ds4424.c > +++ b/drivers/iio/dac/ds4424.c > @@ -35,6 +35,8 @@ > } > > enum ds4424_device_ids { > + ID_DS4402, > + ID_DS4404, > ID_DS4422, > ID_DS4424, > }; I suppose it was already suggested in previous reviews that we should be dropping these IDs and using device info instead of expanding the switch statement below. > @@ -237,6 +239,12 @@ static int ds4424_probe(struct i2c_client *client) > goto fail; > > switch (id->driver_data) { > + case ID_DS4402: > + indio_dev->num_channels = DS4422_MAX_DAC_CHANNELS; > + break; > + case ID_DS4404: > + indio_dev->num_channels = DS4424_MAX_DAC_CHANNELS; > + break; > case ID_DS4422: > indio_dev->num_channels = DS4422_MAX_DAC_CHANNELS; > break; > @@ -278,6 +286,8 @@ static void ds4424_remove(struct i2c_client *client) > } > > static const struct i2c_device_id ds4424_id[] = { > + { "ds4402", ID_DS4402 }, > + { "ds4404", ID_DS4404 }, > { "ds4422", ID_DS4422 }, > { "ds4424", ID_DS4424 }, > { } > @@ -286,6 +296,8 @@ static const struct i2c_device_id ds4424_id[] = { > MODULE_DEVICE_TABLE(i2c, ds4424_id); > > static const struct of_device_id ds4424_of_match[] = { > + { .compatible = "maxim,ds4402" }, > + { .compatible = "maxim,ds4404" }, > { .compatible = "maxim,ds4422" }, > { .compatible = "maxim,ds4424" }, > { }