From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 197A83203B6 for ; Thu, 15 Jan 2026 20:24:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768508673; cv=none; b=UkVU4HmkFZTXlBHRt0dVd0Jf3EavfqwmICscnOKwlhhkx6N9QCKU3/YsSTzfVHoK1EOOW9WFX3GpVTbrscNUwTFAoXPVaS2+nHhdvVwKDx2cvO18tSIidotg5HVc25aJVhuJiLZm3BqCe8rhFeX9+KtSMj9GNgJSZLhoAWMUIFE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768508673; c=relaxed/simple; bh=80NwDimbFFYQkOFNNfJ6/FQGmBFIXJdw+XSEIFYWsYs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BK0iBouyDPz/FKnfW/2jYhpxhBHP9VRpHs1/k0PFBwLaQJGgf0FJwo+9QuQZ0ZMK8425mqy/siV1LA7wdvlEGZPU7tcf60oShVF1097kwuNS+wMXxRYyqx88eBNCZSmwshbeel9POItWbD84WHLZOzfAUB9zJbrJvl1lIMEx9tc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GSH/yxzU; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VbFEY3t8; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GSH/yxzU"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VbFEY3t8" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60FFYfHB2981610 for ; Thu, 15 Jan 2026 20:24:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 3gKJRgKC6AD8prIn+wfw8vk84T968p8SO329dfTkrQU=; b=GSH/yxzUuSAlfv7w XlNRF/ZTUud0Ic/j0QMjTeXO/4FatoX18CeV6ekzMoNgbgT3B4wOMusycPJjf8wN q1HYZMwcP/tSm0csb2tn6liwlVjZ99eXtH4alkfQkScVgRinHiQCVRkvZ5QA/U5Q iv7Ztq16v2IS+VtulJq3vwwSAgLZJx6PgjV6LWW4FxUUvtPUwAcLUm9KZ+HNybrW TlDGvDcg7c0UfWmA6ZvK8p+NUlMlhIe7cWooDRyIF7wOjyaE5yw+FKCTHEnGldp9 SIOXE5AIyvnA4lEHS916Qa+rn1Fd1jtgszjzIIOTGPcWKnALM7HD70VwiBmDzXQx oZ4tlA== Received: from mail-dl1-f71.google.com (mail-dl1-f71.google.com [74.125.82.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bprej2vn3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 15 Jan 2026 20:24:30 +0000 (GMT) Received: by mail-dl1-f71.google.com with SMTP id a92af1059eb24-11b21dfe918so749315c88.0 for ; Thu, 15 Jan 2026 12:24:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768508670; x=1769113470; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3gKJRgKC6AD8prIn+wfw8vk84T968p8SO329dfTkrQU=; b=VbFEY3t88lwQGsbbQrJbCr2B0lnSgFBgZtpLyO7NothG9rP6EUOu/Qd4JVe8Tq6a3w rTCMglk9LTV1yfxqQrq7Xk/fJcpFph0AcBKw4AVLku4la/zqlGYPBX4hpGKC1ybPbmLy BWsl/F3jvcxGZ13u9spCFas6UBr4Ic/nFD1tk3gdmULyP1vvTnEbR3RphjYmNjtfUB92 b5zo1n/aM/IwMayZCADnEw8Ga8afmNF/zrajvszrw9ufYAdC7l+Bk7rK7t7QeppxB0WR wLQTFeC2Ikqw8/49/2jtBk9QiBzpUPTXgqPW1jzdZAbH8uWpgyu3b5i/VUaaf0IAeTUx 9wlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768508670; x=1769113470; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3gKJRgKC6AD8prIn+wfw8vk84T968p8SO329dfTkrQU=; b=Sg+l3Ygxj/1UxK7FpzXXPm1zKWAc/hYk8BYlx579X5vGSgMl4SIAxe16A5Z3pG2g10 mBtH9zAyp5qLNkac/3yXSz3uWetw+HzbQ6aX9xE75duF9FUtMPEP4jpyXXSXMokAcDGS AuDHUdRiAHgeYHrop9xuVindmfsu8yTRAhgrMl/INZkrjkhj11U/kKYTWAXfp41OFma5 nDv3EfPSKQaou97Xeuqc4Jr0C7cwssMBTqHf786ZlEaWVnmVu5FmMDYRCqfPewRF+Wrs /zJ9Pcjp1YUNcEz15zytG1tm+rCQEY41+0oviQOom7aFy8X15eawINMLloFc6d18n4ic OLPA== X-Forwarded-Encrypted: i=1; AJvYcCWjJCa3br1vqONVDyDrKDsrcKsuQClNQo97/oSA8rw407/mJQO6vRNN7iAEyBAXFteWDMoQ05gs20m6E6A=@vger.kernel.org X-Gm-Message-State: AOJu0Yy7Mq7zhLbeco+jDOxSTMybpLtnLQL4Mya7VNSoHHzzV09l963O hxZnPMJ4t/uNR36rAUVOb7TUR/Uqn8B42IClwBFq9bSmBOwAVTfJkzUiqkR8MgPkrbhwyocBCX3 fBaVrQtIQRLOKXnJzJi5EGNIptgHink+u9zTSZGupeaclNHBYcC9jzgCchar47vOzf6E= X-Gm-Gg: AY/fxX77K2W/FatqOdfXEdH6QiVGAQ/cLgR13u13CrZtw+8aDj3RkdoG+mxUG8gnxOW HBHU4pbrJrlchd9z8BOiQyuHOq9hgR4hapjmDWg0DllgIp4inJVzl+dCRRm+rTSEB3IP43dxpA0 KNXpezcWBBBJ0/ZZ1+PCqPo5dkQJl2LLJX4RxEvy+fZi5OK2WLDgBcVQngX0deTv2Pzce9E0vy6 JtY6jF0Ni/GWKh4f+rFlo7g0XEA+KYUUBgJXSioXi2tVSwNal7+Ty45KaAqfWopPt9BV15Vk8YL uVIg2REVob5gGgLLt9r6xSVmElgknD9AWHsdUTYzm3vlEeN9NrZpj54En2YS4j5vhxUqrKucK9I gPIQAEr5BrXZcB4RGty+X+ZXAhD1ic05bwsKsFYxpIWkf69ZnvWOgtTHGRTRE X-Received: by 2002:a05:7022:2486:b0:119:e569:f865 with SMTP id a92af1059eb24-1244a923b8fmr748794c88.2.1768508669526; Thu, 15 Jan 2026 12:24:29 -0800 (PST) X-Received: by 2002:a05:7022:2486:b0:119:e569:f865 with SMTP id a92af1059eb24-1244a923b8fmr748767c88.2.1768508668948; Thu, 15 Jan 2026 12:24:28 -0800 (PST) Received: from [10.73.212.179] (pat_11.qualcomm.com. [192.35.156.11]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1244aefab3fsm414971c88.12.2026.01.15.12.24.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Jan 2026 12:24:28 -0800 (PST) Message-ID: <62a0b363-653e-4bcd-9f17-840d5f276390@oss.qualcomm.com> Date: Thu, 15 Jan 2026 12:24:27 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] firmware: smccc: default ARM_SMCCC_SOC_ID to disabled To: Neil Armstrong , Mark Rutland , Lorenzo Pieralisi , Sudeep Holla Cc: linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, trilok.soni@oss.qualcomm.com References: <20260112-disable_smccc_soc_id-v1-1-a5bee24befb4@oss.qualcomm.com> Content-Language: en-US From: Satya Durga Srinivasu Prabhala In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE1MDE1OSBTYWx0ZWRfX9ZWwo/OShBsZ nxXvWcH//256rq+VY3oPLYqrX3T9msDriuVyIUonaeqQNB5pnyxiJjOYxB+K7CxEs92Zo0uWabb viCnmpYm/vu7OjtnjrVemQ4rmyg7S7KVtMVHjYa9MPcwP9a/k5UNF2z2Hbi9uqlfOWtlY0arj3q wBqVrUlSlnX264YgY/pw63s9URLrGx8SWUvAT8m1QFieDc9nGYtzkagZ/YcoI6qtWVBGNS8MmUS Dwn4njTYezhSPp70apSP89VomVjXJWo3pP89LkgPvKP9b4s57sHAmXcN8uYIypwJzhwqIjL/1dB 2BxJvgVkdH9T+KZYPmz+cUp/Z1vh0+n+H9p01o4IDas9NnirbkH5TiO7HdfomKXB6BSWKCsakMZ 6BRsvGs4LheVeWsdSfPhA1OL8pYa2nZdIKgkGl4+AASYBN/DJJjQgblAHDnphweul2KFe6rRHLC 0jRfW0ccBGcf0mkpHnA== X-Proofpoint-ORIG-GUID: cl353zRJj5Pu7AuPig9geAPWMiQUF5Y6 X-Authority-Analysis: v=2.4 cv=Rc+dyltv c=1 sm=1 tr=0 ts=69694cfe cx=c_pps a=JYo30EpNSr/tUYqK9jHPoA==:117 a=ZdW6uxA9NKXbfdqeeS2OGA==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=KxcOn-WUK91iGqjPL20A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=Fk4IpSoW4aLDllm1B1p-:22 X-Proofpoint-GUID: cl353zRJj5Pu7AuPig9geAPWMiQUF5Y6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-15_06,2026-01-15_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 spamscore=0 suspectscore=0 priorityscore=1501 clxscore=1015 bulkscore=0 malwarescore=0 phishscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601150159 Hello Neil, On 1/14/2026 9:12 AM, Neil Armstrong wrote: > On 1/13/26 07:24, Satya Durga Srinivasu Prabhala wrote: >> The ARM SMCCC SoC ID driver is currently enabled by default and >> publishes >> SMCCC-provided SoC identification into /sys/bus/soc/devices/socX/*. >> >> On platforms where a vendor SoC driver already exposes widely-consumed >> attributes (e.g. Qualcomm socinfo [1]), enabling the SMCCC driver >> changes >> the format of /sys/devices/soc0/soc_id (e.g. "jep106:XXYY:ZZZZ" instead >> of a vendor logical ID like "519") and breaks existing userspace >> consumers. >> >> Flip the default of CONFIG_ARM_SMCCC_SOC_ID from y to n. Platforms that >> prefer SMCCC over a vendor driver can explicitly enable it. >> >> This avoids unexpected format changes and keeps the generic SoC sysfs >> stable on systems that rely on vendor-specific identification. >> >> [1] >> Link: >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/soc/qcom/socinfo.c >> >> Signed-off-by: Satya Durga Srinivasu Prabhala >> >> --- >>   drivers/firmware/smccc/Kconfig | 5 ++++- >>   1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/firmware/smccc/Kconfig >> b/drivers/firmware/smccc/Kconfig >> index 15e7466179a6..f830d11ebdca 100644 >> --- a/drivers/firmware/smccc/Kconfig >> +++ b/drivers/firmware/smccc/Kconfig >> @@ -18,8 +18,11 @@ config HAVE_ARM_SMCCC_DISCOVERY >>   config ARM_SMCCC_SOC_ID >>       bool "SoC bus device for the ARM SMCCC SOC_ID" >>       depends on HAVE_ARM_SMCCC_DISCOVERY >> -    default y >> +    default n >>       select SOC_BUS >>       help >>         Include support for the SoC bus on the ARM SMCCC firmware based >>         platforms providing some sysfs information about the SoC >> variant. >> +      Note: Several vendor platforms provide their own SoC information >> +      drivers under drivers/soc/*. To avoid conflicting sysfs attribute >> +      formats in /sys/devices/socX/*, this driver defaults to disabled. >> >> --- >> base-commit: b71e635feefc852405b14620a7fc58c4c80c0f73 >> change-id: 20260112-disable_smccc_soc_id-ed09ef4d777f >> >> Best regards, > > Disabling it by default impacts other platforms, the arm64 kernel is > designed > to be generic and run on any platform with defconfig and from the same > build, > please don't forget that. Thanks. > If you want to ship an arm64 kernel tailored for Qualcomm platforms, > you're > allowed, and you're also allowed to disable ARM_SMCCC_SOC_ID. Not entirely true. Say in case of Android / GKI, ARM_SMCCC_SOC_ID gets enabled by default and we do not have a way to disable it. > The soc sysfs interface is designed to support multiple source of > information, > from vendor (like qcom socinfo) and smccc ID. And this is well > documented, > and pretty obvious... Yes, it is indeed obvious. The point to note is vendor interface existed from long time and unfortunately user space had made certain assumptions. All, we need is a way for vendor to choose which interface to be provided to user space to make sure user space isn't broken. > Neil