From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755689AbdESNcU (ORCPT ); Fri, 19 May 2017 09:32:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48664 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755636AbdESNcS (ORCPT ); Fri, 19 May 2017 09:32:18 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 73A3580042 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=david@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 73A3580042 Subject: Re: [PATCH 4/4] KVM: x86: prevent uninitialized variable warning in check_svme() To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: Paolo Bonzini , Dan Carpenter References: <20170518173732.12185-1-rkrcmar@redhat.com> <20170518173732.12185-5-rkrcmar@redhat.com> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <62a6b071-f57f-bfe9-7b0e-84ab196800bb@redhat.com> Date: Fri, 19 May 2017 15:32:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <20170518173732.12185-5-rkrcmar@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Fri, 19 May 2017 13:32:13 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18.05.2017 19:37, Radim Krčmář wrote: > get_msr() of MSR_EFER is currently always going to succeed, but static > checker doesn't see that far. > > Don't complicate stuff and just use 0 for the fallback -- it means that > the feature is not present. > > Reported-by: Dan Carpenter > Signed-off-by: Radim Krčmář > --- > arch/x86/kvm/emulate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c > index c25cfaf584e7..0816ab2e8adc 100644 > --- a/arch/x86/kvm/emulate.c > +++ b/arch/x86/kvm/emulate.c > @@ -4173,7 +4173,7 @@ static int check_dr_write(struct x86_emulate_ctxt *ctxt) > > static int check_svme(struct x86_emulate_ctxt *ctxt) > { > - u64 efer; > + u64 efer = 0; > > ctxt->ops->get_msr(ctxt, MSR_EFER, &efer); > > Reviewed-by: David Hildenbrand -- Thanks, David