From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1D4CC83F33 for ; Thu, 31 Aug 2023 08:58:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238209AbjHaI6l (ORCPT ); Thu, 31 Aug 2023 04:58:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229715AbjHaI6k (ORCPT ); Thu, 31 Aug 2023 04:58:40 -0400 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D1E8CE6; Thu, 31 Aug 2023 01:58:38 -0700 (PDT) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 445505C00EF; Thu, 31 Aug 2023 04:58:37 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 31 Aug 2023 04:58:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flygoat.com; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1693472317; x=1693558717; bh=GO+RB/XjbQvZQe1MEUlBwDOw8njnoFbRMlk s6o1U5dw=; b=n2qaDeb/UbimrdbrMvWZDVeSrHCybiKua/Ds0tnvtcnDD+fAU/H MLidxqDFUemvZt4Nef/MLcJbsRAXEk7gKZfq8R+XW1DGiVlp8A9M1UDv1igiNpzD mxaEiSdHC36/jxKMc6Qt7QWGaw8ad0QQRpI5C0bjNYBFJBlE4x2LsCqZmW8oBM0y aYBIkoiTEwoNDmx25o3vSFTBvLKB+vW4QwqJe75TWM393SyWPgbzVhi2ANIBybGi MnI+stDpGYR+tsIdesb92RarDs2XNvYBweyn8Ma5I3zQ9vB73N2HSqIOQWslTfhy YR9JdbCkRPolC0nlqBiV6fvZ4OfGHTIf1Xg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1693472317; x=1693558717; bh=GO+RB/XjbQvZQe1MEUlBwDOw8njnoFbRMlk s6o1U5dw=; b=wWCYcoiHIWSq6hvrKzB6e7q/Au0spKWXt3QQFGqdXB+iKS7I5q0 YAD+isxn3z2fvMaAMJoaO9dQ0DaDikza3c2HMz85dr2RtQJfPq7pIo4MctLzdSPo jX2EJ1uWH1nd3KGi+A0PNhe/kFOTUrp8HAdwsve/bCxDHCSeL2X/GFhX5BwdAxXZ AJfOOW8xb1pXyNuxe/P2RkSM8hDFd/LawAjpnB/Ly3Lh6qoP8RLyco7YnI5BINaE nYx0YokHgRvzh/h28BNST9da5SzbDnQUXX4lViJ0+a2K6r+7YUqToiwAEktU6a5F wfcIiDfwQdSYS0AJXtCDhcYd89mrKWFe93Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudegtddguddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeflihgr gihunhcujggrnhhguceojhhirgiguhhnrdihrghnghesfhhlhihgohgrthdrtghomheqne cuggftrfgrthhtvghrnhepudfhkeevvddtueekfeefgfetlefgueegueeltddtieejgeei heevgfehgfdvfeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepjhhirgiguhhnrdihrghnghesfhhlhihgohgrthdrtghomh X-ME-Proxy: Feedback-ID: ifd894703:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 31 Aug 2023 04:58:33 -0400 (EDT) Message-ID: <62a7b292-ea1e-fb88-79cb-e7968d350a5e@flygoat.com> Date: Thu, 31 Aug 2023 16:58:32 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v2] pci: loongson: Workaround MIPS firmware MRRS settings Content-Language: en-GB To: Huacai Chen Cc: linux-pci@vger.kernel.org, bhelgaas@google.com, linux-kernel@vger.kernel.org, kw@linux.com, lpieralisi@kernel.org, stable@vger.kernel.org References: <20230725061008.1504292-1-jiaxun.yang@flygoat.com> <861a809d-3df1-327e-e033-87506f6d89e5@flygoat.com> From: Jiaxun Yang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2023/8/31 14:22, Huacai Chen 写道: [...] > But it is worth to try, and you can walk the children to set mrrs when > the quirk runs on bridges, I think. No, this will break hotplug, I had managed to get hotplug work on 2K1000. Also we have no guarantee on order of discovering devices. >> but the old quirk should run on every single device. > Your current patch has a drawback that both quirks will run for MIPS, > and their order is random (though it may cause nothing, but not > elegant). Actually loongson_mrrs_quirk is declared by DECLARE_PCI_FIXUP_EARLY but loongson_old_mrrs_quirk is declared by DECLARE_PCI_FIXUP_ENABLE, which means loongson_old_mrrs_quirk always runs after loongson_mrrs_quirk as expected. Thanks - Jiaxun [...]