From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C43BBEB64D9 for ; Thu, 15 Jun 2023 04:20:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243032AbjFOEUw (ORCPT ); Thu, 15 Jun 2023 00:20:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242890AbjFOEUp (ORCPT ); Thu, 15 Jun 2023 00:20:45 -0400 Received: from out30-118.freemail.mail.aliyun.com (out30-118.freemail.mail.aliyun.com [115.124.30.118]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDA2410A for ; Wed, 14 Jun 2023 21:20:43 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R111e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046056;MF=jefflexu@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0Vl9-ymZ_1686802839; Received: from 30.221.149.215(mailfrom:jefflexu@linux.alibaba.com fp:SMTPD_---0Vl9-ymZ_1686802839) by smtp.aliyun-inc.com; Thu, 15 Jun 2023 12:20:41 +0800 Message-ID: <62aa21a7-283a-4860-2a0a-b23ed38e6424@linux.alibaba.com> Date: Thu, 15 Jun 2023 12:20:37 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] erofs: remove unnecessary goto Content-Language: en-US To: Yangtao Li , Gao Xiang , Chao Yu , Yue Hu Cc: linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <20230615034539.14286-1-frank.li@vivo.com> From: Jingbo Xu In-Reply-To: <20230615034539.14286-1-frank.li@vivo.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/15/23 11:45 AM, Yangtao Li wrote: > It's redundant, let's remove it. > > Signed-off-by: Yangtao Li Reviewed-by: Jingbo Xu > --- > fs/erofs/super.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/fs/erofs/super.c b/fs/erofs/super.c > index 811ab66d805e..f48ce692094d 100644 > --- a/fs/erofs/super.c > +++ b/fs/erofs/super.c > @@ -1016,10 +1016,8 @@ static int __init erofs_module_init(void) > sizeof(struct erofs_inode), 0, > SLAB_RECLAIM_ACCOUNT, > erofs_inode_init_once); > - if (!erofs_inode_cachep) { > - err = -ENOMEM; > - goto icache_err; > - } > + if (!erofs_inode_cachep) > + return -ENOMEM; > > err = erofs_init_shrinker(); > if (err) > @@ -1054,7 +1052,6 @@ static int __init erofs_module_init(void) > erofs_exit_shrinker(); > shrinker_err: > kmem_cache_destroy(erofs_inode_cachep); > -icache_err: > return err; > } > -- Thanks, Jingbo