From: chenridong <chenridong@huawei.com>
To: "Michal Koutný" <mkoutny@suse.com>
Cc: <tj@kernel.org>, <lizefan.x@bytedance.com>, <hannes@cmpxchg.org>,
<longman@redhat.com>, <adityakali@google.com>,
<sergeh@kernel.org>, <bpf@vger.kernel.org>,
<cgroups@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] cgroup/cpuset: reduce redundant comparisons for generating shecd domains
Date: Sat, 27 Jul 2024 15:26:10 +0800 [thread overview]
Message-ID: <62b0b761-37bf-4ae8-9eef-9ac275e99d6c@huawei.com> (raw)
In-Reply-To: <cfpvrcplrjeb7r4zscfjnmeahpi5c5c3kxtql2jyrj4hdp2l2x@25sfleq3wjph>
On 2024/7/26 19:37, Michal Koutný wrote:
> Hello.
>
> On Fri, Jul 26, 2024 at 08:59:46AM GMT, Chen Ridong <chenridong@huawei.com> wrote:
>> In the generate_sched_domains function, it's unnecessary to start the
>> second for loop with zero, which leads redundant comparisons.
>> Simply start with i+1, as that is sufficient.
>
> Please see
> https://lore.kernel.org/r/20240704062444.262211-1-xavier_qy@163.com
>
> Your patch is likely obsoleted with that.
>
> Michal
Thanks, Michal, I'm sorry I didn't notice these patches. It's a good
idea to optimize with uf_node.
Thanks
Ridong
prev parent reply other threads:[~2024-07-27 7:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-26 8:59 Chen Ridong
2024-07-26 11:37 ` Michal Koutný
2024-07-27 7:26 ` chenridong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62b0b761-37bf-4ae8-9eef-9ac275e99d6c@huawei.com \
--to=chenridong@huawei.com \
--cc=adityakali@google.com \
--cc=bpf@vger.kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=longman@redhat.com \
--cc=mkoutny@suse.com \
--cc=sergeh@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®