From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EAF426D4FB; Tue, 15 Jul 2025 06:37:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752561447; cv=none; b=oJldxafm2hcOEt2EJw2MeDr5Fmbhe9B1d7vuZ+9/Os4+bc8urIf/JwYJEodo5LY8CzyfgmHQWIQ0jb8f8SOnJZBQlrz304Qs6oII4Z2NfGU2iFe+abgizY1W8uO89brYgvTGuxsGQ3PCc6ziXC+VLKFSA1ktVcUXgnGGLa7OFGk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752561447; c=relaxed/simple; bh=QJSYFEA+ygE2WZbbXWc8V+Ze9PznoxhoiLjS/1W8Pdc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NdmbQovy+D82AEN6+ck5Su3xuLuU++3jaZGEZK58EYzSog9DIkDqRB8Zjs0tgVttEfw0WeAKWdhEipP6pdygRC/LLDQkelcpSW0mI2QwuUaZMRNfzXTWTTWUQnBFUw3iNZpM3HPubKmyV1aH+SZC3zE6LeaMwgSmB43E6Pcu43I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=d1S5+Xly; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="d1S5+Xly" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E1E56C4CEE3; Tue, 15 Jul 2025 06:37:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752561447; bh=QJSYFEA+ygE2WZbbXWc8V+Ze9PznoxhoiLjS/1W8Pdc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=d1S5+Xlym8m1xhCN+RL7SmlmYMlEQoimgRj8dtFHMuFYLtwUxQntRpOZNE5w01T5k Tc7y0bVEGblVy1nvT2JTUd3pQPKO1ZVlb7Vlunq35TTmMa9gPXs/SWs0BfmrBWRfCm pmNhdAnufbGtTq8/4AaHW+xW49jnx1aQ9iZhj+3YeRSoD8sNH2G5nGjrv4y20hGy27 5bkHotqpSu6ect6KuhitrhMZG4O0Olrjungw2valKmSrXw0vpZtkfehBAlNmbM8wDj xB5jjK7McXvY2byRsc+PxCqVvCE1NbgL8Pc0HNK1Y+XZ18JicHebgsc7UOFUBaNBrj SeZdKiE7lZRCQ== Message-ID: <62b0f514-a8a9-4147-a5c0-da9dbe13ce39@kernel.org> Date: Tue, 15 Jul 2025 08:37:21 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v2 1/3] dt-bindings: sram: qcom,imem: Allow modem-tables To: Konrad Dybcio , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alex Elder Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Alex Elder References: <20250527-topic-ipa_imem-v2-0-6d1aad91b841@oss.qualcomm.com> <20250527-topic-ipa_imem-v2-1-6d1aad91b841@oss.qualcomm.com> <97724a4d-fad5-4e98-b415-985e5f19f911@kernel.org> <68622599-02d0-45ca-82f5-cf321c153cde@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 14/07/2025 19:53, Konrad Dybcio wrote: > On 5/27/25 1:42 PM, Krzysztof Kozlowski wrote: >> On 27/05/2025 13:36, Konrad Dybcio wrote: >>>>> diff --git a/Documentation/devicetree/bindings/sram/qcom,imem.yaml b/Documentation/devicetree/bindings/sram/qcom,imem.yaml >>>>> index 2711f90d9664b70fcd1e2f7e2dfd3386ed5c1952..7c882819222dc04190db357ac6f9a3a35137cc9e 100644 >>>>> --- a/Documentation/devicetree/bindings/sram/qcom,imem.yaml >>>>> +++ b/Documentation/devicetree/bindings/sram/qcom,imem.yaml >>>>> @@ -51,6 +51,9 @@ properties: >>>>> $ref: /schemas/power/reset/syscon-reboot-mode.yaml# >>>>> >>>>> patternProperties: >>>>> + "^modem-tables@[0-9a-f]+$": >>>>> + description: Region reserved for the IP Accelerator >>>> >>>> Missing additionalProperties: false, which would point you that this is >>>> incomplete (or useless because empty). >>> >>> How do I describe a 'stupid' node that is just a reg? >> With "reg" - similarly to many syscon bindings. > > Is this sort of inline style acceptable, or should I introduce > a separate file? It's fine, assuming that it is desired in general. We do not describe individual memory regions of syscon nodes and this is a syscon. If this is NVMEM (which it looks like), then could use NVMEM bindings to describe its cells - individual regions. But otherwise we just don't. There are many exceptions in other platforms, mostly old or even unreviewed by DT maintainers, so they are not a recommended example. This would need serious justification WHY you need to describe the child. Why phandle to the main node is not enough for consumers. If the reason is - to instantiate child device driver - then as well no. This has been NAKed on the lists many times - you need resources if the child should be a separate node. Address space is one resource but not enough, because it can easily be obtained from the parent/main node. Best regards, Krzysztof