From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD2B5344DBE for ; Fri, 27 Mar 2026 16:17:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774628238; cv=none; b=YTkIBP6yhpAQRl/uzWhGcab3aeZqpRQFEB4OrBCt4RGJC4WsmtNytroJ05Ec2waGrS93EkmJ8/761hr/18sr/4BuGRkZtGyvTrrqH3GgjbVTh4gmVI6jyiOgQN0XhFE+E0zpIqJAXNtn7/Vf7LriHM2tDoYFS+tX312gid6o5AU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774628238; c=relaxed/simple; bh=BKJFY2NIxudZsPuHzaM9oRP1BXkSuTngg+X2PglP7zs=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=Udfj8YIyuJ98Y53cLPr9vabGStFimJ1p7bEVKDE46IwaZL3va+RqmgIEIDa8LraVGFHl+JqeUGKt+P7TA6cC6sBuRUievvIuSk5k9w1tWjDSkLVlSB7HPD1UW8iQcuDuh9d9QzY/UUSWe8mCvxdIxjKinqgU5bVn6gPGqmtPbSw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ta4/5kO6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ta4/5kO6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60ED6C2BCB0; Fri, 27 Mar 2026 16:17:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774628238; bh=BKJFY2NIxudZsPuHzaM9oRP1BXkSuTngg+X2PglP7zs=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=ta4/5kO6i/NoZ7jADBQwO1eVl+FIre1hh0h3wpQHkxv7xYyFLKwxgZtjEZf1OWzIn YmzwATeKQVgyqqRz3FpOuZBxp7rnkYLuxauGXJC3zhTGT7TWXc2/5NKIdMN8PUYamM o/9YrOkXgCmQljqeQv4MX/DVcEXvO+fPIeVKr6aegHULbZhFZseK5e440w53chOKUS cGJfdYnQht6rlYChproMSvVkL0x1/XeeX6Rpqcsje8E0s13CCLdxx+1gK50R5DXok7 slpUplsCZvVBRquI4qaJVKo6foLIrLD01y+8/3h9OZxMVM2S3PD5SRA+l3fgzSsM0x RTu4VbknguuFg== Received: from phl-compute-01.internal (phl-compute-01.internal [10.202.2.41]) by mailfauth.phl.internal (Postfix) with ESMTP id 639E3F4007F; Fri, 27 Mar 2026 12:17:17 -0400 (EDT) Received: from phl-imap-02 ([10.202.2.81]) by phl-compute-01.internal (MEProxy); Fri, 27 Mar 2026 12:17:17 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgdeffedtjeegucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepofggfffhvfevkfgjfhfutgfgsehtjeertdertddtnecuhfhrohhmpedftehrugcu uehivghshhgvuhhvvghlfdcuoegrrhgusgeskhgvrhhnvghlrdhorhhgqeenucggtffrrg htthgvrhhnpeekvdffkefhgfegveekfedtieffhfelgeetiedvieffhfekfeeikeetueeg teetteenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomheprghrugdomhgvshhmthhprghuthhhphgv rhhsohhnrghlihhthidqudeijedthedttdejledqfeefvdduieegudehqdgrrhgusgeppe hkvghrnhgvlhdrohhrghesfihorhhkohhfrghrugdrtghomhdpnhgspghrtghpthhtohep jedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepthhssghoghgvnhgusegrlhhphh grrdhfrhgrnhhkvghnrdguvgdprhgtphhtthhopehhvghrsggvrhhtsehgohhnughorhdr rghprghnrgdrohhrghdrrghupdhrtghpthhtohepvggsihhgghgvrhhssehkvghrnhgvlh drohhrghdprhgtphhtthhopehlihhnuhigqdgtrhihphhtohesvhhgvghrrdhkvghrnhgv lhdrohhrghdprhgtphhtthhopehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnh gvlhdrohhrghdprhgtphhtthhopehlihhnuhigqdhmihhpshesvhhgvghrrdhkvghrnhgv lhdrohhrghdprhgtphhtthhopehjrghsohhnseiigidvtgegrdgtohhm X-ME-Proxy: Feedback-ID: ice86485a:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 432DD700065; Fri, 27 Mar 2026 12:17:17 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ThreadId: AgNmpo8XctVF Date: Fri, 27 Mar 2026 17:16:57 +0100 From: "Ard Biesheuvel" To: "Eric Biggers" , linux-crypto@vger.kernel.org Cc: linux-kernel@vger.kernel.org, "Jason A . Donenfeld" , "Herbert Xu" , linux-mips@vger.kernel.org, "Thomas Bogendoerfer" Message-Id: <62b754e9-b619-46a0-8646-aafaf7a6fa73@app.fastmail.com> In-Reply-To: <20260326204824.62010-1-ebiggers@kernel.org> References: <20260326204824.62010-1-ebiggers@kernel.org> Subject: Re: [PATCH] lib/crypto: mips: Drop optimized MD5 code Content-Type: text/plain Content-Transfer-Encoding: 7bit On Thu, 26 Mar 2026, at 21:48, Eric Biggers wrote: > MD5 is obsolete. Continuing to maintain architecture-optimized > implementations of MD5 is unnecessary and risky. It diverts resources > from the modern algorithms that are actually important. > > While there was demand for continuing to maintain the PowerPC optimized > MD5 code to accommodate userspace programs that are misusing AF_ALG > (https://lore.kernel.org/linux-crypto/c4191597-341d-4fd7-bc3d-13daf7666c41@csgroup.eu/), > no such demand has been seen for the MIPS Cavium Octeon optimized MD5 > code. Note that this code runs on only one particular line of SoCs. > > Thus, let's drop it and focus effort on the more modern SHA algorithms, > which already have optimized code for the same SoCs. > > Signed-off-by: Eric Biggers > --- > > This patch is targeting libcrypto-next > > lib/crypto/Kconfig | 1 - > lib/crypto/mips/md5.h | 65 ------------------------------------------- > 2 files changed, 66 deletions(-) > delete mode 100644 lib/crypto/mips/md5.h > Acked-by: Ard Biesheuvel