mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Bastien Nocera <hadess@hadess.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, "Johan Hovold" <johan@kernel.org>,
	"Alan Stern" <stern@rowland.harvard.edu>,
	"Richard Dodd" <richard.o.dodd@gmail.com>,
	"Jonathan Cox" <jonathan@jdcox.net>,
	"Thiébaud Weksteen" <tweek@google.com>,
	"Nishad Kamdar" <nishadkamdar@gmail.com>
Subject: Re: [PATCH 1/8] USB: rename USB quirk to USB_QUIRK_ENDPOINT_IGNORE
Date: Fri, 19 Jun 2020 12:53:57 +0200	[thread overview]
Message-ID: <62b8ddc4-8d26-1160-6934-fe6a68231938@redhat.com> (raw)
In-Reply-To: <484c84b62140f6536f841e7027ddd9ddcf179a72.camel@hadess.net>

Hi Bastien,

On 6/19/20 12:50 PM, Bastien Nocera wrote:
> On Thu, 2020-06-18 at 11:42 +0200, Greg Kroah-Hartman wrote:
>> The USB core has a quirk flag to ignore specific endpoints, so rename
>> it
>> to be more obvious what this quirk does.
>>
>> Cc: Johan Hovold <johan@kernel.org>
>> Cc: Alan Stern <stern@rowland.harvard.edu>
>> Cc: Richard Dodd <richard.o.dodd@gmail.com>
>> Cc: Hans de Goede <hdegoede@redhat.com>
>> Cc: Jonathan Cox <jonathan@jdcox.net>
>> Cc: Bastien Nocera <hadess@hadess.net>
>> Cc: "Thiébaud Weksteen" <tweek@google.com>
>> Cc: Nishad Kamdar <nishadkamdar@gmail.com>
>> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> If the driver API change below is agreeable, you can add my:
> Reviewed-by: Bastien Nocera <hadess@hadess.net>

A note for future reference, not sure what you mean with driver
API here. If you mean the in kernel API, the kernel rules are
that we are always free to change that (Linux does not have a
stable driver API).

So if a header does not sit under include/uapi (indicating that
it is an userspace API) then a change like this is fine.

Regards,

Hans



> Good job.
> 
> <snip>
>> diff --git a/include/linux/usb/quirks.h b/include/linux/usb/quirks.h
>> index 22c1f579afe3..5e4c497f54d6 100644
>> --- a/include/linux/usb/quirks.h
>> +++ b/include/linux/usb/quirks.h
>> @@ -69,7 +69,7 @@
>>   /* Hub needs extra delay after resetting its port. */
>>   #define USB_QUIRK_HUB_SLOW_RESET		BIT(14)
>>   
>> -/* device has blacklisted endpoints */
>> -#define USB_QUIRK_ENDPOINT_BLACKLIST		BIT(15)
>> +/* device has endpoints that should be ignored */
>> +#define USB_QUIRK_ENDPOINT_IGNORE		BIT(15)
>>   
>>   #endif /* __LINUX_USB_QUIRKS_H */
> 
> 
> 


  reply	other threads:[~2020-06-19 10:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-18  9:42 [PATCH 0/8] USB: fix up some old and obsolete terminology, we can do better Greg Kroah-Hartman
2020-06-18  9:42 ` [PATCH 1/8] USB: rename USB quirk to USB_QUIRK_ENDPOINT_IGNORE Greg Kroah-Hartman
2020-06-19 10:50   ` Bastien Nocera
2020-06-19 10:53     ` Hans de Goede [this message]
2020-06-19 11:08       ` Bastien Nocera
2020-06-19 12:24         ` Greg Kroah-Hartman
2020-06-18  9:42 ` [PATCH 2/8] USB: rename USB OTG hub configuration option Greg Kroah-Hartman
2020-06-18  9:42 ` [PATCH 3/8] USB: OHCI: remove obsolete FIXME comment Greg Kroah-Hartman
2020-06-18  9:42 ` [PATCH 4/8] USB: serial: qcserial: fix up wording in a comment Greg Kroah-Hartman
2020-06-18  9:42 ` [PATCH 5/8] USB: serial: sierra: unify quirk handling logic Greg Kroah-Hartman
2020-06-18  9:42 ` [PATCH 6/8] USB: storage: fix wording in error message Greg Kroah-Hartman
2020-06-18  9:42 ` [PATCH 7/8] USB: storage: scsi: fix up comment to be more specific Greg Kroah-Hartman
2020-06-18  9:43 ` [PATCH 8/8] USB: OTG: rename product list of devices Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=62b8ddc4-8d26-1160-6934-fe6a68231938@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hadess@hadess.net \
    --cc=johan@kernel.org \
    --cc=jonathan@jdcox.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=nishadkamdar@gmail.com \
    --cc=richard.o.dodd@gmail.com \
    --cc=stern@rowland.harvard.edu \
    --cc=tweek@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®