From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E20D2C2D0E7 for ; Mon, 30 Mar 2020 03:29:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C37F02083E for ; Mon, 30 Mar 2020 03:29:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729257AbgC3D3Q (ORCPT ); Sun, 29 Mar 2020 23:29:16 -0400 Received: from mga18.intel.com ([134.134.136.126]:12334 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728107AbgC3D3Q (ORCPT ); Sun, 29 Mar 2020 23:29:16 -0400 IronPort-SDR: 6tT6uq7p3NIff24VgkP16WaqdGIsI0UdTAuh/gMdZfDijT/7U5DMWVsnPVwERmKC5q20Zii+PT MxZb7BWwFdvA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2020 20:29:15 -0700 IronPort-SDR: y/3bTEDA7n9CRAqYwSzGe6+s7KhfcxDilgaVk+4lIyiGhQ3zIMFTuugiuDePCAxAELkUeka0Su nhg+bWFtBa7Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,322,1580803200"; d="scan'208";a="449657435" Received: from linux.intel.com ([10.54.29.200]) by fmsmga006.fm.intel.com with ESMTP; 29 Mar 2020 20:29:14 -0700 Received: from [10.226.38.46] (unknown [10.226.38.46]) by linux.intel.com (Postfix) with ESMTP id 07CFF5802A3; Sun, 29 Mar 2020 20:29:11 -0700 (PDT) Subject: Re: [PATCH v7 0/2] clk: intel: Add a new driver for a new clock controller IP To: sboyd@kernel.org, mturquette@baylibre.com, linux-clk@vger.kernel.org Cc: robh@kernel.org, mark.rutland@arm.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, andriy.shevchenko@intel.com, qi-ming.wu@intel.com, yixin.zhu@linux.intel.com, cheol.yong.kim@intel.com References: From: "Tanwar, Rahul" Message-ID: <62be98d9-82a1-1062-22e1-4d1d1c008b27@linux.intel.com> Date: Mon, 30 Mar 2020 11:29:11 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Stephen Boyd, After few rounds of review comments/updates from you & other reviewers, this patch series seems to be lost :-\. No further review concerns or acks from past 2 months. I am wondering if this is due to any outstanding concerns/expectations or it is just bad luck. Since you are the clk maintainer, may i ask you to clarify what is it that i am missing. Thanks. Regards, Rahul On 24/3/2020 12:05 pm, Rahul Tanwar wrote: > Hi, > > This series adds clock driver for Clock Generation Unit(CGU) of > Lightning Mountain(LGM) SoC. > > Patch 1 adds bindings document & include file for CGU. > Patch 2 adds common clock framework based clock driver for CGU. > > These patches are baselined upon Linux 5.6-rc1 at below Git link: > git git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git > > v7: > - Fix a mistake in comments explaining structure fields. > > v6: > - Resolve Kconfig dependencies issues (Randy Dunlap) > > v5: > - Address review concerns - mainly below mentioned. (Stephen Boyd) > - Improve commit message, add COMPILE_TEST in KConfig dependency. > - Remove unused header include files, drop unnecessary casts. > - Switch to using readl_poll_timeout() instead of implementing timeout routine. > - Avoid using small functions which are called just once. Inline them or > remove them. > - const static --> static const > - Fix coding style/convention related review concerns. > - Use __iomem for all IO addresses variables. > - Consolidate clk_enable & clk_disable ops into a common clk_enable_disable > routine to avoid redundant code. > - Remove unnecessary dev pointers for clk data structures. > - Redesign code to use new way of specifying clk_parents i.e. use > clk_parent_data.fw_name instead of older parent_name strings. > - Switch from raw_spin_locks() to normal spin_locks() and realign locking. > - Drop __initconst, __init, __refdata. > - Reorder patch series - make dt-binding patch as first patch. > - Add pointer to include file in dt-bindings document. > - Remove CLK_IS_CRITICAL flag for clks for which IGNORE_UNUSED flag is enough. > Add comments for clks which are marked as CRITICAL. > - Fix $id path in dt-bindings - drop bindings. (Rob Herring). > - Add Reviewed-by tag from Rob Herring. Thanks Rob. > > v4: > - Add drivers/clk/x86/Kconfig file which got missed in v3 by mistake. > > v3: > - Address review concerns: > Add Kconfig entry in x86 folder instead of modifying clk/Kconfig. (Andy Shevchenko) > Fix coding style/convention related concerns. (Andy Shevchenko) > Improve description, licensing info, rename node name correctly in dt bindings > document & remove CLK_NR_CLKS from dt-bindings header file. (Stephen Boyd) > Fix a build warning reported by kbuild test robot & Nathan Chancellor > - Add few new clocks & rename few existing clocks. > - Add more ops for ddiv & divider clk_ops. > - Fix few minor bugs. > - Use CLK_IS_CRITICAL flag for clocks which shall never be disabled. > > v2: > - Move the driver to x86 folder. > - Remove syscon usage. > - Remove regmap based access. Use direct readl()/write() instead. Add spinlocks. > - Change all enum values to capitals. > - Rename all data structures & functions from intel_* to lgm_*. > - Remove multiple header files. Keep only one header file. > - Make probe fail when any of the clk/pll registration fails. > - Fix few bugs with clk_init_data assignement. > - Address review concerns for code quality/style/convention. > > v1: > - Initial version. > > > Rahul Tanwar (1): > dt-bindings: clk: intel: Add bindings document & header file for CGU > > rtanwar (1): > clk: intel: Add CGU clock driver for a new SoC > > .../devicetree/bindings/clock/intel,cgu-lgm.yaml | 44 ++ > drivers/clk/Kconfig | 1 + > drivers/clk/x86/Kconfig | 8 + > drivers/clk/x86/Makefile | 1 + > drivers/clk/x86/clk-cgu-pll.c | 156 +++++ > drivers/clk/x86/clk-cgu.c | 636 +++++++++++++++++++++ > drivers/clk/x86/clk-cgu.h | 335 +++++++++++ > drivers/clk/x86/clk-lgm.c | 492 ++++++++++++++++ > include/dt-bindings/clock/intel,lgm-clk.h | 165 ++++++ > 9 files changed, 1838 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/intel,cgu-lgm.yaml > create mode 100644 drivers/clk/x86/Kconfig > create mode 100644 drivers/clk/x86/clk-cgu-pll.c > create mode 100644 drivers/clk/x86/clk-cgu.c > create mode 100644 drivers/clk/x86/clk-cgu.h > create mode 100644 drivers/clk/x86/clk-lgm.c > create mode 100644 include/dt-bindings/clock/intel,lgm-clk.h >