From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94DD4C43215 for ; Mon, 18 Nov 2019 11:57:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6B2FA2068D for ; Mon, 18 Nov 2019 11:57:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726833AbfKRL5U (ORCPT ); Mon, 18 Nov 2019 06:57:20 -0500 Received: from wp126.webpack.hosteurope.de ([80.237.132.133]:41076 "EHLO wp126.webpack.hosteurope.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726506AbfKRL5U (ORCPT ); Mon, 18 Nov 2019 06:57:20 -0500 Received: from [2003:a:659:3f00:1e6f:65ff:fe31:d1d5] (helo=hermes.fivetechno.de); authenticated by wp126.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) id 1iWfef-0005JO-HE; Mon, 18 Nov 2019 12:57:17 +0100 X-Virus-Scanned: by amavisd-new 2.11.1 using newest ClamAV at linuxbbg.five-lan.de Received: from [192.168.34.101] (p5098d998.dip0.t-ipconnect.de [80.152.217.152]) (authenticated bits=0) by hermes.fivetechno.de (8.15.2/8.14.5/SuSE Linux 0.8) with ESMTPSA id xAIBvGMN025495 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Mon, 18 Nov 2019 12:57:16 +0100 Subject: Re: [PATCH] arm64: dts: rockchip: Split rk3399-roc-pc for with and without mezzanine board. To: Jagan Teki , =?UTF-8?Q?Heiko_St=c3=bcbner?= Cc: Mark Rutland , devicetree , linux-kernel , "open list:ARM/Rockchip SoC..." , Rob Herring , linux-arm-kernel References: <075b3fa6-dab7-5fec-df68-b53f32bf061b@fivetechno.de> <2226540.xovL9aYQn6@diego> From: Markus Reichl Autocrypt: addr=m.reichl@fivetechno.de; prefer-encrypt=mutual; keydata= xsDNBFs02GcBDADRBOYE75/gs54okjHfQ1LK8FfNH5yMq1/3MxhqP7gsCol5ZGbdNhJ7lnxX jIEIlYfd6EgJMJV6E69uHe4JF9RO0BDdIy79ruoxnYaurxB40qPtb+YyTy3YjeNF3NBRE+4E ffvY5AQvt3aIUP83u7xbNzMfV4JuxaopB+yiQkGo0eIAYqdy+L+5sHkxj/MptMAfDKvM8rvT 4LaeqiGG4b8xsQRQNqbfIq1VbNEx/sPXFv6XDYMehYcbppMW6Zpowd46aZ5/CqP6neQYiCu2 rT1pf/s3hIJ6hdauk3V5U8GH/vupCNKA2M2inrnsRDVsYfrGHC59JAB545/Vt8VNJT5BAPKP ka4lgIofVmErILAhLtxu3iSH6gnHWTroccM/j0kHOmrMrAmCcLrenLMmB6a/m7Xve5J7F96z LAWW6niQyN757MpgVQWsDkY2c5tQeTIHRlsZ5AXxOFzA44IuDNIS7pa603AJWC+ZVqujr80o rChE99LDPe1zZUd2Une43jEAEQEAAc0iTWFya3VzIFJlaWNobCA8cmVpY2hsQHQtb25saW5l LmRlPsLA8AQTAQoAGgQLCQgHAhUKAhYBAhkBBYJbNNhnAp4BApsDAAoJEDol3g5rGv2ygaMM AMuGjrnzf6BOeXQvadxcZTVas9HJv7Y0TRgShl4ItT6u63+mvOSrns/w6iNpwZxzhlP9OIrb v2gorWDvW8VUXaCpA81EEz7LTrq+PYFEfIdtGgKXCOqn0Om8AHx5EmEuPF+dvUjESVoG85hL Q6r6PJUh8xhYGMUYMer/ka2jAu2hT1sLpmPijXnw9TvC2K9W3paouf4u5ZtG32fegvUeoQ1R t30k0bYRNqX8xboD1mMKgc4IWLsH6I0MROwTF7JvarkC9rU/M6OL6dwnNuauLvGVs/aXLrn2 UYxas9erPOwr+M45f8OR7O8xxvKoP5WSU6qWB/EExfm/ZBUkDKq8nDgItEpm+UUxpS9EpyvC TIQ3qkqHGn1cf2+XRUjaCGsRG6fyY7XM4v5ariuMrg8RV7ec2jxIs3546pXx4GFP6rBcZZoW f6y2A6h47rWGHAhbZ6cnJp/PMDIQrnVkzQHYBkTuhTp1bzUGhCfKLhz2M/UAIo+4VNUicJ56 PgDT5NYvvc7AzQRbNNhnAQwAmbmYfkV7PA3zrsveqraUIrz5TeNdI3GPO/kBWPFXe/ECaCoX IVfacTV8miHvxqU92Vr/7Zw7lland+UgHa7MGlJfNHoqXIVL8ZWAj+mGf4jMo02S+XtUvdL7 LtALQwXlT7GD0e9Efyk/AV9vL8aiseT/SmW6+sAhs9Q7XPvZWE/ME1M/WRlDsi32g04mkvOz G/bGN9De+LoSgn/220udTgLpq2aJEYGgvgZRVDKeOGSeP9cAKYQPjsW0okFfVyezZubNHLwd yjVFxGB2XIH/XIVo13E2SFvWHrdjmCcZek37k4uftdYG90iBXS3Dtp0u87yiOIoL2PXM8qLU 2+FhXphjce6Ef33nKQpelWLXxlrXUr1lOmNTAHfVIsKmGsRBqRBmphLMJOfyD6enYR0B/f+s LVDtKFrMzhkjqvanwlcQkbpN6DvD409QRaUwxQiUaCcplUqHnJvKdjO7zCI4u6T6hjvciBrg EBB+uN15uGg+LODRZ4Ue0KaWoiH6n1IxABEBAAHCwN8EGAEKAAkFgls02GcCmwwACgkQOiXe Dmsa/bKWFgwAw3hc1BGC65BhhcYyikqRNI6jnHQVC29ax1RTijC2PJZ5At+uASYAy97A2WjC L3UdLU/B6yhcEt3U6gwQgQbfrbPObjeZi8XSQzP2qZI8urjnIPUG7WYDK8grFqpjvAWPBhpS B5CeMaICi9ppZnqkE3/d/NMXHCU/qbARpATJGODk64GnJEnlSWDbWfTgEUd+lnUQVKAZfy5Z 5oYabpGpG5tDM49LxuC4ZpTkKiX+eT1YxsKH9fCSFnETR54ZVCS7NQDOTtpHDA2Qz2ie3sNC H7YyH580i9znwePyhCFQQeX+jo2r2GQ0v+kOQrL9wwluW6xNWBakhLanQFrHypn7azpOCaIr pWfxOm9CPEk4zGjQmE7sW1HfIdYC39OeEEnoPdnNGxn7sf6Fuv+fahAs8ls33JBdtEAPLiR8 Dm43HZwTBXPwasFHnGkF10N7aXf3r8WYpctbZYlcT5EV9m9i4jfWoGzHS5V4DXmv6OBmdLYk eD/Xv4SsK2JTO4nkQYw8 Organization: five technologies GmbH Message-ID: <62bfaad5-cbd6-efbd-426b-3da681fcd160@fivetechno.de> Date: Mon, 18 Nov 2019 12:57:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: 8bit X-bounce-key: webpack.hosteurope.de;m.reichl@fivetechno.de;1574078239;98fa53a2; X-HE-SMSGID: 1iWfef-0005JO-HE Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jagan, Am 18.11.19 um 12:44 schrieb Jagan Teki: > On Mon, Nov 4, 2019 at 5:42 PM Heiko Stübner wrote: >> >> Hi Markus, >> >> Am Freitag, 1. November 2019, 17:54:23 CET schrieb Markus Reichl: >> > For rk3399-roc-pc is a mezzanine board available that carries M.2 and >> > POE interfaces. Use it with a separate dts. >> > >> > Signed-off-by: Markus Reichl >> > --- >> > arch/arm64/boot/dts/rockchip/Makefile | 1 + >> > .../boot/dts/rockchip/rk3399-roc-pc-mezz.dts | 52 ++ >> > .../arm64/boot/dts/rockchip/rk3399-roc-pc.dts | 757 +---------------- >> > .../boot/dts/rockchip/rk3399-roc-pc.dtsi | 767 ++++++++++++++++++ >> > 4 files changed, 821 insertions(+), 756 deletions(-) >> > create mode 100644 arch/arm64/boot/dts/rockchip/rk3399-roc-pc-mezz.dts >> > create mode 100644 arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi >> > >> > diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile >> > index a959434ad46e..80ee9f1fc5f5 100644 >> > --- a/arch/arm64/boot/dts/rockchip/Makefile >> > +++ b/arch/arm64/boot/dts/rockchip/Makefile >> > @@ -28,6 +28,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-nanopi-neo4.dtb >> > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-orangepi.dtb >> > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-puma-haikou.dtb >> > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-roc-pc.dtb >> > +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-roc-pc-mezz.dtb >> > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rock-pi-4.dtb >> > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rock960.dtb >> > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rockpro64.dtb >> > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc-mezz.dts b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc-mezz.dts >> > new file mode 100644 >> > index 000000000000..ee77677d2cf2 >> > --- /dev/null >> > +++ b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc-mezz.dts >> > @@ -0,0 +1,52 @@ >> > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) >> > +/* >> > + * Copyright (c) 2017 T-Chip Intelligent Technology Co., Ltd >> > + * Copyright (c) 2019 Markus Reichl >> > + */ >> > + >> > +/dts-v1/; >> > +#include "rk3399-roc-pc.dtsi" >> > + >> > +/ { >> > + model = "Firefly ROC-RK3399-PC Mezzanine Board"; >> > + compatible = "firefly,roc-rk3399-pc", "rockchip,rk3399"; >> >> different board with same compatible isn't possible, so >> you'll need a new compatible for it and add a new line to >> the roc-pc entry in >> Documentation/devicetree/bindings/arm/rockchip.yaml >> >> Either you see it as >> - a board + hat, using dt overlay and same compatible >> - a completely separate board, which needs a separate >> compatible as well >> >> And as discussed in the previous thread >> http://lists.infradead.org/pipermail/linux-rockchip/2019-November/027592.html >> but also in Jagan's response that really is somehow a grey area >> for something relatively static as the M.2 extension. > > Sorry for late response on this. I still think that the "overlay would > be a better suite" than having separate dts, since it is HAT which is > optional to insert and have possibility of having another HAT if it > really fit into it. > > Comments? Presently no other extension board does exist, I don't expect one. I use it with rootfs on NVME on the mezzanine board. It is convenient to have the NVME up before going to user space. The board has SPI-NOR MTD storage to host U-Boot. In future U-Boot could boot from NVME directly without needing an SD or MMC to host the boot kernel. Gruß, -- Markus Reichl