From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 380301A3164 for ; Wed, 10 Jun 2026 13:14:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781097275; cv=none; b=TNze3OCBItSENWz3FdgTZrAdARRMiPLcnQAv+G2xGmIxjptymM+6WFxHTelBSkIoO877NxDvmoFnvvAmIc1l4yB+hAZkxS5zX7pZ9FrXkGIVjeAlM6fLNLh72x1eN+ftIHDzCyJEPesWXwSp1S45fnwaBgcQJhTwQChU/rInI68= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781097275; c=relaxed/simple; bh=8W+0hThKAZc6wDLK7nhSYHduijnCeiUXGq6A9UZ/gv0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Fc9dtx+LwJ+utYA20e4yFGjOFoLLV8kN/GQk/h2FzbQYEE9fYPdtmJJgLMkWqsF4+d5xZxJyzE/EpLYN0LeY75Gg9QwvdNhdlXGpTgw+1SpdJNc9dTrD2wc1aOwGUW5P85JCvQD62KJ2cDdy368+K8yt1hMy584GT7ngmTrCK/Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LFiY08zv; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LFiY08zv" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-8424b6792efso2485084b3a.3 for ; Wed, 10 Jun 2026 06:14:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781097272; x=1781702072; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=WmCiNke9CNNPNgybTGSAGuI43T7yC5Pi1R1N6f3/7Iw=; b=LFiY08zvYTPmFXsIqgAaYw5In+/AZAdJHzS8T6sHmqzrppb6kmI8oSfqdfKSytnZBa mpA3tLze4hgyGo5umXoHQSg1K2kWY4CQCI0upyr3pJxu+IwA+2Rzjx2xZD6vYWu26Ah2 RuUlWnSDegB/C6yalbMW5yRpoVdWll7BYglyWzicGv5jdbrNCnZpqsgBVYAcijLE4Ef9 wsrsBYJ6PpiBYa1sUdNZBe2FLu4Q+d4r7un6dl5mw3MNK3xEYTTDgnHSLDQNqSjdj6ln qt3TJ1f4L8M/mHFjZTwmcM9UQK340Npu+nNR4wmBPMMTGN2kgGpID8++rbEGRVZNaJMA /Cwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781097272; x=1781702072; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=WmCiNke9CNNPNgybTGSAGuI43T7yC5Pi1R1N6f3/7Iw=; b=gnebK7bWtot9Ia0/4YckdHAsQ6EtQF6GNv7F/o8T48ikzwEKV/bkQQ+bZT5Ccw9QoD 4AdIAlI7B9rzr1q04nnzi/d1Y+nxlPAmylld5TkJZ3MYMhAsUzFmo1uhN1YIjhla8p1D eZdCR4u3LWMVZl7BU3qCrR6IBSPSe97qxLV2wPiCgVBUrYPFnwFYLMVLW8DS2wCe2Aw3 fRoeEb/iuZg18TrQGPKde/hqpgJrjJfayGHUWw4aHJ7uk5zfmRnPGXAKeQyz4P833a66 H5/MKLdQU1P73CKaFzHv24Atv3diaBXDHMJXfvKqJo2VgXG1HfdUs06LiPIPWDlV395/ rfQw== X-Forwarded-Encrypted: i=1; AFNElJ87AGGniOds0d4lpAcnclhjLaOfYJ/wI0PN0rnCK91wr1AIkYlIV17TlSB1zXJCnZZ7Aw3UBsS09eKAp6E=@vger.kernel.org X-Gm-Message-State: AOJu0YxioavQ99gBca9Iwp/Pg0P1nOW7DhPeBvfbPoM2NYXdhm6Uhin1 o1tWnYb+Le1JhvetwEymVC7u2FUqch12AYqnIs94hwAvSdWRuk0vDbmv X-Gm-Gg: Acq92OEyTkCNLRxMEEkPy1ggR8j1cOUscyO4z0+5Jbl3ILdpvooH0JvXGWq9rddbyYv Otb438i4F6i+wp5DSXJKbVNM2Agrzziqmba+v2v+xnY9Fl0mc1ewz2MxkF4Tm95leIoFmWZWLQ9 MxoL1jqmvdas4Btm/93wXVwrFEJZHtQftKFIw1xsbwJicz3E3mbH4F/SF1oNwjVFK/oeO0n+gKi 2LUuSGRI1c3WNjSMFL1M8R/HKfnNomDD+wpUU7lOpsWy9xuB3KrBlrbu95JBBLBb1Z7B8US/93n Jg10sSzWW/T5YBGZQkZJnBsmx4bi8FncKX8e5CnIr7iqvmXQ2IqunX7Ki6rziZBR8hglC67m8My unaA37PIpCYNZ1nC63o01Nu9Uw48Ux/grBl9eRfCbfdMKy2eYthXzcsvF5jc8IpOa8wLfPEbMht NIv6d+kntdOw4cDkk7u9ZGLAXlcCNo/LMOMOL1qQUdssDHhoOmySgK8L1hRA== X-Received: by 2002:a05:6a00:4288:b0:842:5b63:6112 with SMTP id d2e1a72fcca58-842b0f49abfmr26684930b3a.32.1781097272354; Wed, 10 Jun 2026 06:14:32 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84282221086sm25034213b3a.10.2026.06.10.06.14.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 06:14:32 -0700 (PDT) Sender: Guenter Roeck Date: Wed, 10 Jun 2026 06:14:31 -0700 From: Guenter Roeck To: Pei Xiao Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, cryolitia@uniontech.com Subject: Re: [PATCH v4 3/4] hwmon: (gpd-fan): upgrade log level from warn to err for platform device creation failure Message-ID: <62cbbb04-d8dc-4547-9d15-2dcba63d8a4e@roeck-us.net> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Jun 10, 2026 at 09:49:11AM +0800, Pei Xiao wrote: > When platform_create_bundle() fails, the error is fatal and prevents the > driver from loading. Use pr_err() instead of pr_warn() to clearly indicate > a critical failure. > > Signed-off-by: Pei Xiao Applied. Thanks, Guenter