From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2C5A3B71C3 for ; Mon, 22 Jun 2026 14:00:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782136826; cv=none; b=C6uXTkLCDPAWpWMNl2wznOC3FKl/UwpMxcOshja6Y6+GE/j2ZRY22MbbN0AGGV0WcS/RPJKWgFuY7mcO/JFmYO+wZgMfe+Z640jxHMFsP6VT7iklklnTk74DeMx9g5ZskRIRw1GAY9RSvzlt+8L9cYdND7J0nS12SatVHiNdXXU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782136826; c=relaxed/simple; bh=MdOeSIf8JKpQmOWa+YfZ6n0lbp36wLghMNUwe5mqJd4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kso3F+TwmeFNe0FkV6Lju6SdGyzDSb/EupOONLycRZ79BEpM70Y2nkW3TMITxERLSBQvuA/6lFGsDEHzpaCsDUz93XumhjVtKr1RpQW8HFbzR80Zc4o4RhEETiWPdAX+V2FdNQWUiB97yWcerGy7EE1t1sRKiQqsjeoXF9d8vF8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RGKqufGd; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=a9CuYkb6; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RGKqufGd"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="a9CuYkb6" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65MDFcoh773387 for ; Mon, 22 Jun 2026 14:00:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Y7USYdDcnIwSaPcutTPXYOBMfqHeBI2HwN0WtO8AXvM=; b=RGKqufGdxxcuu7Hm RAhsMkSYb3YPfHltO0ZoQfW4IZ7ZBASt4jXjvQafCBSbpiVFzuv8kpziZDCqovT1 wdE3UKVuHmD85EJcx8rEIhzkCegRLuilmiMWCyzIeTwWxIn94za3r8/Aa78rmhYQ XSbuvnJil9900aCytL9wCRsVndr+T+PH3qud0FD+otX3Wn9XGLj0mLsxgkJQ8je6 DGYVxuZFBAOTo4ovcyMMBFI+QhAjnteUdwhlo6aPZzIHaK9ZXIiQVdHF9TG4JHQj M7noSqsIizD7Z0GwNEL6MgeaRkR9+UqgxW22qQATv6gqI/67xjbYXm6gwgg2ueit Opa27w== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ey2yj8smh-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 22 Jun 2026 14:00:24 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-9156dc90fdaso69511585a.0 for ; Mon, 22 Jun 2026 07:00:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782136823; x=1782741623; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Y7USYdDcnIwSaPcutTPXYOBMfqHeBI2HwN0WtO8AXvM=; b=a9CuYkb6QTiEUj9qTKkEBhAjGzfqfXLhZSds3uxOPf3zo0cXam6gHsAFR/XKnMmMNs S9q1ZnpwPA+0BUdmI55dY8wjZIlinhtCnnK29D7BqoQao2FbN3IipKuflkIfN7BjVori JLqsJEUCcO5r1Knuv0gcY2onGxvyiKTq5mhIPu6iqIEcE6GI9CFx0/RcJ4Jnt3jYYA1w 8YUd/ue7SAlyckh888E71edBQKUXtPkw87lVey6gyXp7vK0BTZ17pDRcMxbly6+JGVJ+ zm4Y5uGAPMjwHkTSZBvRfM4tA3g2pxequpIqwID8jtZrP+axkazu6vXa//ZK2fJjFUjQ O4pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782136823; x=1782741623; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Y7USYdDcnIwSaPcutTPXYOBMfqHeBI2HwN0WtO8AXvM=; b=ML9ZjLQVS2dyFycFhH1hmg+/83RmfpmRzD3ei1OBUeHzaIfZHM7U4cU2P1jv+xwQKB nzrlfZ0diLxx84DFfZtYVUriZokhJDkByMEu6sWY7vYrp5XO32DO0Ohs6YOIgIE5TPlu agOsY6bBioE8uF4VO132MPVyvYfjFkgvpkGPNMVznPAuSabuqziSdougMRqd9JV+s1mc 99QamS4nCCIRD11Ct4zMat4zoy0QjsUXs58A1Rh0knHEDnY2grp6QfnZnLh28cml6NYt 7eQtpbxQKl4YyyQYxDDA5KBAn9gVYHxvofzEK9/n46qcp35G4vhfcRbZcxalXY8QZ8eT fpgw== X-Forwarded-Encrypted: i=1; AFNElJ+3GaIYRKfGY2d4KdHp7HWiROP4FOyuho4go01wDWOpGaNBUkLSnVTZHPgNIjbQWNzF+dXUVVNiTG0ZXkI=@vger.kernel.org X-Gm-Message-State: AOJu0Yw6FW39UOtHqy1rrt99+LWQp4gXTThp5CP7liHeRZBWgtlT52Hl BshUDVQ54El76fyxsKbxSJpKKmdMpkNrX5WLPvu9C6FMVBlKNKbDg+b6Mqrr96w/+w7VVo0bHzt y0DNzewy6Nsv16g+nIftlFHfhIv3MBF9Z3VEp5EpUXg9A21OdvmplhzJXyZEjyy16EOQ= X-Gm-Gg: AfdE7cnsTDsFO9BR3o63nVP5837SdZeFzqfMbtE92ooyvHryy8FhmWD3xqmW9ZYqpk7 AqOwyLjm6sS5YAURuhH5GUzD2BvCCNmfNVSG4AmXEkvLFBMdJgRmvmyS+OpTTx33Y4Ze/qq5MSD Wjjx86F/jfBuUsTkLbPAg26+CBDXnAbZYBeis3+DpuDALm/1FPVEZ067/Tmvdn7CatIdbuwNAT9 hIIhlEeto5IDprUb2e4d7SHiaoN66sK4ixQogMmy+WMzjETEZXzZWTEfLdTYNOm5SVMRpZjo4ID vcQvf/BHes8Y/79NXVMePrhVIjdtKakjo1X1qJPkIejF7t8QzSRBTJTw3wUe933NsJcYIOXmT1j cm8sNyoigmr2UQ1JsWLMysQQEYHGEGtOJvCU= X-Received: by 2002:a05:620a:19a9:b0:8cf:d953:b4ec with SMTP id af79cd13be357-925c8fc4599mr53172885a.3.1782136822922; Mon, 22 Jun 2026 07:00:22 -0700 (PDT) X-Received: by 2002:a05:620a:19a9:b0:8cf:d953:b4ec with SMTP id af79cd13be357-925c8fc4599mr53163685a.3.1782136822247; Mon, 22 Jun 2026 07:00:22 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c0c5e4a14d4sm368028166b.7.2026.06.22.07.00.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Jun 2026 07:00:21 -0700 (PDT) Message-ID: <62cfb2ec-f069-4012-88a1-8667d3f3e5e9@oss.qualcomm.com> Date: Mon, 22 Jun 2026 16:00:18 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/5] clk: qcom: gcc-hawi: Add support for global clock controller on Maili To: Taniya Das , Bjorn Andersson , Michael Turquette , Stephen Boyd , Brian Masney , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vivek Aknurwar Cc: Ajit Pandey , Imran Shaik , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260618-maili_initial_clock-v1-0-d6ede0352113@oss.qualcomm.com> <20260618-maili_initial_clock-v1-4-d6ede0352113@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260618-maili_initial_clock-v1-4-d6ede0352113@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: AWd_yY0F2bZUpREe7rW8-NGy4nxomfwP X-Proofpoint-GUID: AWd_yY0F2bZUpREe7rW8-NGy4nxomfwP X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIyMDEzOSBTYWx0ZWRfX2r+BJTLL6eSR juCS1IvYA2DmDF3XY3xo7Uzccn6qE5rD3APrlFkR/wGeuumCI/K8QwG0Cf3PC7n9DvtynszaJpC U3DYEm/3fAnIb7UBPJc3Hb0o+6LGqRk= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIyMDEzOSBTYWx0ZWRfX1MJhmsR8i98P GjhJ9TM1UtBMvwTSPeoAZ+7f1G+SY3hg3/Q13qi7cA6ptk7RGkJS/eqe7rKRif//W1VOOX0ZJuV 2m1YPYPkSQ66xW1OdZY92cHKHAsVICR4ugFrrblF8p+dRFyargqLDQA3M0EcQ1Seo3Iaw18cNJS sGfF8BsGJn7o5tTM9WD39OxXoPeT9dHoixOWrgBJOwovRht7gR74pZvrRw2ThTVOz0obYEY2qbt elkmuxCTzzd8CsnjArpmPvh3b+pdpOTEfFzgtDDlX66U4uo+HdFnXz1/bfvz64Mf6J5Uy6096y6 yR8fwK9wGavjJiYEr9Ds5NnzAI2pYBi6Xr1HH+aY+Mi8B/RSRvr3n8cqHYLIXDCEmC9VAXYLpCG lRUaAowP0hoeIVak4JUaLIFUcSJho99GlyMswjuF4LsU4ZrqJgNHVTeMuL07UgwuNwtUtE55I6t RaHJ4uhPXBVi0a7u7BQ== X-Authority-Analysis: v=2.4 cv=YLSvDxGx c=1 sm=1 tr=0 ts=6a393ff8 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=uYmEc_XH6j7-nL-_3AgA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-22_02,2026-06-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 bulkscore=0 clxscore=1015 phishscore=0 adultscore=0 spamscore=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606220139 On 6/18/26 7:21 PM, Taniya Das wrote: > Add support for the global clock controller (GCC) on the Qualcomm Maili > SoC by extending the Hawi global clock controller since Maili is identical > to Hawi and has few additional clocks. > > Signed-off-by: Taniya Das > --- [...] > @@ -3485,6 +3617,11 @@ static struct clk_regmap *gcc_hawi_clocks[] = { > [GCC_USB3_PRIM_PHY_PIPE_CLK_SRC] = &gcc_usb3_prim_phy_pipe_clk_src.clkr, > [GCC_VIDEO_AXI0_CLK] = &gcc_video_axi0_clk.clkr, > [GCC_VIDEO_AXI0C_CLK] = &gcc_video_axi0c_clk.clkr, > + /* > + * Maili-only clocks: NULL here to size the array to the highest Maili > + * clock index. > + */ > + [GCC_QUPV3_WRAP_5_S_AHB_CLK] = NULL, we have: --- common.c qcom_cc_really_probe(): ... cc->rclks = rclks; // desc->clks cc->num_rclks = num_clks; // desc->num_clks ... -> devm_of_clk_add_hw_provider(dev, qcom_cc_clk_hw_get, cc); and qcom_cc_clk_hw_get() has: if (idx >= cc->num_rclks) { pr_err("%s: invalid index %u\n", __func__, idx); return ERR_PTR(-EINVAL); } so I think this should be unnecessary Besides, is that new set of clocks actually unique to Maili, or is it bound to a QSPI usecase on the specific QUP? Konrad