From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com [209.85.210.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F2E0356A3E for ; Mon, 2 Feb 2026 23:06:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770073621; cv=none; b=Hqm+nqH50N0JZWzwh6TXXfYWmUibVIIr9eEps3FiBy8DiVMRbKD1gGYOmFbijhcwPpGVuUrl0PHYYqtO42/xZ9xqGfqOLtFEfDCoyA73kjdhzzxSFz1MXZuvas87x0anr5JVYLH6KX8KBAy7zitaDZcRseGfoEbAF6cwk2JDEzg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770073621; c=relaxed/simple; bh=0fH9YxT6el6nAOYunQ7GfUEIZKSKjYrlP/DUEJJpERI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ds+0JcAg4Tsltiv13fYdGmuXru5mmVgJrIjeIbUPLoc0cmYWpgiZwl+GckVn5KSCOw+2YAdNDOaMOWYvqUEeX4NoxYVkPgDqYuYx2o7TKBegPEvpRRQJ5KcrhqoRGavqWMChbhLjCux4gk1jABOlH0Jkx2hctrHxTRER7L2EOIk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=HyNXgr0p; arc=none smtp.client-ip=209.85.210.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="HyNXgr0p" Received: by mail-ot1-f42.google.com with SMTP id 46e09a7af769-7cfd9b898cdso3169925a34.2 for ; Mon, 02 Feb 2026 15:06:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1770073617; x=1770678417; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9W2tEIPpOemC2y1227Ea2S2cPiUPDeGonw5JxA3WiVo=; b=HyNXgr0p8Lqh4QKdYUiFrZMO/Q9ptuF/7B+nCMI9iJMxGV12JlTJvAJn/c+yIkpibR QZb18Bj6HyqnFcE+jtf5r4IvtpeM8Q/s39+4n5seWXr4ZE3XUDvgW0eLmfNvRlDMiiuL NUwqNa87309auo5peyiV76IsFvlrLcIIQlr9L1Ha2j3gsRcmIEdAW/iRvlr17pQUNlFP 5PP8W6AGkUz1ateALQgNhEcVwCTINynbGhM4OAKR0t4D/H1n05JsBgnfohtnvAyUERIX V20Ne7g27ESpSQlaAtyxhGpRwngRyHjXEFbCA738/r6L/v3+Bwu9laTdi96wrYCxsdsQ YxEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770073617; x=1770678417; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9W2tEIPpOemC2y1227Ea2S2cPiUPDeGonw5JxA3WiVo=; b=JtT8mxOcQCVeeuQtOWGLbCWrMCvyxkKwF3ff5N2nV/EWjPo8Xtu7WpjZMPQMH23YXX YjYIJovmBYcIhI88jERgoepkVLktN8hnPjEAghnbNVQ3NgsVWDm4SwdeXwCW5U9/13+t hyJNU+ncVZrcwq9BGZ+dQ09Zumqbypm+FTOr3gYor4WdFMvT+S6wut4zDD5HojC4NE6l vAsVfRKSFNhIeRYUzodY+SbI2s5DHF6QQ7T/b2H3F1r7PXOeKzy6Uqrk/3wnsDqKddMo 91T/dMxES22ICVA17jJ3XGKfbsVgosJdAXKZ0ZuO5Dtqd41QnSFlr50EULc98appyb4U FNUQ== X-Forwarded-Encrypted: i=1; AJvYcCWsMx0noQ6pg27aKN9LraGFZBNFNwvKnZ7Pt5NkR0xbpFH4l6QUQ8Yv7irOxwzkdITEhmFlXgubEke6yhQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwafWqsVGPRYu39ISJHaNkFfMF4ClJ1T1k2rgmDNiUPo1uS2yFU sRzazSuzKZja9AxnSKpUgSzkoF2KsNqRdCSYT9zWLjYTNUK14LKwFZgcZ+H9lprS5DI= X-Gm-Gg: AZuq6aL1s67cegCSVeaKdvgzXI7KZ8QIIl4OlEuHtzCNYqunR2IXw0hcjqnugdGOxeM W8VaOmfKUH0T644zO0VyOYWe7SgcN8mJHVpu0+w1owdoLYYLv/Bbm7RLsi4i1eP+o+Th/h8XOk5 LVf2RrGUY7YH9hfJz/LhYtAibLtHrY312Ylm065oFEBHXpTRDVbuMF9KacNbUzugUyUFNx8W4cR 6nypRcTQz/dT2/E8PlTVBOAG86PHkXscSskhBPOPlGDIpef6WJRZTrJQlbz3FijI8vSWu0CES3W C5nZMS1Yws3rhKo36VC7bDduhRHY780nNN3yI10hxEabBrS84ZI8/EfcXRUVvT14CoyMxpqKXCP lgt5zKBtRDE98cr7gLxo6In3jgI/aerazCw4QGMTV84uke+sRpJXx4DZqY9owd+6NX+MaWUWiAD mTk5qqjBn+VJ3/8IrNOWxd6tqQB/lA4DukbhJ+vF0hV5E7P/jZc7DkDCct3pOb X-Received: by 2002:a05:6830:6add:b0:7cf:e539:dcf0 with SMTP id 46e09a7af769-7d1a52974b0mr7884674a34.10.1770073617617; Mon, 02 Feb 2026 15:06:57 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:3695:6954:27c2:42ef? ([2600:8803:e7e4:500:3695:6954:27c2:42ef]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d18c67100fsm11635469a34.3.2026.02.02.15.06.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Feb 2026 15:06:57 -0800 (PST) Message-ID: <62d09f1c-9869-412a-a2ea-3be81ec13ede@baylibre.com> Date: Mon, 2 Feb 2026 17:06:56 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 next 2/5] iio: sca3000: switch IRQ handling to devm helpers To: Harshit Mogalapalli , Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Andrew Ijano , Antoniu Miclaus , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, error27@gmail.com, andriy.shevchenko@intel.com References: <20260202194033.627967-1-harshit.m.mogalapalli@oracle.com> <20260202194033.627967-3-harshit.m.mogalapalli@oracle.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260202194033.627967-3-harshit.m.mogalapalli@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/2/26 1:40 PM, Harshit Mogalapalli wrote: > Convert the threaded IRQ registration to devm_request_threaded_irq() so > that the probe and remove paths can drop manual freeing of irqs. > > No functionality change. > > Suggested-by: Andy Shevchenko > Signed-off-by: Harshit Mogalapalli > --- > v1->v2: Fix indentation in devm_request_threaded_irq() call[ Thanks to > Jonathan] > --- > drivers/iio/accel/sca3000.c | 25 ++++++++----------------- > 1 file changed, 8 insertions(+), 17 deletions(-) > > diff --git a/drivers/iio/accel/sca3000.c b/drivers/iio/accel/sca3000.c > index afe6ef61a53b..37ef724d5dc5 100644 > --- a/drivers/iio/accel/sca3000.c > +++ b/drivers/iio/accel/sca3000.c > @@ -1473,34 +1473,27 @@ static int sca3000_probe(struct spi_device *spi) > return ret; > > if (spi->irq) { > - ret = request_threaded_irq(spi->irq, > - NULL, > - &sca3000_event_handler, > - IRQF_TRIGGER_FALLING | IRQF_ONESHOT, > - "sca3000", > - indio_dev); > + ret = devm_request_threaded_irq(dev, spi->irq, NULL, > + &sca3000_event_handler, > + IRQF_TRIGGER_FALLING | IRQF_ONESHOT, > + "sca3000", > + indio_dev); > if (ret) > return ret; > } > ret = sca3000_clean_setup(st); > if (ret) > - goto error_free_irq; > + return ret; > > ret = sca3000_print_rev(indio_dev); > if (ret) > - goto error_free_irq; > + return ret; > > ret = iio_device_register(indio_dev); > if (ret) > - goto error_free_irq; > + return ret; > > return 0; Could return directly here already, but it gets cleaned up in a later patch, so its OK. Reviewed-by: David Lechner