RE: [PATCH v3] Bluetooth: btrtl: Set msft ext address filter quirk

[Hilda Wu <hildawu@realtek.com>]

Hi Paul,

Thanks for your feedback.
I will send the V4 and please check my comment as below. Thank you again.

Regards,
Hilda

-----Original Message-----
From: Paul Menzel <pmenzel@molgen.mpg.de> 
Sent: Thursday, August 29, 2024 2:14 PM
To: Hilda Wu <hildawu@realtek.com>
Cc: marcel@holtmann.org; luiz.dentz@gmail.com; linux-bluetooth@vger.kernel.org; linux-kernel@vger.kernel.org; alex_lu@realsil.com.cn; Max Chou <max.chou@realtek.com>; KidmanLee <kidman@realtek.com>
Subject: Re: [PATCH v3] Bluetooth: btrtl: Set msft ext address filter quirk


External mail.



Dear Hilda,


Thank you for your patch.

Am 29.08.24 um 05:46 schrieb Hilda Wu:
> For tracking multiple devices concurrently with a condition.
> The patch enables the HCI_QUIRK_USE_MSFT_EXT_ADDRESS_FILTER quirk on 
> RTL8852B controller.

Please add the controller name also to the commit message summary.

Updated in v4.

> The quirk setting is based on this commit.
> Commit 9e14606d8f38 ("Bluetooth: msft: Extended monitor tracking by 
> address filter")

… is based on commit 9e14606d8f38 ("Bluetooth: msft: Extended monitor tracking by address filter").

Updated in v4.

> With this setting, when a pattern monitor detects a device, this 
> feature issues an address monitor for tracking that device. Let the 
> original pattern monitor can keep monitor new devices.

Remove *can*?

Updated in v4.

Please paste possible Linux message before/after the commit into the commit message.

There will no messages after the commit.
Related Linux message is when using MSFT ext and turning on DEBUG log, the message shows when add or cancel an address filter when receiving a LE monitor device event.
DEBUG kernel: [ 5263.897298] Bluetooth: msft_monitor_device_evt() hci0: MSFT vendor event 0x02: handle 0x0000 state 1 addr c4:05:c4:05:00:00
DEBUG kernel: [ 5263.897306] Bluetooth: msft_add_address_filter() hci0: MSFT: Add device c4:05:c4:05:00:00 address filter

DEBUG kernel: [ 5324.981052] Bluetooth: msft_monitor_device_evt() hci0: MSFT vendor event 0x02: handle 0x0003 state 0 addr c4:05:c4:05:00:00
DEBUG kernel: [ 5324.982847] Bluetooth: msft_cancel_address_filter_sync() hci0: MSFT: Canceled device c4:05:c4:05:00:00 address filter

> Signed-off-by: Hilda Wu <hildawu@realtek.com>
> ---
> Change:
> v3: edit commit log and title
> v2: Add reference commit, update commit description
> ---
> ---
>   drivers/bluetooth/btrtl.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c 
> index 4c0f551a9975..2d95b3ea046d 100644
> --- a/drivers/bluetooth/btrtl.c
> +++ b/drivers/bluetooth/btrtl.c
> @@ -1308,6 +1308,7 @@ void btrtl_set_quirks(struct hci_dev *hdev, struct btrtl_device_info *btrtl_dev)
>                       btrealtek_set_flag(hdev, 
> REALTEK_ALT6_CONTINUOUS_TX_CHIP);
>
>               if (btrtl_dev->project_id == CHIP_ID_8852A ||
> +                 btrtl_dev->project_id == CHIP_ID_8852B ||
>                   btrtl_dev->project_id == CHIP_ID_8852C)
>                       set_bit(HCI_QUIRK_USE_MSFT_EXT_ADDRESS_FILTER, 
> &hdev->quirks);


Kind regards,

Paul