Re: [PATCH 5.15 000/244] 5.15.139-rc1 review

[Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>]

Hello Sasha and Greg,

On 16/11/23 7:27 pm, Sasha Levin wrote:
> On Thu, Nov 16, 2023 at 04:04:10PM +0530, Harshit Mogalapalli wrote:
>> Hi Greg,
>>
>> On 16/11/23 2:03 am, Greg Kroah-Hartman wrote:
>>> This is the start of the stable review cycle for the 5.15.139 release.
>>> There are 244 patches in this series, all will be posted as a response
>>> to this one.  If anyone has any issues with these being applied, please
>>> let me know.
>>>
>>> Responses should be made by Fri, 17 Nov 2023 20:34:45 +0000.
>>> Anything received after that time might be too late.
>>>
>>> The whole patch series can be found in one patch at:
>>>     https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.139-rc1.gz
>>> or in the git tree and branch at:
>>>     git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
>>> and the diffstat can be found below.
>>>
>>
>> As Florian pointed:
>>
>> I am also seeing build failure with perf, which is same as the 
>> previous cycle.
>>
>> BUILDSTDERR: util/evlist.c: In function 'evlist__add_aux_dummy':
>> BUILDSTDERR: util/evlist.c:266:31: error: implicit declaration of 
>> function 'evlist__dummy_event'; did you mean 'evlist__add_sb_event'? 
>> [-Werror=implicit-function-declaration]
>> BUILDSTDERR:   266 |         struct evsel *evsel = 
>> evlist__dummy_event(evlist);
>> BUILDSTDERR:       |                               ^~~~~~~~~~~~~~~~~~~
>> BUILDSTDERR:       |                               evlist__add_sb_event
>> BUILDSTDERR: util/evlist.c:266:31: error: initialization of 'struct 
>> evsel *' from 'int' makes pointer from integer without a cast 
>> [-Werror=int-conversion]
>>
>> I think we should drop:
>> 3dcc2e4843277 perf evlist: Avoid frequency mode for the dummy event
>> 4898cce349953 perf tools: Get rid of evlist__add_on_all_cpus()
>> a6157c9aa899a perf evlist: Add evlist__add_dummy_on_all_cpus()
> 
> Dropped, thanks!

I have reverted these locally and triggered tests on 5.15.139-rc1.

No problems seen on x86_64 and aarch64 with our testing.

Tested-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>

Thanks,
Harshit
>