From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50B49C4167B for ; Wed, 29 Nov 2023 19:16:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233252AbjK2TQY (ORCPT ); Wed, 29 Nov 2023 14:16:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231304AbjK2TQX (ORCPT ); Wed, 29 Nov 2023 14:16:23 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B054D5E for ; Wed, 29 Nov 2023 11:16:29 -0800 (PST) Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1r8Q2o-0003uT-2z; Wed, 29 Nov 2023 20:16:22 +0100 Message-ID: <62e767da-5e4f-4b92-a5c9-5d523896d68e@pengutronix.de> Date: Wed, 29 Nov 2023 20:16:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 2/2] arm64: boot: Support Flat Image Tree Content-Language: en-US To: Tom Rini Cc: Simon Glass , linux-arm-kernel@lists.infradead.org, Masahiro Yamada , lkml , U-Boot Mailing List , Catalin Marinas , Nathan Chancellor , Nick Terrell , Nicolas Schier , Will Deacon , linux-kbuild@vger.kernel.org, Pengutronix Kernel Team References: <20231129172200.430674-1-sjg@chromium.org> <20231129172200.430674-3-sjg@chromium.org> <30f32467-51ea-47de-a272-38e074f4060b@pengutronix.de> <20231129190220.GN2513409@bill-the-cat> From: Ahmad Fatoum In-Reply-To: <20231129190220.GN2513409@bill-the-cat> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Tom, On 29.11.23 20:02, Tom Rini wrote: > On Wed, Nov 29, 2023 at 07:59:00PM +0100, Ahmad Fatoum wrote: >> Hi, >> >> a few more comments after decompiling the FIT image: >> >> On 29.11.23 18:21, Simon Glass wrote: >>> + with fsw.add_node('kernel'): >>> + fsw.property_string('description', args.name) >>> + fsw.property_string('type', 'kernel_noload') >> >> The specification only says no loading done, but doesn't explain what it >> means for a bootloader to _not_ load an image. Looking into the U-Boot commit >> b9b50e89d317 ("image: Implement IH_TYPE_KERNEL_NOLOAD") that introduces this, >> apparently no loading means ignoring load and entry address? >> >> I presume missing load and entry is something older U-Boot versions >> were unhappy about? Please let me know if the semantics are as I understood, >> so I can prepare a barebox patch supporting it. > > So the matching side for this series in U-Boot is: > https://patchwork.ozlabs.org/project/uboot/list/?series=382849&state=* > > And in short, for IH_TYPE_KERNEL_NOLOAD we do our best to use it > in-place. For decompression we allocate some space to decompress to. Thanks. I am still curious why "kernel" couldn't have been used back then with missing entry and load address to arrive at the same result? Thanks, Ahmad -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |