From: "Jürgen Groß" <jgross@suse.com>
To: jiang.peng9@zte.com.cn
Cc: sstabellini@kernel.org, oleksandr_tyshchenko@epam.com,
xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
xu.xin16@zte.com.cn, yang.yang29@zte.com.cn
Subject: Re: [PATCH v2] xen/xenbus: fix W=1 build warning in xenbus_va_dev_error function
Date: Fri, 20 Jun 2025 11:50:08 +0200 [thread overview]
Message-ID: <62eb6d8a-7759-46b1-b06b-e7c6bc4f9a11@suse.com> (raw)
In-Reply-To: <20250620084104786r5xoR16_AmYZMJLnno3_Q@zte.com.cn>
[-- Attachment #1.1.1: Type: text/plain, Size: 800 bytes --]
On 20.06.25 02:41, jiang.peng9@zte.com.cn wrote:
> From: Peng Jiang <jiang.peng9@zte.com.cn>
>
> This patch fixes a W=1 format-string warning reported by GCC 12.3.0
> by annotating xenbus_switch_fatal() and xenbus_va_dev_error()
> with the __printf attribute. The attribute enables compile-time
> validation of printf-style format strings in these functions.
>
> The original warning trace:
> drivers/xen/xenbus/xenbus_client.c:304:9: warning: function 'xenbus_va_dev_error' might be
> a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
>
> Signed-off-by: Peng Jiang <jiang.peng9@zte.com.cn>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
PS: Next time please don't send another version of a patch as a reply,
but as a new email thread.
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3743 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
next prev parent reply other threads:[~2025-06-20 9:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-18 2:01 [PATCH] " jiang.peng9
2025-06-19 12:01 ` Jürgen Groß
2025-06-20 0:35 ` jiang.peng9
2025-06-20 0:41 ` [PATCH v2] " jiang.peng9
2025-06-20 9:50 ` Jürgen Groß [this message]
2025-06-21 6:11 ` jiang.peng9
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62eb6d8a-7759-46b1-b06b-e7c6bc4f9a11@suse.com \
--to=jgross@suse.com \
--cc=jiang.peng9@zte.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksandr_tyshchenko@epam.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
--cc=xu.xin16@zte.com.cn \
--cc=yang.yang29@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®