mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: robh+dt@kernel.org, liuwei@actions-semi.com,
	96boards@ucrobotics.com, devicetree@vger.kernel.org,
	daniel.thompson@linaro.org, amit.kucheria@linaro.org,
	hzhang@ucrobotics.com, bdong@ucrobotics.com,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, manivannanece23@gmail.com,
	Jeff Chen <jeff.chen@actions-semi.com>,
	"Thomas C. Liau" <thomas.liau@actions-semi.com>
Subject: Re: [PATCH 4/4] soc: actions: Fix help text in Kconfig for OWL_PM_DOMAINS
Date: Sun, 24 Jun 2018 15:28:30 +0200	[thread overview]
Message-ID: <62ef1835-8db9-f1e8-53b9-4cd74b5d416d@suse.de> (raw)
In-Reply-To: <20180411164036.8046-5-manivannan.sadhasivam@linaro.org>

Hi Mani,

Am 11.04.2018 um 18:40 schrieb Manivannan Sadhasivam:
> OWL_PM_DOMAINS is being used by 3 SoCs of OWL family. This fixes
> the wording to use family name OWL instead of SoC name S500.
> 
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
>  drivers/soc/actions/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/actions/Kconfig b/drivers/soc/actions/Kconfig
> index 9d68b5a771c3..26c3155d3738 100644
> --- a/drivers/soc/actions/Kconfig
> +++ b/drivers/soc/actions/Kconfig
> @@ -10,7 +10,7 @@ config OWL_PM_DOMAINS
>  	select PM_GENERIC_DOMAINS
>  	help
>  	  Say 'y' here to enable support for Smart Power System (SPS)
> -	  power-gating on Actions Semiconductor S500 SoC.
> +	  power-gating on Actions Semiconductor OWL SoCs.

Thanks for spotting this. However, repeating OWL from the title (which I
think should be spelled Owl in free text, given that I also read Falcon
as another bird for GT9 [*]) does not seem too helpful for people
wondering whether or not to enable the driver.

I would much rather do a patch updating this to "S500 and S700 SoCs"
with Fixes and then just add S900 as part of your preceding patch.

Regards,
Andreas

[*] https://androidpc.es/blog/2015/11/10/actions-gt7/

>  	  If unsure, say 'n'.
>  
>  endif
> 


-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)

  reply	other threads:[~2018-06-24 13:28 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-11 16:40 [PATCH 0/4] Add Actions Semi S900 SPS support Manivannan Sadhasivam
2018-04-11 16:40 ` [PATCH 1/4] dt-bindings: power: Add Actions Semi S900 SPS Manivannan Sadhasivam
2018-04-16 18:48   ` Rob Herring
2018-06-24 13:04   ` Andreas Färber
2018-06-26 16:41     ` Manivannan Sadhasivam
2018-06-27 14:57       ` Daniel Thompson
2018-06-27 15:05         ` Andreas Färber
2018-06-27 15:10         ` Manivannan Sadhasivam
2018-04-11 16:40 ` [PATCH 2/4] arm64: dts: actions: Add S900 SPS node Manivannan Sadhasivam
2018-06-24 13:06   ` Andreas Färber
2018-04-11 16:40 ` [PATCH 3/4] soc: actions: sps: Add S900 power domains Manivannan Sadhasivam
2018-06-24 13:07   ` Andreas Färber
2018-09-30 15:46     ` Andreas Färber
2018-04-11 16:40 ` [PATCH 4/4] soc: actions: Fix help text in Kconfig for OWL_PM_DOMAINS Manivannan Sadhasivam
2018-06-24 13:28   ` Andreas Färber [this message]
2018-06-24 14:01     ` [PATCH] soc: actions: Update SPS help text for S700 Andreas Färber
2018-09-22 20:11       ` Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=62ef1835-8db9-f1e8-53b9-4cd74b5d416d@suse.de \
    --to=afaerber@suse.de \
    --cc=96boards@ucrobotics.com \
    --cc=amit.kucheria@linaro.org \
    --cc=bdong@ucrobotics.com \
    --cc=daniel.thompson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hzhang@ucrobotics.com \
    --cc=jeff.chen@actions-semi.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liuwei@actions-semi.com \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=manivannanece23@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=thomas.liau@actions-semi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®