From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11848271A6D for ; Wed, 11 Mar 2026 13:38:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773236323; cv=none; b=g6F7nFC8ACl4NoisB2h8yUm+8D1Z05mLJWZJDWHV/angi0WRCt2EvOh+9vO7bmuPQbxcAZ8zmbbWK1x84I72Psp1TgK/255hOzRVfrM8ft5bxE/pQ/JDzqTdIRMk63jmmOC1cP3CBtc09ECEPWT5sAJcAA+94XAASbDaK9wRqaM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773236323; c=relaxed/simple; bh=e+oVFlQidjUShB8VLapFDhc604EtMyJ7pK0KAypuqx8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aD8YM0JGXyPGI8oTAXc6wdwPAzzXjLHA5b4PhHLEDg1WXToQDhyfJNkiXTMZYoXD6wSIrhkdfQtbaTt1Dwb62/CPxkrFBQBIuE94Fe0+9t24nIO4N7t3CctaG82kB9zCrW2FZw2TA8MTHweSzB5+I6BsjOv4dlqXtPNCqlCN1Q4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Wa9Sx61B; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KrRL7osn; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Wa9Sx61B"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KrRL7osn" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62BD2S94508369 for ; Wed, 11 Mar 2026 13:38:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= TirY6eh2ZP0RoPYvgHG3610zhEOa/tUuPjax27g6Tzw=; b=Wa9Sx61BbmxXnihE FRaNpV4V+FOCzZkHFGespdxrvzEOTg0X7Lgcwg1DVfIUUthvlHe9r3mkBXameS1d oSrYWAQ7XgA2aDpb46/lSJSIHaiMJbDor+gz8WvK+wTOpg6k2TFwR0tCiiJiPYNS IzTFv1FpOXDRt9FGl00hMJwLK9zhRq7KGhDBhx9v+ReP2Dk8rC0ik/HfqsJi11RR o6ULhKHyHWfrJBlslhdCmIDU7Rhhm0o1A7xHMuC0BOaZLaYmP+IiVEe1mOLyu4LE Hyosj8V0UVuGccZLTXVlBDviS0LMRmzKbxi+1rr13OpKf7hi/Wcx65eh8cKKog4E RJ8X7Q== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ctppam280-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 11 Mar 2026 13:38:40 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-89a01982dc5so73817976d6.3 for ; Wed, 11 Mar 2026 06:38:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773236320; x=1773841120; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TirY6eh2ZP0RoPYvgHG3610zhEOa/tUuPjax27g6Tzw=; b=KrRL7osnsFuetk4IlkzGNlu8CVg4YKbubSb9e8piuxAbcTNE+L+jghQFye9jGO+2hy CcTdoqgSv1ZgnDywNj2xNnH9L9rgI0QqC3JvldtVJkvjOlVa8YgQod2CSKkPSZrob2l8 jmPmnbr7bXIbhdTFK1cqOQMUlRO00iDh+WjWhQ3wSsuN4pSMLsbt1WibGCvDMQVNgZNt B7+85WIW9DXL4TWeSKqwsnGE7AUVXW/0RIcgMHodJ9UaOfS047ULOum5Jj1WkO/9JTck pHxHRlsxypFBRc6aK7kv4Q6W4Kyy3Gf9Z0SXBjCIauVi6mxUWY0pgVynHnce23mYsD4S guag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773236320; x=1773841120; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TirY6eh2ZP0RoPYvgHG3610zhEOa/tUuPjax27g6Tzw=; b=HMCsrG+V8GT3a/9TRF6PcQVyLdpVsP5UuCEClQ3zBJO2dCG152gBgcHVhmjK9DDceG N8ahkj9rdKYW3vpXzKGIzCX2NIycgRC5xBXgoQgqOvjTEA4lsTXZudMa7/XHRH+iflM9 9WEa47iBBSWpwqE24Oj72Xw/2Tdtrq+nRYsfq/ugDZoNCoYKJRquuNOXengmguoEnNBZ vnVBRnY1EBvGzagIHe85TAg55g/6V0clvrT2pK0UkRvh7CKJPu7ui9unZz+uU1o2ITpB RkBf98yt1DEMuQzXGCZFOpq/y1P7I2zEEVcsv7c7+q01hy2x5dVaxJ1ybTES0L6odjY9 wGkA== X-Forwarded-Encrypted: i=1; AJvYcCVVHdQB/2MiXC6aD3KwbKlKLqincWAu+5NflFqD0rEOpSZTLdx4mmWea5jwJWT11spx628GTiOgk5xHlI4=@vger.kernel.org X-Gm-Message-State: AOJu0YxroBGF49oD7HM6CFYLuiJKb5epcD18VY5jsgLHEQcmQP0NQKci DNIDFZTTfTgZpTitAbt2u3zNwRvlgxY6UbuK407aF+eu6duoxv69/HR2jsQJ4ySK06vTJJTbU3L jL+UqOukyN6mueCxXDWItn3zsMDiYzGY7Q9hco3PZFdry8o38loKkvqsK0Qbo02pVHC8= X-Gm-Gg: ATEYQzyQWCVK/muZqA7YxW3vLCvcTDGzkEr3Tjm8yxBscI8rWFDeXEqK9fwFsNgJmid kuOept/SFRCy2jMELwIWYUEtuoR4ywKPhMGsV97mBQJhwiOiC144U0iisxjCgokdzePR+Bp9P4H 2sPXnQfjsGZrUX04M6G0AGHYZl/XXCLIrYlyriFpCGE1atPPPKA9iX/a2YgkX5N3Qtt/bt26ukd thnPzS2vcVSNWcKBsTropTj1DV+2QPj/0ydelDpvp38730TeS1uVWYmKTwdkLBPFLrRX464lHg1 EXuNPzQKZWhVdjn/B0bwLsfiLt1ef11s+owacr/53MfjQ7YRN0YgGkLRvCqSrfv2a3bGV+nzXrr KtW6auzmwWbKAA2/25va0xMLoJ3Bq8SZNmSEh7KQJ2pg0Y5oZGJHBvdfn1DMWtMJCiju9L4nPEZ xTiqE= X-Received: by 2002:a05:620a:28cc:b0:8cd:8411:a5cb with SMTP id af79cd13be357-8cda19cc111mr244082185a.3.1773236319872; Wed, 11 Mar 2026 06:38:39 -0700 (PDT) X-Received: by 2002:a05:620a:28cc:b0:8cd:8411:a5cb with SMTP id af79cd13be357-8cda19cc111mr244078785a.3.1773236319446; Wed, 11 Mar 2026 06:38:39 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6631503c5b2sm560878a12.16.2026.03.11.06.38.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Mar 2026 06:38:38 -0700 (PDT) Message-ID: <62f0af5c-e647-40a6-a174-3cb5d51e4232@oss.qualcomm.com> Date: Wed, 11 Mar 2026 14:38:35 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/6] arm64: dts: qcom: msm8953-flipkart-rimob: Enable touchscreen To: Dmitry Baryshkov Cc: cristian_ci@protonmail.com, Neil Armstrong , Jessica Zhang , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org References: <20260308-rimob-new-features-v1-0-aa2c330572c0@protonmail.com> <20260308-rimob-new-features-v1-5-aa2c330572c0@protonmail.com> <6ddgxby2wzaa7mfbc64a4ld2rdbo6427csw6blzg5alstvkfv3@usfqftgctnzs> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: Cb_0YnN0_YGuMLXmRqf0anvKF3Wo85wN X-Authority-Analysis: v=2.4 cv=D7BK6/Rj c=1 sm=1 tr=0 ts=69b17060 cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=sfOm8-O8AAAA:8 a=tI4-1GpOe9AOYUiOV_AA:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 a=TvTJqdcANYtsRzA46cdi:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzExMDExNSBTYWx0ZWRfX0MT20UKGhCTW Tsj27VpPy8wSOuBZiL+llQ/6A4K6QWoSWdQYyqeNZ2FGBqVWdjenkrbAPDtQ3jjSW+wsrNhM606 EV68Mo+lrvrZCozgo3AXmG0AMODm4ViyeEg9KhxUr161nyiUyFpCsssZ+Vcw5RSU3W+pcIzeL99 4rJdSkyOLeTYCEfvCVZFWKKOyr1zgDOLFKsQGu5yx8KfF/NzOGveS3cX4v+r4RRkuzEVqmnCJl4 h4F0qh5Xb2OzCZmi1C/HMcFP/XI4AriYHt0oAS+N0RrS5tdtexeP23scWH9+V2jVjPRiSZfVBQ/ GPBHASkWIgsXH0GavmMcZh9W199yXS9xfn+Vh9Cgwox3Od8HW7MYow3kofVmrGgUeE+gvcClOHd +OkdKaS9bcckZwzXi7EbMaCV2B7I3D9MXqGXYZn7T32NfmJEpSqikkejHstXHzh1BA/IIzEZEWB b+0se/+IQ3NDDHLlxCg== X-Proofpoint-ORIG-GUID: Cb_0YnN0_YGuMLXmRqf0anvKF3Wo85wN X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-11_01,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 impostorscore=0 spamscore=0 bulkscore=0 malwarescore=0 priorityscore=1501 clxscore=1015 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603110115 On 3/11/26 2:16 PM, Dmitry Baryshkov wrote: > On Wed, Mar 11, 2026 at 01:47:48PM +0100, Konrad Dybcio wrote: >> On 3/10/26 11:49 PM, Dmitry Baryshkov wrote: >>> On Tue, Mar 10, 2026 at 02:08:40PM +0100, Konrad Dybcio wrote: >>>> On 3/8/26 4:52 PM, Cristian Cozzolino via B4 Relay wrote: >>>>> From: Cristian Cozzolino >>>>> >>>>> This device uses a Goodix GT5688 touch controller, connected to i2c_3. >>>>> Add it to the device tree. >>>>> >>>>> Signed-off-by: Cristian Cozzolino >>>>> --- >>>>> .../arm64/boot/dts/qcom/msm8953-flipkart-rimob.dts | 32 ++++++++++++++++++++++ >>>>> 1 file changed, 32 insertions(+) >>>>> >>>>> diff --git a/arch/arm64/boot/dts/qcom/msm8953-flipkart-rimob.dts b/arch/arm64/boot/dts/qcom/msm8953-flipkart-rimob.dts >>>>> index 7b2849405462..709ea6fc9fbb 100644 >>>>> --- a/arch/arm64/boot/dts/qcom/msm8953-flipkart-rimob.dts >>>>> +++ b/arch/arm64/boot/dts/qcom/msm8953-flipkart-rimob.dts >>>>> @@ -94,6 +94,31 @@ &hsusb_phy { >>>>> status = "okay"; >>>>> }; >>>>> >>>>> +&i2c_3 { >>>>> + status = "okay"; >>>>> + >>>>> + touchscreen@5d { >>>>> + compatible = "goodix,gt5688"; >>>>> + reg = <0x5d>; >>>>> + >>>>> + interrupts-extended = <&tlmm 65 IRQ_TYPE_LEVEL_LOW>; >>>> >>>> interrupts *and* irq-gpios sounds wrong.. and I think the driver doesn't >>>> even consume the former. Trying to read through some of that, I think >>> >>> I think you need both, take a look, there are enough users of >>> ts->gpiod_int. >> >> I said irq-gpios was necessary, interrupts is not. The only retrieval >> happens through: >> >> if (soc_intel_is_cht() && ts->gpio_count == 2 && ts->gpio_int_idx != -1) { >> irq = acpi_dev_gpio_irq_get(ACPI_COMPANION(dev), 0); >> if (irq > 0 && irq != ts->client->irq) { >> dev_warn(dev, "Overriding IRQ %d -> %d\n", ts->client->irq, irq); >> ts->client->irq = irq; >> } >> } > > static int goodix_request_irq(struct goodix_ts_data *ts) > { > if (!ts->client->irq) > return 0; > > return devm_request_threaded_irq(&ts->client->dev, ts->client->irq, > NULL, goodix_ts_irq_handler, > ts->irq_flags, ts->client->name, ts); > } > > I thought that i2c_client->irq is handled by the core. Ohhhh that explains things Cristian, please ignore my request to remove it then Konrad