From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1B72CCA479 for ; Thu, 7 Jul 2022 11:49:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235090AbiGGLt4 (ORCPT ); Thu, 7 Jul 2022 07:49:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235072AbiGGLty (ORCPT ); Thu, 7 Jul 2022 07:49:54 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3FA3633357; Thu, 7 Jul 2022 04:49:53 -0700 (PDT) Received: from dggpemm500024.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4LdvkZ41J6zTggP; Thu, 7 Jul 2022 19:46:14 +0800 (CST) Received: from dggpemm500019.china.huawei.com (7.185.36.180) by dggpemm500024.china.huawei.com (7.185.36.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 7 Jul 2022 19:49:51 +0800 Received: from [10.67.109.184] (10.67.109.184) by dggpemm500019.china.huawei.com (7.185.36.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 7 Jul 2022 19:49:51 +0800 Subject: Re: [PATCH bpf-next v3 4/6] libbpf: Unify memory address casting operation style To: Daniel Borkmann , , , , CC: Alexei Starovoitov , Andrii Nakryiko , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Luke Nelson , Xi Wang , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Paul Walmsley , Palmer Dabbelt , Albert Ou References: <20220530092815.1112406-1-pulehui@huawei.com> <20220530092815.1112406-5-pulehui@huawei.com> From: Pu Lehui Message-ID: <62f154e1-5ffb-3f7b-adc6-766cb29a18b0@huawei.com> Date: Thu, 7 Jul 2022 19:49:51 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.109.184] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm500019.china.huawei.com (7.185.36.180) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/5/31 5:03, Daniel Borkmann wrote: > On 5/30/22 11:28 AM, Pu Lehui wrote: >> The members of bpf_prog_info, which are line_info, jited_line_info, >> jited_ksyms and jited_func_lens, store u64 address pointed to the >> corresponding memory regions. Memory addresses are conceptually >> unsigned, (unsigned long) casting makes more sense, so let's make >> a change for conceptual uniformity. >> >> Signed-off-by: Pu Lehui >> --- >>   tools/lib/bpf/bpf_prog_linfo.c | 9 +++++---- >>   1 file changed, 5 insertions(+), 4 deletions(-) >> >> diff --git a/tools/lib/bpf/bpf_prog_linfo.c >> b/tools/lib/bpf/bpf_prog_linfo.c >> index 5c503096ef43..7beb060d0671 100644 >> --- a/tools/lib/bpf/bpf_prog_linfo.c >> +++ b/tools/lib/bpf/bpf_prog_linfo.c >> @@ -127,7 +127,8 @@ struct bpf_prog_linfo *bpf_prog_linfo__new(const >> struct bpf_prog_info *info) >>       prog_linfo->raw_linfo = malloc(data_sz); >>       if (!prog_linfo->raw_linfo) >>           goto err_free; >> -    memcpy(prog_linfo->raw_linfo, (void *)(long)info->line_info, >> data_sz); >> +    memcpy(prog_linfo->raw_linfo, (void *)(unsigned >> long)info->line_info, >> +           data_sz); > > Took in patch 1-3, lgtm, thanks! My question around the cleanups in > patch 4-6 ... > there are various other such cases e.g. in libbpf, perhaps makes sense > to clean all > of them up at once and not just the 4 locations in here. > sorry for reply so late, I will take this soon. > Thanks, > Daniel > .