mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Yuriy.Kolerov@synopsys.com" <Yuriy.Kolerov@synopsys.com>,
	Vlad Zakharov <Vladislav.Zakharov@synopsys.com>,
	"linux-snps-arc@lists.infradead.org" 
	<linux-snps-arc@lists.infradead.org>
Subject: Re: [PATCH] ARCv2: intc: untangle SMP, MCIP and IDU
Date: Thu, 6 Oct 2016 10:10:47 -0700	[thread overview]
Message-ID: <62f431fd-8c66-143b-2129-a1b996a0a98c@synopsys.com> (raw)
In-Reply-To: <1475745033.3301.5.camel@synopsys.com>

On 10/06/2016 02:10 AM, Alexey Brodkin wrote:
>> +struct mcip_bcr {
>> +#ifdef CONFIG_CPU_BIG_ENDIAN
>> +		unsigned int pad3:8,
>> +			     idu:1, llm:1, num_cores:6,
>> +			     iocoh:1,  gfrc:1, dbg:1, pad2:1,
>> +			     msg:1, sem:1, ipi:1, pad:1,
>> +			     ver:8;
>> +#else
>> +		unsigned int ver:8,
>> +			     pad:1, ipi:1, sem:1, msg:1,
>> +			     pad2:1, dbg:1, gfrc:1, iocoh:1,
>> +			     num_cores:6, llm:1, idu:1,
>> +			     pad3:8;
>> +#endif
>> +};
> 
> IMHO we should stop using this kind of constructions because they
> are ugly and what's more important not portable.

They are ugly I agree - but not portable - really ? The whole point is to make
this work on BE w/o changing the src code - this details remains hidden in an
obscure header.

> Even though we have it now working for both LE and BE configurations
> it won't work for 64-bit cores. We'll need to add ifdeffed 32-bit paddings
> then which will make that construction even more ugly.

When we get to 64-bit a lot things would have to change - and possibly the aux reg
layout. There is no way to make this exact code 64-bit ready !


> Probably that's not the right patch to address my complaint but just
> to reiterate this topic once again and think about clean-up series on
> that regard :)

Patches are welcome ;-)

-Vineet

  reply	other threads:[~2016-10-06 17:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-05 20:39 Vineet Gupta
2016-10-06  9:10 ` Alexey Brodkin
2016-10-06 17:10   ` Vineet Gupta [this message]
2016-10-07 17:31     ` Alexey Brodkin
2016-10-07 21:39       ` Vineet Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=62f431fd-8c66-143b-2129-a1b996a0a98c@synopsys.com \
    --to=vineet.gupta1@synopsys.com \
    --cc=Alexey.Brodkin@synopsys.com \
    --cc=Vladislav.Zakharov@synopsys.com \
    --cc=Yuriy.Kolerov@synopsys.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-snps-arc@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®