From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4733C4321E for ; Wed, 12 Oct 2022 11:14:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229626AbiJLLOE (ORCPT ); Wed, 12 Oct 2022 07:14:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229470AbiJLLNm (ORCPT ); Wed, 12 Oct 2022 07:13:42 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 961C7C1D9D; Wed, 12 Oct 2022 04:13:41 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3D620D6E; Wed, 12 Oct 2022 04:13:47 -0700 (PDT) Received: from [10.32.36.24] (e121896.Emea.Arm.com [10.32.36.24]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 893053F792; Wed, 12 Oct 2022 04:13:38 -0700 (PDT) Message-ID: <62f485df-4f5e-64a2-1294-6e162de25556@arm.com> Date: Wed, 12 Oct 2022 12:13:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] perf: Fix "Track with sched_switch" test by not printing warnings in quiet mode To: linux-perf-users@vger.kernel.org, acme@kernel.org, namhyung@kernel.org Cc: linux-kernel@vger.kernel.org, Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter References: <20221012111025.30609-1-james.clark@arm.com> Content-Language: en-US From: James Clark In-Reply-To: <20221012111025.30609-1-james.clark@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/10/2022 12:10, James Clark wrote: > Especially when CONFIG_LOCKDEP and other debug configs are enabled, > Perf can print the following warning when running the "Track with > sched_switch" test: Oops got the wrong test name here and in the title. Should be "kernel lock contention analysis test" > > Warning: > Processed 1378918 events and lost 4 chunks! > > Check IO/CPU overload! > > Warning: > Processed 4593325 samples and lost 70.00%! > > The test already supplies -q to run in quiet mode, so extend quiet mode > to perf_stdio__warning() and also ui__warning() for consistency. > > This fixes the following failure due to the extra lines counted: > > perf test "lock cont" -vvv > > 82: kernel lock contention analysis test : > --- start --- > test child forked, pid 3125 > Testing perf lock record and perf lock contention > [Fail] Recorded result count is not 1: 9 > test child finished with -1 > ---- end ---- > kernel lock contention analysis test: FAILED! > > Fixes: ec685de25b67 ("perf test: Add kernel lock contention test") > Cc: Namhyung Kim > Signed-off-by: James Clark > --- > tools/perf/ui/util.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/tools/perf/ui/util.c b/tools/perf/ui/util.c > index 689b27c34246..1d38ddf01b60 100644 > --- a/tools/perf/ui/util.c > +++ b/tools/perf/ui/util.c > @@ -15,6 +15,9 @@ static int perf_stdio__error(const char *format, va_list args) > > static int perf_stdio__warning(const char *format, va_list args) > { > + if (quiet) > + return 0; > + > fprintf(stderr, "Warning:\n"); > vfprintf(stderr, format, args); > return 0; > @@ -45,6 +48,8 @@ int ui__warning(const char *format, ...) > { > int ret; > va_list args; > + if (quiet) > + return 0; > > va_start(args, format); > ret = perf_eops->warning(format, args);