From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA4DBC83F3F for ; Mon, 4 Sep 2023 10:15:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237448AbjIDKPt (ORCPT ); Mon, 4 Sep 2023 06:15:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229923AbjIDKPr (ORCPT ); Mon, 4 Sep 2023 06:15:47 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BB3F1B4 for ; Mon, 4 Sep 2023 03:15:44 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-31768ce2e81so1041800f8f.1 for ; Mon, 04 Sep 2023 03:15:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693822543; x=1694427343; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YTdHOgrL8joAFyrmUnJ3WmRGjutDtwn1KMWzUgkG9XM=; b=PV+43A8glGk9uJK/hIkEMFAsj2rgZMruWU1sLs7KeELCEF/9hmLCjfykjwY5zTHNd1 kvTb9FUJhU9Lmv2RKzd7IsK24A3hoNphiD8P5xDAHa6XE0j3xMDc3awN7vdgXHB0OW2n 3Ye4h3/qLEsiPJytL+8IePQWxLeJHypoWbJBVB2bOKCAYm783z1Mkhu2Mv16YHZMCOix 8yP5h4Dvww9JibfjVpqKGmVyZBkdCpkWQZ3pWrHw0jenGpltQ9tqpCqTFObLA3KfIgru C0iMKKXulkEsZlr80OV98rW2UGNMZMBS7SMpViOcXdjzKw8lLlkee1Kvt8MQsCLTa7no LFlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693822543; x=1694427343; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YTdHOgrL8joAFyrmUnJ3WmRGjutDtwn1KMWzUgkG9XM=; b=b4/1I2KGJvmDQVdsbs3MVjBq+1eGMvMPqKFajwLQA57ceGeHkn81O2NEmn3Z41q1HL sEKuhSU3sjKXV5SwnrLgAXdNbkC7Y9/VxrxV2rA8AghlrrCKIlEZepKdTFz6XFpe9PXl VvKNN0pSVf6Wt1GNedD9L9szoS+l5jgHHeS0ipRJLIZpoEiBu7lxGCBvZFZCjIM50NlK f7dFIIYhJ/KuOLVlB6zfa8Z/JKZrfT+TcAavBBsfvBvfnSP1nuw0coZ6t82QvIh+RniJ mZfHYyDy37oE5CUebB524HBcKPDGCk9C6R625WNBrRCU1izqbCPhqRxnRb0ipwuZ4bKx bJvA== X-Gm-Message-State: AOJu0YxjlwyHUZnpy4WTTonZHEc7G1NXWJwwdMsPJDViYzH1pfwdEDaV oWoZeqWX2d8HhmInQ0iZalCZGA== X-Google-Smtp-Source: AGHT+IGc7nbyEo5kfIQp2Sldm+lS8fxJnYAwJm9zglze8escvSipt5lNYGHeChqkfAyqH82jFZUrjA== X-Received: by 2002:adf:e94a:0:b0:313:e8b6:1699 with SMTP id m10-20020adfe94a000000b00313e8b61699mr6200965wrn.55.1693822543031; Mon, 04 Sep 2023 03:15:43 -0700 (PDT) Received: from [192.168.0.162] (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id z12-20020adff1cc000000b0031ddf6cc89csm13953870wro.98.2023.09.04.03.15.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Sep 2023 03:15:42 -0700 (PDT) Message-ID: <62f78aac-c1e4-018c-93c2-4dac1ec7c688@linaro.org> Date: Mon, 4 Sep 2023 11:15:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 07/15] media: qcom: camss: Capture VFE CSID dependency in a helper function Content-Language: en-US To: Laurent Pinchart Cc: rfoss@kernel.org, todor.too@gmail.com, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, sakari.ailus@linux.intel.com, andrey.konovalov@linaro.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230823104444.1954663-1-bryan.odonoghue@linaro.org> <20230823104444.1954663-8-bryan.odonoghue@linaro.org> <20230828184716.GM14596@pendragon.ideasonboard.com> <9fb41649-b4fb-d652-3207-7c8ff8b32f24@linaro.org> <20230828194010.GF17083@pendragon.ideasonboard.com> From: Bryan O'Donoghue In-Reply-To: <20230828194010.GF17083@pendragon.ideasonboard.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/08/2023 20:40, Laurent Pinchart wrote: > On Mon, Aug 28, 2023 at 08:37:44PM +0100, Bryan O'Donoghue wrote: >> On 28/08/2023 19:47, Laurent Pinchart wrote: >>> Hi Bryan, >>> >>> Thank you for the patch. >>> >>> On Wed, Aug 23, 2023 at 11:44:36AM +0100, Bryan O'Donoghue wrote: >>>> From sdm845 onwards we need to ensure the VFE is powered on prior to >>>> switching on the CSID. >>> >>> Based on the discussions with Konrad in the mail thread, I would record >>> here the reason for this requirement. >>> >>> What happens if you unconditionally power up the VFE prior to switching >>> the CSID on ? Will this break something on platforms older than SDM845 ? >> >> vfe->power_count will bump and you will be fine. > > Then maybe that would be a simpler solution than having a > device-specific power sequence ? > So, this works. I'll send out a patch based on this suggestion. --- bod