From: Logan Gunthorpe <logang@deltatee.com>
To: Runyu Xiao <runyu.xiao@seu.edu.cn>, Christoph Hellwig <hch@lst.de>
Cc: Breno Leitao <leitao@debian.org>,
Andreas Hindborg <a.hindborg@kernel.org>,
Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <kch@nvidia.com>,
Keith Busch <kbusch@kernel.org>,
"Martin K. Petersen" <mkp@kernel.org>,
Lee Duncan <lduncan@suse.com>, Hannes Reinecke <hare@suse.com>,
Nicholas Bellinger <nab@linux-iscsi.org>,
linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org,
target-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, Jianhao Xu <jianhao.xu@seu.edu.cn>
Subject: Re: [PATCH v6 3/4] nvmet: avoid recursive configfs open for passthru
Date: Mon, 28 Sep 2026 09:50:05 -0600 [thread overview]
Message-ID: <62fbc3dc-421e-40f2-8f9e-d28a706cf64d@deltatee.com> (raw)
In-Reply-To: <20260926092148.128937-4-runyu.xiao@seu.edu.cn>
On 2026-09-26 03:21, Runyu Xiao wrote:
> nvmet_passthru_enable_store() runs as a configfs store callback while
> configfs holds the item frag_sem. Passthru enable used filp_open() on the
> configured controller path, so a path into configfs could re-enter
> __configfs_open_file() and try to acquire the same semaphore again.
>
> Use configfs_file_open() so the path is resolved before opening,
> configfs-backed paths are rejected, and the resolved path is opened with
> file_open_root() while retaining the normal open-time permission and
> security checks.
>
> Fixes: cae5b01a2afc ("nvmet: introduce the passthru configfs interface")
> Cc: stable@vger.kernel.org
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Assisted-by: LLM Codex
> Signed-off-by: Runyu Xiao <runyu.xiao@seu.edu.cn>
The problem and solution make sense to me, thanks.
Reviewed-by: Logan Gunthorpe <logang@deltataee.com>
next prev parent reply other threads:[~2026-09-28 15:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-26 9:21 [PATCH v6 0/4] nvmet: avoid recursive configfs open Runyu Xiao
2026-09-26 9:21 ` [PATCH v6 1/4] fs: configfs: add helpers for opening non-configfs paths Runyu Xiao
2026-09-26 9:21 ` [PATCH v6 2/4] nvmet: avoid recursive configfs open for file-backed namespaces Runyu Xiao
2026-09-26 9:21 ` [PATCH v6 3/4] nvmet: avoid recursive configfs open for passthru Runyu Xiao
2026-09-28 15:50 ` Logan Gunthorpe [this message]
2026-09-26 9:21 ` [PATCH v6 4/4] scsi: target: pin db_root for metadata writes Runyu Xiao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62fbc3dc-421e-40f2-8f9e-d28a706cf64d@deltatee.com \
--to=logang@deltatee.com \
--cc=a.hindborg@kernel.org \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=jianhao.xu@seu.edu.cn \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=lduncan@suse.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mkp@kernel.org \
--cc=nab@linux-iscsi.org \
--cc=runyu.xiao@seu.edu.cn \
--cc=sagi@grimberg.me \
--cc=stable@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®