From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E72C23ABBE for ; Tue, 28 Oct 2025 14:57:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761663430; cv=none; b=Zrj1MUJNW+LTtaeG5QUzr06kM15x1MPHHiHLNKguFne75cBKjbo1JQxX0ncZq3RPA3AXMDuVkiDGWJP4FE/eu48rZ8IRwwviCfL4lgLY1nUk2oQY3dSTZoLjA0oP8sfF9zFdT4N3oaqnCfEJrWH/FFUdzBZEdv/ZVfjCwZ1LzZw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761663430; c=relaxed/simple; bh=pRY4+GGhGf/5nLNZrRYoTRzXWCb0qRy5AHjVl+G2awk=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=r/UySu7JDFXu3ZaxplAk3RopGr7z/dDnYIDt8GgCcVfjLOT9Y1EPVpMCn/HV0rbNDqZg0d9JZPNDSYxTG0YvKugYBpl2BqiZPb3gMx62O0gEpYBGJl1PNt/KhWAXZ1rHmGGjAadJZ4TB5ED4nOZrIruJ+DXZYZrvGG3/bEIIE98= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=VUmkSaoK; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="VUmkSaoK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1761663424; bh=pRY4+GGhGf/5nLNZrRYoTRzXWCb0qRy5AHjVl+G2awk=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=VUmkSaoKTS+yPKGuGBcHWonNmB2/Ng+5wsj2Anc+azB5ShC5mZQOL/6/TF73VN2Po vKvHn1Jdx3EIMnm+NgAKueYwBaYSbvg+Z4K5yAVq0E8zbXHxzgi7GjJXOhTV88wqiw bFoshICpvlhba+h6cRZKSdBC2AnpVZm5LsXP3FyCDs0R9MdnXMo+fiEp3A5kSjK8Nu K/WBIKc4F4A07dZtENez/rMgd8tj5Go7tD8nr4Ho2PfTg80yQbkiJno/we/Z0X+4Yx QXhAKVBuyphmdyyiAZA78AWxYIlsgiOHW05+MufYz5POsFyiW0AlG/8pH8uZ6Kgie6 +NXOdd6K4u7Bg== Received: from [192.168.1.90] (unknown [82.79.138.145]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id 04CD317E139C; Tue, 28 Oct 2025 15:57:03 +0100 (CET) Message-ID: <63003a7e-8d3d-433a-8a44-54fe8740bc3a@collabora.com> Date: Tue, 28 Oct 2025 16:57:03 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/6] Add HDMI CEC support to Rockchip RK3588/RK3576 SoCs From: Cristian Ciocaltea To: Mark Brown Cc: Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Dmitry Baryshkov , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Catalin Marinas , Will Deacon , kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Algea Cao , Derek Foreman , Daniel Stone , Aishwarya.TCV@arm.com References: <20250903-rk3588-hdmi-cec-v4-0-fa25163c4b08@collabora.com> <6f3f126d-72c1-48cb-a9c8-8d354af2a3d5@sirena.org.uk> <410fa913-e86b-4ffd-9d79-ce804f0271ff@collabora.com> Content-Language: en-US In-Reply-To: <410fa913-e86b-4ffd-9d79-ce804f0271ff@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/28/25 2:42 PM, Cristian Ciocaltea wrote: > Hi Mark, > > On 10/28/25 2:38 PM, Mark Brown wrote: >> On Wed, Sep 03, 2025 at 09:50:58PM +0300, Cristian Ciocaltea wrote: >>> The first patch in the series implements the CEC capability of the >>> Synopsys DesignWare HDMI QP TX controller found in RK3588 & RK3576 Socs. >>> This is based on the downstream code, but rewritten on top of the CEC >>> helpers added recently to the DRM HDMI connector framework. >> >> For the past couple of weeks we've been seeing various instability with >> the graphics drivers on the Rock 5B in -next, the most common system is >> that we get faults in code that looks suspiciously relevant to this >> series: >> >> <6>[ 17.353368] rockchip-drm display-subsystem: bound fdd90000.vop (ops vop2_component_ops [rockchipdrm]) >> <6>[ 17.355237] dwhdmiqp-rockchip fde80000.hdmi: registered DesignWare HDMI QP I2C bus driver >> / # <1>[ 17.357803] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000098 >> >> ... >> >> <4>[ 17.372390] Hardware name: Radxa ROCK 5B (DT) >> >> ... >> >> <4>[ 17.382082] Call trace: >> <4>[ 17.382317] drm_bridge_connector_hdmi_cec_init+0x8/0x38 [drm_display_helper] (P) >> <4>[ 17.383003] drm_bridge_connector_init+0x658/0x678 [drm_display_helper] >> <4>[ 17.383612] dw_hdmi_qp_rockchip_bind+0x35c/0x4d8 [rockchipdrm] >> <4>[ 17.384159] component_bind_all+0x118/0x248 >> <4>[ 17.384550] rockchip_drm_bind+0xb4/0x20c [rockchipdrm] >> <4>[ 17.385034] try_to_bring_up_aggregate_device+0x164/0x1d0 >> <4>[ 17.385528] component_master_add_with_match+0xc4/0x104 >> <4>[ 17.386008] rockchip_drm_platform_probe+0x1f8/0x31c [rockchipdrm] >> >> (from today's -next, >> >> Unfortunately we haven't managed to point at a specific commit, it looks >> like this might be triggered by multiple serieses interacting with each >> other. I'm not sure what other information might be useful here? > > Thanks for reporting, I will investigate. This seems to have been already addressed: https://lore.kernel.org/all/20251017-drm-bridge-alloc-getput-bridge-connector-fix-hdmi_cec-v2-0-667abf6d47c0@bootlin.com/ > Regards, > Cristian