Re: [PATCH net-next] net: ti: icssg-prueth: Omit a variable reassignment in prueth_netdev_init()

[Alexander Lobakin <aleksander.lobakin@intel.com>]

From: Markus Elfring <Markus.Elfring@web.de>
Date: Mon, 20 Oct 2025 16:02:56 +0200

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 20 Oct 2025 15:46:11 +0200
> 
> An error code was assigned to a variable and checked accordingly.
> This value was passed to a dev_err_probe() call in an if branch.
> This function is documented in the way that the same value is returned.
> Thus delete two redundant variable reassignments.
> 
> The source code was transformed by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Reviewed-by Alexander Lobakin <aleksander.lobakin@intel.com>

> ---
>  drivers/net/ethernet/ti/icssg/icssg_prueth.c     | 3 +--
>  drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c | 3 +--
>  2 files changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth.c b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
> index e42d0fdefee1..0bfd761bffc5 100644
> --- a/drivers/net/ethernet/ti/icssg/icssg_prueth.c
> +++ b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
> @@ -1248,8 +1248,7 @@ static int prueth_netdev_init(struct prueth *prueth,
>  	} else if (of_phy_is_fixed_link(eth_node)) {
>  		ret = of_phy_register_fixed_link(eth_node);
>  		if (ret) {
> -			ret = dev_err_probe(prueth->dev, ret,
> -					    "failed to register fixed-link phy\n");
> +			dev_err_probe(prueth->dev, ret, "failed to register fixed-link phy\n");
>  			goto free;
>  		}
>  
> diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c b/drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c
> index 5e225310c9de..bd88877e8e65 100644
> --- a/drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c
> +++ b/drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c
> @@ -816,8 +816,7 @@ static int prueth_netdev_init(struct prueth *prueth,
>  	} else if (of_phy_is_fixed_link(eth_node)) {
>  		ret = of_phy_register_fixed_link(eth_node);
>  		if (ret) {
> -			ret = dev_err_probe(prueth->dev, ret,
> -					    "failed to register fixed-link phy\n");
> +			dev_err_probe(prueth->dev, ret, "failed to register fixed-link phy\n");
>  			goto free;
>  		}

Thanks,
Olek