From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 218BFC2BB86 for ; Thu, 9 Apr 2020 13:25:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 00B7E208FE for ; Thu, 9 Apr 2020 13:25:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726877AbgDINZL (ORCPT ); Thu, 9 Apr 2020 09:25:11 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:38042 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726632AbgDINZL (ORCPT ); Thu, 9 Apr 2020 09:25:11 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id 0A542297B00 Subject: Re: [PATCH v2] arm64: dts: mt8173: Add gce setting in mmsys and display node To: Hsin-Yi Wang , linux-arm-kernel@lists.infradead.org Cc: devicetree@vger.kernel.org, Chun-Kuang Hu , linux-kernel@vger.kernel.org, Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger References: <20200409055012.199320-1-hsinyi@chromium.org> From: Enric Balletbo i Serra Message-ID: <63058ea1-9cce-2c2e-0041-9369033a7b33@collabora.com> Date: Thu, 9 Apr 2020 15:25:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200409055012.199320-1-hsinyi@chromium.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Hsin-Yi, Thanks for sending the patch upstream On 9/4/20 7:50, Hsin-Yi Wang wrote: > In order to use GCE function, we need add some informations > into display node (mboxes, mediatek,gce-client-reg, mediatek,gce-events). > > Signed-off-by: Hsin-Yi Wang > Reviewed-by: Bibby Hsieh Tested on my Acer Chromebook R13, so Tested-by: Enric Balletbo i Serra > --- > change log: > v1->v2: align with > 19d8e335d58a ("dt-binding: gce: remove atomic_exec in mboxes property") > 60fa8c13ab1a ("drm/mediatek: Move gce event property to mutex device node") > --- > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 18 +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > index ccb8e88a60c5..8337ba42845d 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > @@ -549,7 +549,7 @@ gce: mailbox@10212000 { > interrupts = ; > clocks = <&infracfg CLK_INFRA_GCE>; > clock-names = "gce"; > - #mbox-cells = <3>; > + #mbox-cells = <2>; > }; > > mipi_tx0: mipi-dphy@10215000 { > @@ -916,6 +916,9 @@ mmsys: clock-controller@14000000 { > assigned-clocks = <&topckgen CLK_TOP_MM_SEL>; > assigned-clock-rates = <400000000>; > #clock-cells = <1>; > + mboxes = <&gce 0 CMDQ_THR_PRIO_HIGHEST>, > + <&gce 1 CMDQ_THR_PRIO_HIGHEST>; > + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0 0x1000>; > }; > > mdp_rdma0: rdma@14001000 { > @@ -996,6 +999,7 @@ ovl0: ovl@1400c000 { > clocks = <&mmsys CLK_MM_DISP_OVL0>; > iommus = <&iommu M4U_PORT_DISP_OVL0>; > mediatek,larb = <&larb0>; > + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0xc000 0x1000>; > }; > > ovl1: ovl@1400d000 { > @@ -1006,6 +1010,7 @@ ovl1: ovl@1400d000 { > clocks = <&mmsys CLK_MM_DISP_OVL1>; > iommus = <&iommu M4U_PORT_DISP_OVL1>; > mediatek,larb = <&larb4>; > + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0xd000 0x1000>; > }; > > rdma0: rdma@1400e000 { > @@ -1016,6 +1021,7 @@ rdma0: rdma@1400e000 { > clocks = <&mmsys CLK_MM_DISP_RDMA0>; > iommus = <&iommu M4U_PORT_DISP_RDMA0>; > mediatek,larb = <&larb0>; > + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0xe000 0x1000>; > }; > > rdma1: rdma@1400f000 { > @@ -1026,6 +1032,7 @@ rdma1: rdma@1400f000 { > clocks = <&mmsys CLK_MM_DISP_RDMA1>; > iommus = <&iommu M4U_PORT_DISP_RDMA1>; > mediatek,larb = <&larb4>; > + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0xf000 0x1000>; > }; > > rdma2: rdma@14010000 { > @@ -1036,6 +1043,7 @@ rdma2: rdma@14010000 { > clocks = <&mmsys CLK_MM_DISP_RDMA2>; > iommus = <&iommu M4U_PORT_DISP_RDMA2>; > mediatek,larb = <&larb4>; > + mediatek,gce-client-reg = <&gce SUBSYS_1401XXXX 0 0x1000>; > }; > > wdma0: wdma@14011000 { > @@ -1046,6 +1054,7 @@ wdma0: wdma@14011000 { > clocks = <&mmsys CLK_MM_DISP_WDMA0>; > iommus = <&iommu M4U_PORT_DISP_WDMA0>; > mediatek,larb = <&larb0>; > + mediatek,gce-client-reg = <&gce SUBSYS_1401XXXX 0x1000 0x1000>; > }; > > wdma1: wdma@14012000 { > @@ -1056,6 +1065,7 @@ wdma1: wdma@14012000 { > clocks = <&mmsys CLK_MM_DISP_WDMA1>; > iommus = <&iommu M4U_PORT_DISP_WDMA1>; > mediatek,larb = <&larb4>; > + mediatek,gce-client-reg = <&gce SUBSYS_1401XXXX 0x2000 0x1000>; > }; > > color0: color@14013000 { > @@ -1064,6 +1074,7 @@ color0: color@14013000 { > interrupts = ; > power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>; > clocks = <&mmsys CLK_MM_DISP_COLOR0>; > + mediatek,gce-client-reg = <&gce SUBSYS_1401XXXX 0x3000 0x1000>; > }; > > color1: color@14014000 { > @@ -1072,6 +1083,7 @@ color1: color@14014000 { > interrupts = ; > power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>; > clocks = <&mmsys CLK_MM_DISP_COLOR1>; > + mediatek,gce-client-reg = <&gce SUBSYS_1401XXXX 0x4000 0x1000>; > }; > > aal@14015000 { > @@ -1080,6 +1092,7 @@ aal@14015000 { > interrupts = ; > power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>; > clocks = <&mmsys CLK_MM_DISP_AAL>; > + mediatek,gce-client-reg = <&gce SUBSYS_1401XXXX 0x5000 0x1000>; > }; > > gamma@14016000 { > @@ -1088,6 +1101,7 @@ gamma@14016000 { > interrupts = ; > power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>; > clocks = <&mmsys CLK_MM_DISP_GAMMA>; > + mediatek,gce-client-reg = <&gce SUBSYS_1401XXXX 0x6000 0x1000>; > }; > > merge@14017000 { > @@ -1193,6 +1207,8 @@ mutex: mutex@14020000 { > interrupts = ; > power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>; > clocks = <&mmsys CLK_MM_MUTEX_32K>; > + mediatek,gce-events = , > + ; > }; > > larb0: larb@14021000 { >