From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C1211E1DEC for ; Thu, 19 Feb 2026 00:39:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=44.202.169.39 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771461574; cv=none; b=RRD48CKxQWFyLOHv+kjbveXjE+zo5JGiWYOU7KYhwUBctJEEtBTzdqQBUOlAFe+nO2W2TrjPWgx7MYhbsTj47UWPW5xfmmgEKxpbGmn5kY004mJzpq8Sw7/kJTnY0dtcJ3N5NC3TAcx8hC/P3Y3I6mV17Ih5BmtssHOEZiIUnK4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771461574; c=relaxed/simple; bh=z6syF4LidYTHWoLqxLqQLWmNiefVyfFzZH9TK+S8Qhk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OJxhWh2lodH87R9bl+UeRtfgGwOoo4mpBgeVbjG1wX7zXogRwZiUu/+O/5Rv1otBNlC0jHkhijWpa3MRIWlbdgcAd1A5MgGRQX5m9SBMslRszCYwyw8x3UcBygUMs95U+dlifvEtMGT+qqRrAcuS6jOVDc1gF+Bq17JJA5sagMI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=embeddedor.com; spf=pass smtp.mailfrom=embeddedor.com; dkim=pass (2048-bit key) header.d=embeddedor.com header.i=@embeddedor.com header.b=TFvzcemT; arc=none smtp.client-ip=44.202.169.39 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=embeddedor.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=embeddedor.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=embeddedor.com header.i=@embeddedor.com header.b="TFvzcemT" Received: from eig-obgw-5001b.ext.cloudfilter.net ([10.0.29.181]) by cmsmtp with ESMTPS id sriWvjPl0CxrGss4qvnug5; Thu, 19 Feb 2026 00:39:32 +0000 Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with ESMTPS id ss4pv9sUISqlVss4pvfEBo; Thu, 19 Feb 2026 00:39:31 +0000 X-Authority-Analysis: v=2.4 cv=I7FlRMgg c=1 sm=1 tr=0 ts=69965bc4 a=1YbLdUo/zbTtOZ3uB5T3HA==:117 a=k5Y5iPg+dmTXVWgYE/XtfQ==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=7T7KSl7uo7wA:10 a=VwQbUJbxAAAA:8 a=9YR8UghG2Mux9z_Xfx4A:9 a=QEXdDO2ut3YA:10 a=2aFnImwKRvkU0tJ3nQRT:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=+/cI9yYaTzTcqdQ58iWogswfNeVO0Pn3cSXKnRlVUwg=; b=TFvzcemTtvfbWw5mv7eH4IFz4W /gVUCTw9e07wPvK/Q+SoU5UMs0ZlpWO/rCEEPaXcbjBiNViNdd6S0/SAOQMNPfq3iqC7tUQC07wW0 Zf1HERNpDc4C9NyNtbpUFxkU9bypsTUphtjFlhTIAkLYjOSi8RnzDO48DiTZmfNDVYBtvDETrz+JM g1qb3NVVpMgApSCaaJI8KnkCLWvWI22RgecPTwSnuOqtwO5clQt/Zhhygyd3JTwRl6Gm7liyqA5J/ Ae6H17Vj4Fc8HgUoh934JB6KT0K//0LOZWXjUPNa7m+soVVf66Ki5p2w5TJS98DcB7pkcKajE/jRt ueo11Deg==; Received: from [177.238.16.13] (port=37088 helo=[192.168.0.21]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.99.1) (envelope-from ) id 1vss4o-00000003gCK-41Zb; Wed, 18 Feb 2026 18:39:31 -0600 Message-ID: <6305fbc7-8210-4f4d-b719-30ba038611af@embeddedor.com> Date: Wed, 18 Feb 2026 18:38:41 +0900 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2][next] wifi: ath6kl: wmi: Avoid -Wflex-array-member-not-at-end warning To: Jeff Johnson , "Gustavo A. R. Silva" , Kalle Valo Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org References: Content-Language: en-US From: "Gustavo A. R. Silva" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 177.238.16.13 X-Source-L: No X-Exim-ID: 1vss4o-00000003gCK-41Zb X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.0.21]) [177.238.16.13]:37088 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 2 X-Org: HG=hgshared;ORG=hostgator; X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfKceI9vtouJwA7x7cnm/l2HQ57J5XO7n15qAmwsNUruV5yJvP/dEQPYnDbYuY4nicdthfcMjivBeeA2TvimSQxKALY26F9tJvfvje98dCwssZA/WdoKR O1CcZ/Gbko03oLI7nlO5fdxh2BxP5Qq2F/dqMoJ0+GznYyG3D0qASbdI7N+pAyAxfYrGgwhiWVhrdjGqmC0ub22qjI0Suf4sHLbXu/a17mR/ZDqZ9/I9xBgn >> @@ -1652,7 +1656,7 @@ struct roam_ctrl_cmd { >> union { >> u8 bssid[ETH_ALEN]; /* WMI_FORCE_ROAM */ >> u8 roam_mode; /* WMI_SET_ROAM_MODE */ >> - struct bss_bias_info bss; /* WMI_SET_HOST_BIAS */ >> + struct bss_bias_info_hdr bss; /* WMI_SET_HOST_BIAS */ >> struct low_rssi_scan_params params; /* WMI_SET_LRSSI_SCAN_PARAMS >> */ >> } __packed info; > > That bss member appears to be completely unused > (bssid, roam_mode, and params are used) > > So IMO the better solution is to remove bss from the union. > And I think struct bss_bias and struct bss_bias_info can also be removed. Even if they're not used, are you sure they aren't there simply to define the memory layout of struct roam_ctrl_cmd? As Kees commented[1], struct roam_ctrl_cmd appears to be a hardware interface... See below: drivers/net/wireless/ath/ath6kl/wmi.c: 755 /* 756 * Mechanism to modify the roaming behavior in the firmware. The lower rssi 757 * at which the station has to roam can be passed with 758 * WMI_SET_LRSSI_SCAN_PARAMS. Subtract 96 from RSSI to get the signal level 759 * in dBm. 760 */ 761 int ath6kl_wmi_set_roam_lrssi_cmd(struct wmi *wmi, u8 lrssi) 762 { 763 struct sk_buff *skb; 764 struct roam_ctrl_cmd *cmd; 765 766 skb = ath6kl_wmi_get_new_buf(sizeof(*cmd)); 767 if (!skb) 768 return -ENOMEM; 769 770 cmd = (struct roam_ctrl_cmd *) skb->data; ... } Thanks -Gustavo [1] https://lore.kernel.org/linux-hardening/202601151627.99DFE54@keescook/