From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751492AbdGRIBE (ORCPT ); Tue, 18 Jul 2017 04:01:04 -0400 Received: from mx2.suse.de ([195.135.220.15]:35803 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751203AbdGRIBD (ORCPT ); Tue, 18 Jul 2017 04:01:03 -0400 Subject: Re: [PATCH][xen-next] xen/pvcalls: fix null pointer reference on sock_release call To: Colin King , Boris Ostrovsky , xen-devel@lists.xenproject.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170711194121.24802-1-colin.king@canonical.com> From: Juergen Gross Message-ID: <63061c05-e462-be95-0219-a0cdf6c17449@suse.com> Date: Tue, 18 Jul 2017 10:01:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170711194121.24802-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/07/17 21:41, Colin King wrote: > From: Colin Ian King > > Currently a sock_release on map->sock will result in a null pointer > deference on map when map is null. Instead, the sock_relase sould > be on sock and not map->sock. > > Detected by CoverityScan, CID#1450169 ("Dereference after null check") > > Fixes: b535e2b9b78a ("xen/pvcalls: implement connect command") > Signed-off-by: Colin Ian King Committed to xen/tip for-linus-4.13 Thanks, Juergen