From: Keith Owens <kaos@sgi.com>
To: David Mansfield <lkml@dm.cobite.com>
Cc: linux-kernel@vger.kernel.org, kdb@oss.sgi.com
Subject: Re: [OOPS] in kdb v2.3 on top of 2.5.44
Date: Tue, 22 Oct 2002 18:34:24 +1000 [thread overview]
Message-ID: <6307.1035275664@kao2.melbourne.sgi.com> (raw)
In-Reply-To: Your message of "Sun, 20 Oct 2002 14:46:05 -0400." <Pine.LNX.4.44.0210201440150.30018-100000@admin>
On Sun, 20 Oct 2002 14:46:05 -0400 (EDT),
David Mansfield <lkml@dm.cobite.com> wrote:
>EIP is at kdba_setjmp+0x4/0x50
>eax: 00000000 ebx: c044a000 ecx: 00000001 edx: 00000000
>esi: 00000004 edi: c034409f ebp: c044a000 esp: c044be1c
A kbuild change in 2.5.41 moved the initial setting of CFLAGS before
the include of .config. Now the global CFLAGS must not depend on any
config settings (totally undocumented, of course). kdba_setjmp was
compiled with CONFIG_FRAME_POINTERS=y from config.h, but gcc flags were
set to -fomit-frame-pointer, the mismatch generated bad code.
Will be fixed in next kdb patch, in the meantime, apply this over
kdb-v2.3-2.5.53-common-1.
Index: 43.2/Makefile
--- 43.2/Makefile Thu, 17 Oct 2002 15:02:15 +1000 kaos (linux-2.5/I/d/12_Makefile 1.41.1.10 444)
+++ 43.2(w)/Makefile Tue, 22 Oct 2002 18:17:22 +1000 kaos (linux-2.5/I/d/12_Makefile 1.41.1.10 444)
@@ -159,9 +159,6 @@ CPPFLAGS := -D__KERNEL__ -Iinclude
CPPFLAGS += $(patsubst %,-I%,$(CROSS_COMPILE_INC))
CFLAGS := $(CPPFLAGS) -Wall -Wstrict-prototypes -Wno-trigraphs -O2 \
-fno-strict-aliasing -fno-common
-ifndef CONFIG_FRAME_POINTER
-CFLAGS += -fomit-frame-pointer
-endif
AFLAGS := -D__ASSEMBLY__ $(CPPFLAGS)
export VERSION PATCHLEVEL SUBLEVEL EXTRAVERSION KERNELRELEASE ARCH \
@@ -212,6 +209,10 @@ include-config := 1
endif
+ifndef CONFIG_FRAME_POINTER
+CFLAGS += -fomit-frame-pointer
+endif
+
include arch/$(ARCH)/Makefile
core-y += kernel/ mm/ fs/ ipc/ security/
prev parent reply other threads:[~2002-10-22 8:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-20 18:46 David Mansfield
2002-10-22 8:34 ` Keith Owens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6307.1035275664@kao2.melbourne.sgi.com \
--to=kaos@sgi.com \
--cc=kdb@oss.sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml@dm.cobite.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®