From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21834332906 for ; Wed, 10 Jun 2026 16:32:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781109169; cv=none; b=lYSXeu/XcpZ9Myh/3y2lqfuCJv3jcIRyj4KLOID8V670fPjNfjtHeYUnqZsq5hY2m75HW/bLmErLYVFeMvag0sZU4GEWbAAAcaoiOKXMc1ztnFrb+QQaox/ua+FueS2XGQXlaxciHOpmvclnC56KmVqRkulI5/j3OlXkVoaTEo4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781109169; c=relaxed/simple; bh=TMEzfUQLssg5wNKq/jlt1a3iau2h5D0PdUtQtzIN32I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=L7ESRdVYPTdQj1sWcDGYk+2zLJPcbHRiwnBZmavky8UaShqv/fMo1DZz2hl/cD0OhbWZjdiMw/vb49nw/yMfMhFxdy3QSnEbhMoVrITvKUhj/e9sTNmmQ/f65dseJpnO+2DM+Eog4tpl5d/jxBzjRJEEZWY8qGicpqjilu4SYoU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=J6w0LCPd; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="J6w0LCPd" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 85E261A37E0; Wed, 10 Jun 2026 16:32:45 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 441305FFC9; Wed, 10 Jun 2026 16:32:45 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id D9456106B9B31; Wed, 10 Jun 2026 18:32:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1781109164; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=DJ6myqASREWHuJJOHXc0Aa1s/r8YHpCv7VS2pMiv0nE=; b=J6w0LCPdG5UtkYkRNtVFCqKJL1exBSA8b6gtJkFG8z5mvYDfQ1rolBl+BwJMnKpGrtpzsd a0WFBN8zXcw2HRUpKZUmdg9zehLNxGxGtwA5tt9DFNxsyi2T4Q3iwmAeHh5vFVR5TKvUGD mK/DTj5krxkMNz/gmH2h9ZZT1pZxbpt0v1AUSYKaYwgH4MLMOzBXpouGISXNXxwW/UMy/i Qmn8Yj4n67rP0IVGd2fP/7Hq5pnvL7fBh8oSLRKpqVIrqvl4m+KPjTK4h1WV5LO/9SscBo sfoCYNPi0AvzHj66vm3Ho1jtNAXmmfXAyv0g/IUCExp152L1WC5ctn0Xypem3w== Message-ID: <6309a8e9-c0cb-4473-8d94-c6c4ca8ec3f9@bootlin.com> Date: Wed, 10 Jun 2026 18:32:38 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v4 3/4] net: phy: realtek: add support for RTL8261C_CG To: javen , andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, freddy_gu@realsil.com.cn, nb@tipi-net.de Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, daniel@makrotopia.org, vladimir.oltean@nxp.com References: <20260609020727.1152-1-javen_xu@realsil.com.cn> <20260609020727.1152-4-javen_xu@realsil.com.cn> Content-Language: en-US From: Maxime Chevallier In-Reply-To: <20260609020727.1152-4-javen_xu@realsil.com.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 Hi, On 6/9/26 04:07, javen wrote: > From: Javen Xu > > This patch adds support for Realtek phy chip RTL8261C_CG. Its PHY ID is > 0x001cc898. > > Signed-off-by: Javen Xu [...] > +static int rtl8261x_config_aneg(struct phy_device *phydev) > +{ > + bool changed = false; > + u16 adv_1g = 0; > + int ret; > + > + if (phydev->autoneg == AUTONEG_DISABLE) > + return genphy_c45_pma_setup_forced(phydev); This condition above is already done when calling genphy_c45_config_aneg, is it really necessary to put it there ? > + > + ret = genphy_c45_an_setup_master_slave(phydev); > + if (ret < 0) > + return ret; > + if (ret > 0) > + changed = true; I'm wondering if this call to genphy_c45_an_setup_master_slave() may actually be integrated directly into genphy_c45_config_aneg(), as we do for C22. It _may_ break some C45 phys that would rely on default values though, but this should be more correct ? Maxime