From: Krzysztof Kozlowski <krzk@kernel.org>
To: Antoniu Miclaus <antoniu.miclaus@analog.com>,
Peter Rosin <peda@axentia.se>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mux: adg1736: add driver support
Date: Fri, 19 Dec 2025 18:57:41 +0100 [thread overview]
Message-ID: <630cc8c7-0b3f-4479-88fe-780201e78b92@kernel.org> (raw)
In-Reply-To: <20251219143554.22793-3-antoniu.miclaus@analog.com>
On 19/12/2025 15:35, Antoniu Miclaus wrote:
> + ret = devm_mux_chip_register(dev, mux_chip);
> + if (ret < 0)
> + return ret;
> +
> + dev_info(dev, "ADG1736 %u dual SPDT mux controllers registered\n",
> + mux_chip->controllers);
This does not look like useful printk message. Drivers should be silent
on success:
https://elixir.bootlin.com/linux/v6.15-rc7/source/Documentation/process/coding-style.rst#L913
https://elixir.bootlin.com/linux/v6.15-rc7/source/Documentation/process/debugging/driver_development_debugging_guide.rst#L79
Best regards,
Krzysztof
prev parent reply other threads:[~2025-12-19 17:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-19 14:35 [PATCH 0/2] Add support for ADG1736 Dual 2:1 Multiplexer Antoniu Miclaus
2025-12-19 14:35 ` [PATCH 1/2] dt-bindings: mux: adg1736: add support Antoniu Miclaus
2025-12-19 17:52 ` Krzysztof Kozlowski
2025-12-19 14:35 ` [PATCH 2/2] mux: adg1736: add driver support Antoniu Miclaus
2025-12-19 17:57 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=630cc8c7-0b3f-4479-88fe-780201e78b92@kernel.org \
--to=krzk@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=arnd@arndb.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®