From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751476AbdAaQjw (ORCPT ); Tue, 31 Jan 2017 11:39:52 -0500 Received: from b.ns.miles-group.at ([95.130.255.144]:44723 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751064AbdAaQjq (ORCPT ); Tue, 31 Jan 2017 11:39:46 -0500 Subject: Re: [PATCH] mtd: spi-nor: cqspi: remove redundant dead code on error return check To: Colin King , Cyrille Pitchen , Marek Vasut , David Woodhouse , Brian Norris , Boris Brezillon , linux-mtd@lists.infradead.org References: <20170131155317.20106-1-colin.king@canonical.com> Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org From: Richard Weinberger Message-ID: <630cf780-6cf5-ff5d-1a83-e360074483b4@nod.at> Date: Tue, 31 Jan 2017 17:39:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170131155317.20106-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 31.01.2017 um 16:53 schrieb Colin King: > From: Colin Ian King > > Checking for ret < 0 is redundant because a previous check on ret > being non-zero already handles the ret < 0 case. Remove the redundant > code. Found by CoverityScan, CID#1398863, CID#1398864 > > Signed-off-by: Colin Ian King Reviewed-by: Richard Weinberger Thanks, //richard