mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jin, Yao" <yao.jin@linux.intel.com>
To: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
	mingo@redhat.com, alexander.shishkin@linux.intel.com
Cc: Linux-kernel@vger.kernel.org, ak@linux.intel.com,
	kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v1 0/4] perf annotate: Display multiple events on the left side of annotate view
Date: Fri, 8 Sep 2017 15:31:54 +0800	[thread overview]
Message-ID: <63100008-c4fb-3627-d3a3-5062413c98ba@linux.intel.com> (raw)
In-Reply-To: <1502878716-30817-1-git-send-email-yao.jin@linux.intel.com>

Hi,

Any comments for this patch-set?

I just find a merge conflict with the latest perf/core.

Do I need to send the v2 to fix the merge issue right now?

Thanks

Jin Yao

On 8/16/2017 6:18 PM, Jin Yao wrote:
> perf record -e cycles,branches ...
> perf annotate main --stdio
>
> The result only shows cycles. It should show both cycles and
> branches on the left side of annotate view. It works with
> "--group", but need this to work even without groups.
>
> The patch series supports to display multiple events on the
> left side of annotate view for stdio, tui and gtk modes.
>
> Jin Yao (4):
>    perf annotate: create a new hists to manage multiple events samples
>    perf annotate: Display multiple events for stdio mode
>    perf annotate: Display multiple events for tui mode
>    perf annotate: Display multiple events for gtk mode
>
>   tools/perf/builtin-annotate.c     |  62 +++++++++----
>   tools/perf/builtin-top.c          |   3 +-
>   tools/perf/ui/browsers/annotate.c |  49 +++++++---
>   tools/perf/ui/browsers/hists.c    |   2 +-
>   tools/perf/ui/gtk/annotate.c      |  35 ++++---
>   tools/perf/util/annotate.c        | 187 +++++++++++++++++++++++++++++---------
>   tools/perf/util/annotate.h        |  16 +++-
>   tools/perf/util/hist.h            |   8 +-
>   tools/perf/util/sort.c            |  21 +++++
>   tools/perf/util/sort.h            |  13 +++
>   10 files changed, 301 insertions(+), 95 deletions(-)
>

      parent reply	other threads:[~2017-09-08  7:33 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-16 10:18 Jin Yao
2017-08-16 10:18 ` [PATCH v1 1/4] perf annotate: create a new hists to manage multiple events samples Jin Yao
2017-09-08 13:43   ` Arnaldo Carvalho de Melo
2017-09-11  1:33     ` Jin, Yao
2017-09-14  1:03       ` Jin, Yao
2017-09-14 14:05         ` Arnaldo Carvalho de Melo
2017-09-14 14:31           ` Jin, Yao
2017-10-05 13:21   ` Arnaldo Carvalho de Melo
2017-10-06 16:31     ` Jin, Yao
2017-10-06 18:54       ` Arnaldo Carvalho de Melo
2017-10-09  1:40         ` Jin, Yao
2017-10-12  1:39           ` Jin, Yao
2017-08-16 10:18 ` [PATCH v1 2/4] perf annotate: Display multiple events for stdio mode Jin Yao
2017-08-16 10:18 ` [PATCH v1 3/4] perf annotate: Display multiple events for tui mode Jin Yao
2017-08-16 10:18 ` [PATCH v1 4/4] perf annotate: Display multiple events for gtk mode Jin Yao
2017-09-08  7:31 ` Jin, Yao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63100008-c4fb-3627-d3a3-5062413c98ba@linux.intel.com \
    --to=yao.jin@linux.intel.com \
    --cc=Linux-kernel@vger.kernel.org \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@intel.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=yao.jin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®