From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4376C3A5A9 for ; Sun, 19 Apr 2020 19:44:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A2AD92145D for ; Sun, 19 Apr 2020 19:44:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mHNRyoRP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726468AbgDSToY (ORCPT ); Sun, 19 Apr 2020 15:44:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725848AbgDSToY (ORCPT ); Sun, 19 Apr 2020 15:44:24 -0400 Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37967C061A0F; Sun, 19 Apr 2020 12:44:24 -0700 (PDT) Received: by mail-pg1-x52b.google.com with SMTP id q18so426949pgm.11; Sun, 19 Apr 2020 12:44:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=cA6qmkeyWrcnmDv7BglbhRft1zqjTVZsRxjICTNVaNc=; b=mHNRyoRPXu0ih5Se4+KlXIQ/sypK/M6rYTOdovyWQuSPBd/j/bybAYlYAOGHJzuFYV dWUaE5ttwpOtBx52ahgKS/sno2ZAnUM/Jbxc9SzdZIQp3fApQJkwDZxIgM6fI8jZLZVw j2grjLoggKrbGq3vkSMU2xwiVPSprBUuLPctDUgekCYGWm82xkdgA7qguJHIIv8P9H/h gu5kXSesE7BQNqu2fwGnIW4nKaza7DpOR96cjv7UWr1phKea2lqgw6w2Ne4e23s6l5Vp wiePWuhugZrCBgDp47Oo/WZ8z7VLwa/oIN/qe1r+yCJhdh/eD82ROff0KSU4fXiVwiny nb1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=cA6qmkeyWrcnmDv7BglbhRft1zqjTVZsRxjICTNVaNc=; b=UbD+snsmqSnolooB4NLURF8SpuQYgTaCz6Zzeo9vhmH0xQ5UY2CW9AQa4mjnzoasNC kycbcKjKIhCL664Nfr5EiDLIk5CDIdF5dRol3SLBdH7fjcabQIW8GMvD5NpJ4pigsaEI 95EApAoajPvgd+70N9sU/yOu69Beby0l2r5VcrHMEwVig/+uYfADyezQwdAFnQn0WCz8 zyZWwyUL7i3JNPOwCWdX/5v02KRlO0XazQ0zEiZ7VMKBG5J6IixfabpzUtKjZDWoFcMu A8/rr/vu9yzzJgE5SQUrFEL4WsWCqoHRd9hDBelDIPGIA4Yb65uhlvOtZh2v2q4rp/cM 7BWA== X-Gm-Message-State: AGi0PuYsrLl6ApsaD/Q+qe5uHqWlwgqFwo7BJHvhUQkgNs7fnlR1nCOj zgx7Z3zgEgnIy0JVNIaDjGNMbyHK X-Google-Smtp-Source: APiQypLTOfRQ8ljE00wRUP4agY2CBBc3JMTJ/+7RFpm5BXgIEYK17jmV8AJnDBQvT87sdku9s1t+JA== X-Received: by 2002:aa7:8f2c:: with SMTP id y12mr14125953pfr.80.1587325462790; Sun, 19 Apr 2020 12:44:22 -0700 (PDT) Received: from [192.168.1.3] (ip68-111-84-250.oc.oc.cox.net. [68.111.84.250]) by smtp.gmail.com with ESMTPSA id l7sm25358368pfl.171.2020.04.19.12.44.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Apr 2020 12:44:14 -0700 (PDT) Subject: Re: [Patch v2 3/9] spi: bcm-qspi: Handle lack of MSPI_REV offset To: Kamal Dasu , bcm-kernel-feedback-list@broadcom.com, Mark Brown Cc: Florian Fainelli , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200419192339.32023-1-kdasu.kdev@gmail.com> <20200419192339.32023-4-kdasu.kdev@gmail.com> From: Florian Fainelli Message-ID: <63176468-53b6-c11a-9e33-2ca9dd06f7a3@gmail.com> Date: Sun, 19 Apr 2020 12:44:13 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Firefox/68.0 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200419192339.32023-4-kdasu.kdev@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kamal, On 4/19/2020 12:23 PM, Kamal Dasu wrote: > Older MIPS chips have a QSPI/MSPI controller that does not have the > MSPI_REV offset, reading from that offset will cause a bus error. Match > their compatible string and do not perform a read from that register in > that case. > > Signed-off-by: Florian Fainelli > Signed-off-by: Kamal Dasu This patch should also have a From: that is from me. -- Florian