mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javierm@redhat.com>
To: "Ondřej Jirman" <megi@xff.cz>,
	linux-kernel@vger.kernel.org,
	"Kamil Trzciński" <ayufan@ayufan.eu>,
	"Martijn Braam" <martijn@brixit.nl>,
	"Sam Ravnborg" <sam@ravnborg.org>,
	"Robert Mader" <robert.mader@posteo.de>,
	"Tom Fitzhenry" <tom@tom-fitzhenry.me.uk>,
	"Peter Robinson" <pbrobinson@gmail.com>,
	"Onuralp Sezer" <thunderbirdtr@fedoraproject.org>,
	dri-devel@lists.freedesktop.org,
	"Maya Matuszczyk" <maccraft123mc@gmail.com>,
	"Neal Gompa" <ngompa13@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
	"Jagan Teki" <jagan@amarulasolutions.com>,
	"Caleb Connolly" <kc@postmarketos.org>,
	"Heiko Stuebner" <heiko@sntech.de>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v4 4/4] arm64: dts: rk3399-pinephone-pro: Add internal display support
Date: Mon, 2 Jan 2023 14:34:11 +0100	[thread overview]
Message-ID: <6319a8b4-1152-40d8-29f1-015a8c5247f4@redhat.com> (raw)
In-Reply-To: <20230102105746.5abnjzwf365c6hy2@core>

Hello Ondřej,

On 1/2/23 11:57, Ondřej Jirman wrote:

[...]

>>
>> You tell me, it is your patch :) I just cherry-picked this from your tree:
> 
> I have other patches to goodix driver that do power off the touch sensor chip
> during sleep, so that it doesn't consume excessinve amounts of power when
> the phone is suspended. Mainline doesn't. You have to adapt this to mainline,
> because you're not upstreaming the required Goodix patches, for regulator-off-in-suspend
> to not break things.
> 
>> https://github.com/megous/linux/commit/11f8da60d6a5
>>
>> But if that is not correct, then I can drop the regulator-off-in-suspend.
>>

Ah, I see. Missed that. Then I guess that's better to drop the regulator-off-in-suspend
until the goodix driver patches are upstreamed.

>> [...]
>>
>>>> +
>>>> +	touchscreen@14 {
>>>> +		compatible = "goodix,gt917s";
>>>
>>> This is not the correct compatible. Pinephone Pro uses Goodix GT1158:
>>>
>>> Goodix-TS 3-0014: ID 1158, version: 0100
>>> Goodix-TS 3-0014: Direct firmware load for goodix_1158_cfg.bin failed with error -2
>>>
>>>
>>
>> Same thing. I wasn't aware of this since your patch was using this compatible
>> string. If "goodix,gt1158" is the correct compatible string, then I agree we
>> should have that instead even when the firmware is missing. Because the DT is
>> supposed to describe the hardware. The FW issue can be tackled as a follow-up.
>>
>> [...] 
> 
> Yes, compatible string is sort of irrelevant, because the driver does runtime
> auto-detection based on chip ID. I didn't bother with superficial issues in the
> original code from Martijn/Kamil. Now that you're mainlining the code, this
> should be sorted out, though.
> 
> There's no FW issue, I was just using the log to show you the actual chip ID the
> driver detects.
>

Gotcha.
 
> (You should probably put my SoB after Kamil/Martijn, since I took the
> maintenance/development of the driver after they wrote the base support
> initially in secret. I'm not the original author of the code.)
>

I wasn't aware of that. I just kept the author field as it's in your tree.
 
[...]

>> https://github.com/megous/linux/commit/f19ce7bb7d72
> 
> Yes, and test the driver more thoroughly:
> 
> - look at clk_summary to verify clock rate the kernel thinks it's using
> - test refresh rate, somehow, to again verify the actual clock rate (kernel can
>   lie in debugfs)
> - test power cycling the panel (eg. via system suspend/resume or other means)
> 

Agreed that the more testing the better.

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat


  reply	other threads:[~2023-01-02 13:35 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-30 11:31 [PATCH v4 0/4] Add PinePhone Pro " Javier Martinez Canillas
2022-12-30 11:31 ` [PATCH v4 1/4] dt-bindings: display: Add Himax HX8394 panel controller Javier Martinez Canillas
2022-12-30 11:31 ` [PATCH v4 2/4] drm: panel: Add Himax HX8394 panel controller driver Javier Martinez Canillas
2022-12-30 15:40   ` Ondřej Jirman
2022-12-31 15:15     ` Javier Martinez Canillas
2023-01-02 10:59       ` Ondřej Jirman
2023-01-02 13:51         ` Javier Martinez Canillas
2023-01-02 15:20           ` Ondřej Jirman
2023-01-02 18:51             ` Javier Martinez Canillas
2022-12-30 11:31 ` [PATCH v4 3/4] MAINTAINERS: Add entry for " Javier Martinez Canillas
2022-12-30 15:43   ` Ondřej Jirman
2022-12-31 15:16     ` Javier Martinez Canillas
2022-12-30 11:31 ` [PATCH v4 4/4] arm64: dts: rk3399-pinephone-pro: Add internal display support Javier Martinez Canillas
2022-12-30 15:37   ` Ondřej Jirman
2022-12-31 15:29     ` Javier Martinez Canillas
2023-01-02 10:57       ` Ondřej Jirman
2023-01-02 13:34         ` Javier Martinez Canillas [this message]
2023-01-01 21:21 ` [PATCH v4 0/4] Add PinePhone Pro " Pavel Machek
2023-01-02  9:44   ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6319a8b4-1152-40d8-29f1-015a8c5247f4@redhat.com \
    --to=javierm@redhat.com \
    --cc=ayufan@ayufan.eu \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=heiko@sntech.de \
    --cc=jagan@amarulasolutions.com \
    --cc=kc@postmarketos.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=maccraft123mc@gmail.com \
    --cc=martijn@brixit.nl \
    --cc=megi@xff.cz \
    --cc=ngompa13@gmail.com \
    --cc=pbrobinson@gmail.com \
    --cc=robert.mader@posteo.de \
    --cc=robh+dt@kernel.org \
    --cc=sam@ravnborg.org \
    --cc=thunderbirdtr@fedoraproject.org \
    --cc=tom@tom-fitzhenry.me.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®