From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>, Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
LUU HOAI <hoai.luu.ub@renesas.com>,
Jagan Teki <jagan@amarulasolutions.com>,
Sam Ravnborg <sam@ravnborg.org>,
Biju Das <biju.das.jz@bp.renesas.com>,
dri-devel@lists.freedesktop.org,
linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
linux-clk@vger.kernel.org,
Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
Subject: Re: [PATCH v3 10/10] arm64: dts: renesas: gray-hawk-single: Add DisplayPort support
Date: Mon, 16 Dec 2024 17:15:20 +0200 [thread overview]
Message-ID: <631bda4c-2226-4693-bcb8-a64872533c6c@ideasonboard.com> (raw)
In-Reply-To: <CAMuHMdXkXx6+0nJn+uLCAWOXvEYWLJXzLu9J7ksinn_z3bEfHQ@mail.gmail.com>
Hi,
On 16/12/2024 15:33, Geert Uytterhoeven wrote:
> Hi Tomi,
>
> On Fri, Dec 6, 2024 at 10:33 AM Tomi Valkeinen
> <tomi.valkeinen@ideasonboard.com> wrote:
>> From: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
>>
>> Add support for the mini DP output on the Gray Hawk board.
>>
>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
>> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
>> Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Thanks for your patch, which is now commit b1000645dc29701f
> ("arm64: dts: renesas: gray-hawk-single: Add DisplayPort support")
> in renesas-devel/renesas-dts-for-v6.14.
>
> Apparently this patch breaks s2idle on Gray Hawk Single when "[PATCH
> v3 06/10] drm/rcar-du: dsi: Add r8a779h0 support" is not present, or
> when CONFIG_DRM_RCAR_USE_MIPI_DSI is not enabled. If the DSI driver
> is not available, the ti_sn65dsi86.bridge part fails to probe with
> -EPROBE_DEFER and "failed to attach dsi host". Still, the sn65dsi86
> driver must do something critical, as resuming from s2idle now hangs.
> I haven't identified yet where exactly it hangs.
> > As a result, s2idle is broken in current renesas-devel, which only
> has the DTS changes. Perhaps I should drop the DTS until the issue
> is resolved?
I'm fine with that. The DT bindings are still under work anyway.
> However, I suspect White Hawk has the same issue (if
> CONFIG_DRM_RCAR_USE_MIPI_DSI=n), but I cannot verify as my local White
> Hawk is currently not available for kernel testing.
I can reproduce on White Hawk. And I agree that it's probably related to
sn65dsi86.
I use modules, so I tried dropping modules to see when the issue goes
away. And it's always sn65dsi86. So without the rcar DRM & DSI modules
loaded, if I load or don't load sn65dsi86, I see or don't see the hang,
respectively.
Even if I drop the ti_sn65dsi86_pm_ops, it doesn't help. And looks like
just doing the i2c_add_driver() part in ti_sn65dsi86_init() will cause
the issue, so it's something that happens there.
I'll continue the debug later.
Tomi
next prev parent reply other threads:[~2024-12-16 15:15 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 9:32 [PATCH v3 00/10] drm: Add DSI/DP support for Renesas r8a779h0 V4M and grey-hawk board Tomi Valkeinen
2024-12-06 9:32 ` [PATCH v3 01/10] drm/rcar-du: dsi: Fix PHY lock bit check Tomi Valkeinen
2024-12-06 9:32 ` [PATCH v3 02/10] drm/rcar-du: Write DPTSR only if the second source exists Tomi Valkeinen
2024-12-09 23:04 ` Laurent Pinchart
2024-12-09 23:23 ` Laurent Pinchart
2024-12-06 9:32 ` [PATCH v3 03/10] dt-bindings: display: bridge: renesas,dsi-csi2-tx: Add r8a779h0 Tomi Valkeinen
2024-12-06 9:32 ` [PATCH v3 04/10] dt-bindings: display: renesas,du: " Tomi Valkeinen
2024-12-11 15:45 ` Rob Herring
2024-12-13 14:04 ` Tomi Valkeinen
2024-12-06 9:32 ` [PATCH v3 05/10] clk: renesas: r8a779h0: Add display clocks Tomi Valkeinen
2024-12-06 13:43 ` Geert Uytterhoeven
2024-12-09 5:26 ` Tomi Valkeinen
2024-12-09 7:49 ` Geert Uytterhoeven
2024-12-09 21:40 ` Laurent Pinchart
2024-12-06 9:32 ` [PATCH v3 06/10] drm/rcar-du: dsi: Add r8a779h0 support Tomi Valkeinen
2024-12-06 9:32 ` [PATCH v3 07/10] drm/rcar-du: Add support for r8a779h0 Tomi Valkeinen
2024-12-06 9:32 ` [PATCH v3 08/10] arm64: dts: renesas: gray-hawk-single: Fix indentation Tomi Valkeinen
2024-12-10 15:50 ` Geert Uytterhoeven
2024-12-06 9:32 ` [PATCH v3 09/10] arm64: dts: renesas: r8a779h0: Add display support Tomi Valkeinen
2024-12-10 16:19 ` Geert Uytterhoeven
2024-12-06 9:32 ` [PATCH v3 10/10] arm64: dts: renesas: gray-hawk-single: Add DisplayPort support Tomi Valkeinen
2024-12-10 16:34 ` Geert Uytterhoeven
2024-12-10 18:09 ` Tomi Valkeinen
2024-12-11 8:16 ` Geert Uytterhoeven
2024-12-16 13:33 ` Geert Uytterhoeven
2024-12-16 15:15 ` Tomi Valkeinen [this message]
2024-12-16 17:02 ` Tomi Valkeinen
2024-12-17 13:29 ` Geert Uytterhoeven
2024-12-17 13:42 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=631bda4c-2226-4693-bcb8-a64872533c6c@ideasonboard.com \
--to=tomi.valkeinen@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=hoai.luu.ub@renesas.com \
--cc=jagan@amarulasolutions.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=magnus.damm@gmail.com \
--cc=mripard@kernel.org \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=sam@ravnborg.org \
--cc=sboyd@kernel.org \
--cc=simona@ffwll.ch \
--cc=tomi.valkeinen+renesas@ideasonboard.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®