From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev, Dragos Bogdan <dragos.bogdan@analog.com>
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
linux-kernel@vger.kernel.org,
Ley Foon Tan <ley.foon.tan@intel.com>,
Beniamin Bia <beniamin.bia@analog.com>
Subject: drivers/clk/uniphier/clk-uniphier-mux.c:47 uniphier_clk_mux_get_parent() warn: signedness bug returning '(-22)'
Date: Mon, 4 Dec 2023 10:50:34 +0300 [thread overview]
Message-ID: <6322ed2e-8f2d-49e5-bebf-2fb109790cd4@suswa.mountain> (raw)
Hi Dragos,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 33cc938e65a98f1d29d0a18403dbbee050dcad9a
commit: f26e433185cb2830b933df3a4d378558fe2fccd9 arch: nios2: Enable the common clk subsystem on Nios2
config: nios2-randconfig-r081-20231120 (https://download.01.org/0day-ci/archive/20231204/202312041541.LK8ZbiIf-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20231204/202312041541.LK8ZbiIf-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202312041541.LK8ZbiIf-lkp@intel.com/
smatch warnings:
drivers/clk/uniphier/clk-uniphier-mux.c:47 uniphier_clk_mux_get_parent() warn: signedness bug returning '(-22)'
vim +47 drivers/clk/uniphier/clk-uniphier-mux.c
734d82f4a678e8 Masahiro Yamada 2016-09-16 31 static u8 uniphier_clk_mux_get_parent(struct clk_hw *hw)
734d82f4a678e8 Masahiro Yamada 2016-09-16 32 {
734d82f4a678e8 Masahiro Yamada 2016-09-16 33 struct uniphier_clk_mux *mux = to_uniphier_clk_mux(hw);
734d82f4a678e8 Masahiro Yamada 2016-09-16 34 int num_parents = clk_hw_get_num_parents(hw);
734d82f4a678e8 Masahiro Yamada 2016-09-16 35 int ret;
c0ce317f0c8863 Masahiro Yamada 2016-10-17 36 unsigned int val;
734d82f4a678e8 Masahiro Yamada 2016-09-16 37 u8 i;
734d82f4a678e8 Masahiro Yamada 2016-09-16 38
734d82f4a678e8 Masahiro Yamada 2016-09-16 39 ret = regmap_read(mux->regmap, mux->reg, &val);
734d82f4a678e8 Masahiro Yamada 2016-09-16 40 if (ret)
734d82f4a678e8 Masahiro Yamada 2016-09-16 41 return ret;
734d82f4a678e8 Masahiro Yamada 2016-09-16 42
734d82f4a678e8 Masahiro Yamada 2016-09-16 43 for (i = 0; i < num_parents; i++)
734d82f4a678e8 Masahiro Yamada 2016-09-16 44 if ((mux->masks[i] & val) == mux->vals[i])
734d82f4a678e8 Masahiro Yamada 2016-09-16 45 return i;
734d82f4a678e8 Masahiro Yamada 2016-09-16 46
734d82f4a678e8 Masahiro Yamada 2016-09-16 @47 return -EINVAL;
kbuild has decided to dig through ancient warnings today. This function
is type u8 so returning -EINVAL doesn't work.
734d82f4a678e8 Masahiro Yamada 2016-09-16 48 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2023-12-04 7:50 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6322ed2e-8f2d-49e5-bebf-2fb109790cd4@suswa.mountain \
--to=dan.carpenter@linaro.org \
--cc=beniamin.bia@analog.com \
--cc=dragos.bogdan@analog.com \
--cc=ley.foon.tan@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®