From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755473AbdJLKq4 (ORCPT ); Thu, 12 Oct 2017 06:46:56 -0400 Received: from mout.web.de ([212.227.15.4]:64988 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752122AbdJLKqx (ORCPT ); Thu, 12 Oct 2017 06:46:53 -0400 Subject: [PATCH 06/10] staging/irda/net: Delete an unnecessary variable initialisation in two functions From: SF Markus Elfring To: devel@driverdev.osuosl.org, netdev@vger.kernel.org, Al Viro , Corentin Labbe , David Howells , "David S. Miller" , Georgiana Chelu , Greg Kroah-Hartman , Johannes Berg , Julia Lawall , Samuel Ortiz , Srishti Sharma , Stephen Hemminger , Yuan Linyu Cc: LKML , kernel-janitors@vger.kernel.org References: <8152401b-d68d-c4fe-2619-82a09e0c52ec@users.sourceforge.net> Message-ID: <632598f6-c36d-a672-edfe-fbf62e9a2e25@users.sourceforge.net> Date: Thu, 12 Oct 2017 12:46:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <8152401b-d68d-c4fe-2619-82a09e0c52ec@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:XujjVKH/JoUAzvTup7nLqDlVVlfoA/SI+DibcxOCnzNSHJkAlYg gyWyAQ81uq7Y5fx4RQOoyQcuB18l42Enhnmtc7p5tNlAskt6b3NGXVDAMBYFH6TqulyBAYj vsHWGhqWbBiXmTxfVKIleL6f7EjK3HeaDRdd6/rZY/SVsqiv/93mGFQ8PaB0em0eyNb7Fns lyeuKie0wAYhL88YcptOg== X-UI-Out-Filterresults: notjunk:1;V01:K0:C/B1FtwYkhQ=:qR8vppMj9rFWikn05AzdHS ELW5wD2ZEF55GFt86hayJrP2V5CSGqWWmVXRcE2YwcYWZugYUdA+5gwSyScoBxqH/qLjbrywX elBlGN5nbT0YF7xG8V12Dy1S9eIqQ0kO7IOpV9EQr1Vp0YqO1uzyyIe3i61wEwzMr81q+oWnm 6Dml27apm6/iR73Cxq3Z6yJrS0iUt7ztjvTmTG/LeySttVMuGJ/gI8b05B1yNj/M8lciLoE4w b3mSyyGa+BFA0ru0BSnHMeeDXq6MinHUi/+eLO4g+slhzKmGwVDJtQvtodVSlJDPFsTZpCgqL cmn4RUhuTdblsJNKtDgBde1/gBdGiQ4VdBo1JoPxyLL5titcyVuo69YMRhCq02pAT0x/RshwG Dvct95VXt0fvbOCi3GQNRNzM79IqPx5kQijQu3h89S2triGO0f9LZNjkdf6vvmCf6fNdJEl6C gaLk7SFX+HQcHLGJQM4oy+GoN2Q/3YXobZLSCWHTO/auS8OTvAUe/i1xY+e9zs4mLEU/Y3YKW T3x+yq9G0Hpo8h7IcyybsA4oBvRuaqZzDEAeK0q5d+WmF7o+yhPNnHWZWXL0X3lNJopBhXsxy pmDEx2BD4Kcr3iiey3vbjPKkECkRa6iPWjRZS5HL++DaWdEPp5pivfyfnct/aFCs7gc3q5gVr eFfVTLWl/35R6hyTPkr3WclLCFRlanCJUbrfPwZRisUvZ2+7OfTFD4WOEr2+25k/VkgkqZduc GTl4/xPQe/QR8L1UA1JV39oGcZ5fpFk+X0UaUsHiUKx8MZ8rVOF0U+weKHXt+ZgAG0eCdSJ+E goyp+1WEiRKZiTV/iWpGsXBbOjNOzruOllXNGYTokBA0fsVkik= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 11 Oct 2017 22:22:13 +0200 The local variable "tx_skb" will only be used in a single if branch of these functions. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring --- drivers/staging/irda/net/irlap_frame.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/irda/net/irlap_frame.c b/drivers/staging/irda/net/irlap_frame.c index 5b8be5b9812e..25ceb06efd58 100644 --- a/drivers/staging/irda/net/irlap_frame.c +++ b/drivers/staging/irda/net/irlap_frame.c @@ -862,7 +862,7 @@ void irlap_send_data_primary_poll(struct irlap_cb *self, struct sk_buff *skb) void irlap_send_data_secondary_final(struct irlap_cb *self, struct sk_buff *skb) { - struct sk_buff *tx_skb = NULL; + struct sk_buff *tx_skb; IRDA_ASSERT(self, return;); IRDA_ASSERT(self->magic == LAP_MAGIC, return;); @@ -922,7 +922,7 @@ void irlap_send_data_secondary_final(struct irlap_cb *self, */ void irlap_send_data_secondary(struct irlap_cb *self, struct sk_buff *skb) { - struct sk_buff *tx_skb = NULL; + struct sk_buff *tx_skb; /* Is this reliable or unreliable data? */ if (skb->data[1] == I_FRAME) { -- 2.14.2