From: wangyufen <wangyufen@huawei.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: <bvanassche@acm.org>, <jgg@ziepe.ca>,
<dennis.dalessandro@cornelisnetworks.com>,
<linux-rdma@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<andriy.shevchenko@linux.intel.com>, <bart.vanassche@wdc.com>,
<easwar.hariharan@intel.com>
Subject: Re: [PATCH v3 1/2] RDMA/hfi1: Fix error return code in parse_platform_config()
Date: Tue, 29 Nov 2022 09:30:27 +0800 [thread overview]
Message-ID: <632848a1-d363-7a20-8dd3-fae6645fc28d@huawei.com> (raw)
In-Reply-To: <Y4SiPfXbMoSc1E6M@unreal>
在 2022/11/28 19:57, Leon Romanovsky 写道:
> On Sat, Nov 26, 2022 at 09:50:53PM +0800, Wang Yufen wrote:
>> In the previous while loop, "ret" may be assigned zero, so the error
>> return code may be incorrectly set to 0 instead of -EINVAL.
>> Add bail_with_einval goto label and covert all "goto bail;" to "goto
>> bail_with_einval:" where it's appropriate. Add dropping some duplicative
>> "ret = -EINVAL;" lines, as Andy suggessted.
>>
>> Fixes: 97167e813415 ("staging/rdma/hfi1: Tune for unknown channel if configuration file is absent")
>> Signed-off-by: Wang Yufen <wangyufen@huawei.com>
>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> ---
>> drivers/infiniband/hw/hfi1/firmware.c | 20 +++++++++++---------
>> 1 file changed, 11 insertions(+), 9 deletions(-)
>
> <...>
>
>
>> +bail_with_einval:
>> + ret = -EINVAL;
>
> Sorry for being late, but no. It can be seen as anti-pattern as it
> causes to the situations where unrelated code changes can potentially
> overwrite return value. Please set valid return code before calling to
> goto.
OK, will change in v4.
Thanks
>
> Thanks
>
>> bail:
>> memset(pcfgcache, 0, sizeof(struct platform_config_cache));
>> return ret;
>> --
>> 1.8.3.1
>>
prev parent reply other threads:[~2022-11-29 1:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-26 13:50 Wang Yufen
2022-11-26 13:50 ` [PATCH v3 2/2] RDMA/srp: Fix error return code in srp_parse_options() Wang Yufen
2022-11-28 11:58 ` Leon Romanovsky
2022-11-28 11:57 ` [PATCH v3 1/2] RDMA/hfi1: Fix error return code in parse_platform_config() Leon Romanovsky
2022-11-29 1:30 ` wangyufen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=632848a1-d363-7a20-8dd3-fae6645fc28d@huawei.com \
--to=wangyufen@huawei.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bart.vanassche@wdc.com \
--cc=bvanassche@acm.org \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=easwar.hariharan@intel.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®