From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx3.molgen.mpg.de (mx3.molgen.mpg.de [141.14.17.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0464F13C8E8; Wed, 1 Oct 2025 06:17:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=141.14.17.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759299465; cv=none; b=qbIVz43lHdINOlZNH4Z3Yatw3j2D1Ll4J+5F6cX8dh/Ry85Dda2r7L7Ugbpa0uOxmpf/xI1mFDQH+7qdwNXCZ37r49GnUAwIiHesxoEt+CNxAWApuAQhjZ8IOq5DFXewIPpymxzqwp1iOV7igi3/DtnOEwu9UllUeeai2bLzjlg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759299465; c=relaxed/simple; bh=hxRvqUOFSmtT+K2+YA99pKt6+80fagkdz+VHNZ+rY8E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ci5yqp/FyktKhSyDMJ2hSGxFC1GyDNhOTuVZP50Qw+JxmR/6hY+ydl/rKmXkS+zxrGtzzNpSA1zGeEcmj8JyHYbMBK/Yht/0RwcVD6IeEjBFgBTBimEm8Yf9JTGOQENRKTTuKumlbejbnfkZbnox151XORaDZ8t7Jlbtxgrlq0M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=molgen.mpg.de; spf=pass smtp.mailfrom=molgen.mpg.de; arc=none smtp.client-ip=141.14.17.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=molgen.mpg.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=molgen.mpg.de Received: from [192.168.2.212] (p57bd9782.dip0.t-ipconnect.de [87.189.151.130]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: pmenzel) by mx.molgen.mpg.de (Postfix) with ESMTPSA id EB7A26028F357; Wed, 01 Oct 2025 08:17:03 +0200 (CEST) Message-ID: <632b054e-2c67-4d6d-9e61-435d1566fc4d@molgen.mpg.de> Date: Wed, 1 Oct 2025 08:17:02 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/2] Bluetooth: btusb: Add new VID/PID 0489/e135 for MT7920 To: Chris Lu Cc: Marcel Holtmann , Johan Hedberg , Luiz Von Dentz , Sean Wang , Will Lee , SS Wu , Steve Lee , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org References: <20251001060437.2298529-1-chris.lu@mediatek.com> <20251001060437.2298529-2-chris.lu@mediatek.com> Content-Language: en-US From: Paul Menzel In-Reply-To: <20251001060437.2298529-2-chris.lu@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Dear Chris, Thank you for your patch. In the summary *new* could be left out in the future. Maybe also put MT7920 in the front: Bluetooth: btusb: MT7920: Add VID:PID 0489:e135 Am 01.10.25 um 08:04 schrieb Chris Lu: > Add VID 0489 & PID e135 for MediaTek MT7920 USB Bluetooth chip. > > The information in /sys/kernel/debug/usb/devices about the Bluetooth > device is listed as the below. > > T: Bus=06 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 2 Spd=480 MxCh= 0 > D: Ver= 2.10 Cls=ef(misc ) Sub=02 Prot=01 MxPS=64 #Cfgs= 1 > P: Vendor=0489 ProdID=e135 Rev= 1.00 > S: Manufacturer=MediaTek Inc. > S: Product=Wireless_Device > S: SerialNumber=000000000 > C:* #Ifs= 3 Cfg#= 1 Atr=e0 MxPwr=100mA > A: FirstIf#= 0 IfCount= 3 Cls=e0(wlcon) Sub=01 Prot=01 > I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb > E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=125us > E: Ad=82(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb > E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms > E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms > I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb > E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms > E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms > I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb > E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms > E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms > I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb > E: Ad=83(I) Atr=01(Isoc) MxPS= 25 Ivl=1ms > E: Ad=03(O) Atr=01(Isoc) MxPS= 25 Ivl=1ms > I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb > E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms > E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms > I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb > E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms > E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms > I: If#= 1 Alt= 6 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb > E: Ad=83(I) Atr=01(Isoc) MxPS= 63 Ivl=1ms > E: Ad=03(O) Atr=01(Isoc) MxPS= 63 Ivl=1ms > I:* If#= 2 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=(none) > E: Ad=8a(I) Atr=03(Int.) MxPS= 64 Ivl=125us > E: Ad=0a(O) Atr=03(Int.) MxPS= 64 Ivl=125us > I: If#= 2 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=(none) > E: Ad=8a(I) Atr=03(Int.) MxPS= 64 Ivl=125us > E: Ad=0a(O) Atr=03(Int.) MxPS= 64 Ivl=125us > > Signed-off-by: Chris Lu > --- > drivers/bluetooth/btusb.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c > index 4be34c556db8..a2cde2284163 100644 > --- a/drivers/bluetooth/btusb.c > +++ b/drivers/bluetooth/btusb.c > @@ -621,6 +621,8 @@ static const struct usb_device_id quirks_table[] = { > /* Additional MediaTek MT7920 Bluetooth devices */ > { USB_DEVICE(0x0489, 0xe134), .driver_info = BTUSB_MEDIATEK | > BTUSB_WIDEBAND_SPEECH }, > + { USB_DEVICE(0x0489, 0xe135), .driver_info = BTUSB_MEDIATEK | > + BTUSB_WIDEBAND_SPEECH }, > { USB_DEVICE(0x13d3, 0x3620), .driver_info = BTUSB_MEDIATEK | > BTUSB_WIDEBAND_SPEECH }, > { USB_DEVICE(0x13d3, 0x3621), .driver_info = BTUSB_MEDIATEK | Reviewed-by: Paul Menzel Kind regards, Paul